fix(ci): restore docs and test type checks#98792
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 7:31 PM ET / 23:31 UTC. Summary PR surface: Tests +8, Docs +5. Total +13 across 2 files. Reproducibility: yes. I did not run local checks in this read-only review, but current source shows Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Land this narrow CI-restoration patch after the assigned maintainer is satisfied with exact-head CI, keeping the production attach CLI and gateway contracts unchanged. Do we have a high-confidence way to reproduce the issue? Yes. I did not run local checks in this read-only review, but current source shows Is this the best way to solve the issue? Yes. The patch keeps the production gateway contract unchanged, narrows only the test recorder boundary, and refreshes the generated docs-map entry for an existing page; widening or changing runtime types would be the wrong layer for this CI-only failure. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f8769559aecc. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +8, Docs +5. Total +13 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Merged via squash.
|
What Problem This Solves
Current
mainfailscheck-test-typesin the newly added attach CLI action tests, andcheck-docsreports that the generated docs map omits the attach CLI page.Why This Change Was Made
The gateway call contract exposes
paramsasunknown. The test recorder now validates that boundary before storing object parameters. The generated docs map is refreshed with the existing/cli/attachpage.User Impact
No runtime behavior changes. This restores the two CI checks that currently block unrelated pull requests.
Evidence
pnpm test src/cli/attach-cli.action.test.ts— 11 tests passedpnpm docs:map:check— up to dategit diff --check— passedpnpm check:changed -- docs/docs_map.md src/cli/attach-cli.action.test.ts— remote Testbox launch blocked locally because Crabbox 0.15.0 is older than the required 0.22.0; GitHub CI is the broad proof