Skip to content

fix(ci): restore docs and test type checks#98792

Merged
steipete merged 1 commit into
mainfrom
codex/restore-main-ci
Jul 1, 2026
Merged

fix(ci): restore docs and test type checks#98792
steipete merged 1 commit into
mainfrom
codex/restore-main-ci

Conversation

@steipete

@steipete steipete commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

Current main fails check-test-types in the newly added attach CLI action tests, and check-docs reports that the generated docs map omits the attach CLI page.

Why This Change Was Made

The gateway call contract exposes params as unknown. The test recorder now validates that boundary before storing object parameters. The generated docs map is refreshed with the existing /cli/attach page.

User Impact

No runtime behavior changes. This restores the two CI checks that currently block unrelated pull requests.

Evidence

  • pnpm test src/cli/attach-cli.action.test.ts — 11 tests passed
  • pnpm docs:map:check — up to date
  • git diff --check — passed
  • Autoreview — clean, 0.99 confidence
  • pnpm check:changed -- docs/docs_map.md src/cli/attach-cli.action.test.ts — remote Testbox launch blocked locally because Crabbox 0.15.0 is older than the required 0.22.0; GitHub CI is the broad proof

@steipete steipete self-assigned this Jul 1, 2026
@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation cli CLI command changes size: XS maintainer Maintainer-authored PR labels Jul 1, 2026
@clawsweeper

clawsweeper Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 7:31 PM ET / 23:31 UTC.

Summary
The PR refreshes the generated docs map for /cli/attach and narrows mocked gateway call params in attach CLI action tests before recording them.

PR surface: Tests +8, Docs +5. Total +13 across 2 files.

Reproducibility: yes. I did not run local checks in this read-only review, but current source shows docs/cli/attach.md missing from docs/docs_map.md and the gateway params type as unknown while the test recorder stores object params.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • [P1] The remaining action is protected-label maintainer merge handling after normal exact-head CI review; there is no focused automated repair to queue.

Security
Cleared: The diff only changes a generated docs map entry and test recorder typing; it does not alter runtime code, dependencies, workflows, secrets, or supply-chain surfaces.

Review details

Best possible solution:

Land this narrow CI-restoration patch after the assigned maintainer is satisfied with exact-head CI, keeping the production attach CLI and gateway contracts unchanged.

Do we have a high-confidence way to reproduce the issue?

Yes. I did not run local checks in this read-only review, but current source shows docs/cli/attach.md missing from docs/docs_map.md and the gateway params type as unknown while the test recorder stores object params.

Is this the best way to solve the issue?

Yes. The patch keeps the production gateway contract unchanged, narrows only the test recorder boundary, and refreshes the generated docs-map entry for an existing page; widening or changing runtime types would be the wrong layer for this CI-only failure.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against f8769559aecc.

Label changes

Label changes:

  • add P2: This fixes a normal-priority CI/docs/test-type regression with limited blast radius and no runtime behavior change.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: Real behavior proof is not required for this maintainer-labeled docs-map/test-type CI repair with no runtime behavior change; PR-body commands and GitHub checks are still useful validation.

Label justifications:

  • P2: This fixes a normal-priority CI/docs/test-type regression with limited blast radius and no runtime behavior change.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: Real behavior proof is not required for this maintainer-labeled docs-map/test-type CI repair with no runtime behavior change; PR-body commands and GitHub checks are still useful validation.
Evidence reviewed

PR surface:

Tests +8, Docs +5. Total +13 across 2 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 1 11 3 +8
Docs 1 5 0 +5
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 2 16 3 +13

What I checked:

Likely related people:

  • steipete: Live PR metadata assigns this PR to steipete, the PR carries the protected maintainer label, and CONTRIBUTING.md lists steipete as a repository maintainer, so final merge handling likely routes there. (role: assigned maintainer / likely follow-up owner; confidence: high; commits: 2fdb73067fe0; files: docs/docs_map.md, src/cli/attach-cli.action.test.ts)
  • anagnorisis2peripeteia: Merge commit 6df7db9f9e49c574bd12f2443869319a5661db89 and PR metadata for feat(cli): openclaw attach — launch an external harness bound to a gateway session #96454 show this author introduced the attach CLI, attach docs page, and attach action tests now being repaired. (role: introduced attach CLI surface; confidence: high; commits: 6df7db9f9e49, f984f9087d2f; files: src/cli/attach-cli.ts, src/cli/attach-cli.action.test.ts, docs/cli/attach.md)
  • obviyus: PR metadata for feat(cli): openclaw attach — launch an external harness bound to a gateway session #96454 shows an additional attach CLI commit by obviyus, making them relevant to the merged attach behavior even though this cleanup PR is narrower. (role: adjacent contributor in merged attach PR; confidence: medium; commits: fcf060472605; files: src/cli/attach-cli.ts)
  • Peter Lindsey: git blame on scripts/generate-docs-map.mjs ties the generated docs map contract and check behavior to commit 2205bf9d2463f51b21590663a2a4cfeb70d21675. (role: generated docs map area contributor; confidence: medium; commits: 2205bf9d2463; files: scripts/generate-docs-map.mjs, docs/docs_map.md)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal backlog priority with limited blast radius. labels Jul 1, 2026
@steipete
steipete merged commit 17482a4 into main Jul 1, 2026
148 of 157 checks passed
@steipete
steipete deleted the codex/restore-main-ci branch July 1, 2026 23:36
@steipete

steipete commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Merged via squash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli CLI command changes docs Improvements or additions to documentation maintainer Maintainer-authored PR P2 Normal backlog priority with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. size: XS status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant