Allow alternate Zalo Bot API roots#98768
Conversation
|
Codex review: found issues before merge. Reviewed July 2, 2026, 9:17 PM ET / 01:17 UTC. Summary PR surface: Source +32, Tests +80. Total +112 across 6 files. Reproducibility: not applicable. this is a feature/config-surface PR rather than a reported bug. Source inspection confirms current main has a fixed Zalo API root and the PR adds the alternate-root path with focused tests. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land only after maintainers accept the trusted Do we have a high-confidence way to reproduce the issue? Not applicable: this is a feature/config-surface PR rather than a reported bug. Source inspection confirms current main has a fixed Zalo API root and the PR adds the alternate-root path with focused tests. Is this the best way to solve the issue? Mostly yes: resolving the root inside Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 381b44a9fc26. Label changesLabel justifications:
Evidence reviewedPR surface: Source +32, Tests +80. Total +112 across 6 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
05cc890 to
45ba233
Compare
45ba233 to
84d84f7
Compare
* Allow alternate Zalo Bot API roots * Normalize Zalo provider timestamps
* Allow alternate Zalo Bot API roots * Normalize Zalo provider timestamps
Summary
ZALO_API_URLfrom workspace dotenv propagationStack
getMeidentity contractZaloBotInfoor gateway identity labelingTests
node scripts/run-vitest.mjs extensions/zalo/src/api.test.ts extensions/zalo/src/monitor.image.polling.test.ts src/infra/dotenv.test.tspnpm format:check extensions/zalo/src/api.ts extensions/zalo/src/api.test.ts extensions/zalo/src/monitor.ts extensions/zalo/src/monitor.image.polling.test.ts src/infra/dotenv.ts src/infra/dotenv.test.tsgit diff --check.agents/skills/autoreview/scripts/autoreview --mode branch --base 91342b007d --stream-engine-output(clean, no actionable findings)