fix: warn on windows cloud synced state dirs#98471
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 3:20 AM ET / 07:20 UTC. Summary PR surface: Source +118, Tests +122, Docs +6. Total +246 across 5 files. Reproducibility: yes. from source, but not from a live Windows run in this review. Current main only has the macOS cloud-synced state-dir detector, so a Windows OneDrive-style state dir has no equivalent doctor warning path before this PR. Review metrics: none identified. Stored data model Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge a narrow state-integrity detector after redacted real Windows doctor output confirms the warning and the paired issue stays linked until the PR lands. Do we have a high-confidence way to reproduce the issue? Yes from source, but not from a live Windows run in this review. Current main only has the macOS cloud-synced state-dir detector, so a Windows OneDrive-style state dir has no equivalent doctor warning path before this PR. Is this the best way to solve the issue? Yes, with a proof gap. The state-integrity doctor module owns state-dir durability warnings and the structured health contribution consumes the same issue mapping, so adding a Windows sibling detector there is the narrow maintainable fix. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against b63e06f68aa0. Label changesLabel justifications:
Evidence reviewedPR surface: Source +118, Tests +122, Docs +6. Total +246 across 5 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
This pull request has been automatically marked as stale due to inactivity. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: warn on windows cloud synced state dirs This is item 1/1 in the current shard. Shard 7/22. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
|
Closing due to inactivity. |
Summary
openclaw doctorwarningsCloses #98470
Testing
git diff --checknode scripts/run-with-env.mjs OPENCLAW_VITEST_MAX_WORKERS=1 OPENCLAW_VITEST_NO_OUTPUT_TIMEOUT_MS=300000 -- node scripts/run-vitest.mjs run --config test/vitest/vitest.commands-light.config.ts src/commands/doctor-state-integrity.cloud-storage.test.ts --testTimeout=30000node scripts/check-docs-mdx.mjs docs/gateway/doctor.md docs/platforms/windows.mdNotes
corepack pnpm check:docswas attempted but produced no output before timing out in this Windows/OneDrive checkout; the two changed docs were validated with the repository MDX checker directly.