Skip to content

fix: warn on windows cloud synced state dirs#98471

Closed
haruaiclone-droid wants to merge 1 commit into
openclaw:mainfrom
haruaiclone-droid:codex/fix-windows-cloud-state-doctor
Closed

fix: warn on windows cloud synced state dirs#98471
haruaiclone-droid wants to merge 1 commit into
openclaw:mainfrom
haruaiclone-droid:codex/fix-windows-cloud-state-doctor

Conversation

@haruaiclone-droid

Copy link
Copy Markdown
Contributor

Summary

  • add Windows cloud-synced state-dir detection for OneDrive, Dropbox, Google Drive, and iCloud Drive paths
  • surface the new finding through structured doctor output, repair effects, and human openclaw doctor warnings
  • add Windows cloud-storage coverage to the light commands shard and document the Windows state-dir guidance

Closes #98470

Testing

  • git diff --check
  • node scripts/run-with-env.mjs OPENCLAW_VITEST_MAX_WORKERS=1 OPENCLAW_VITEST_NO_OUTPUT_TIMEOUT_MS=300000 -- node scripts/run-vitest.mjs run --config test/vitest/vitest.commands-light.config.ts src/commands/doctor-state-integrity.cloud-storage.test.ts --testTimeout=30000
  • node scripts/check-docs-mdx.mjs docs/gateway/doctor.md docs/platforms/windows.md

Notes

  • corepack pnpm check:docs was attempted but produced no output before timing out in this Windows/OneDrive checkout; the two changed docs were validated with the repository MDX checker directly.

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation gateway Gateway runtime commands Command implementations size: M triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. labels Jul 1, 2026
@clawsweeper

clawsweeper Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 3:20 AM ET / 07:20 UTC.

Summary
The branch adds Windows cloud-synced state-dir doctor detection, structured finding and repair-effect mapping, focused tests, and Windows/Doctor docs.

PR surface: Source +118, Tests +122, Docs +6. Total +246 across 5 files.

Reproducibility: yes. from source, but not from a live Windows run in this review. Current main only has the macOS cloud-synced state-dir detector, so a Windows OneDrive-style state dir has no equivalent doctor warning path before this PR.

Review metrics: none identified.

Stored data model
Persistent data-model change detected: migration/backfill/repair: docs/platforms/windows.md, migration/backfill/repair: src/commands/doctor-state-integrity.cloud-storage.test.ts, migration/backfill/repair: src/commands/doctor-state-integrity.ts, migration/backfill/repair: test/vitest/vitest.commands-light-paths.mjs, unknown-data-model-change: src/commands/doctor-state-integrity.cloud-storage.test.ts, unknown-data-model-change: src/commands/doctor-state-integrity.ts. Confirm migration or upgrade compatibility proof before merge.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #98470
Summary: This PR is the linked candidate fix for the Windows cloud-synced state-dir doctor issue, and no other canonical related item was found in the targeted search.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🐚 platinum hermit
Result: blocked until real behavior proof is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P1] Add redacted Windows terminal output or a terminal screenshot showing openclaw doctor warning for a cloud-synced state dir after this patch.
  • Update the PR body with the proof artifact so ClawSweeper can re-review the current head.

Proof guidance:

  • [P1] Needs real behavior proof before merge: The PR body lists test commands but does not show after-fix Windows doctor output, screenshot, logs, or another redacted real behavior artifact demonstrating the new warning. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Risk before merge

  • [P1] External PR proof is missing: the body lists commands but no redacted Windows openclaw doctor output showing the new warning for a OneDrive, Dropbox, Google Drive, or iCloud Drive state dir.

Maintainer options:

  1. Decide the mitigation before merge
    Merge a narrow state-integrity detector after redacted real Windows doctor output confirms the warning and the paired issue stays linked until the PR lands.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • [P1] Human review should wait for contributor-supplied real Windows doctor proof; there is no narrow automated code repair identified from this pass.

Security
Cleared: No security or supply-chain concern was found; the diff changes doctor diagnostics, docs, and tests without new dependencies, workflows, secrets handling, or code download paths.

Review details

Best possible solution:

Merge a narrow state-integrity detector after redacted real Windows doctor output confirms the warning and the paired issue stays linked until the PR lands.

Do we have a high-confidence way to reproduce the issue?

Yes from source, but not from a live Windows run in this review. Current main only has the macOS cloud-synced state-dir detector, so a Windows OneDrive-style state dir has no equivalent doctor warning path before this PR.

Is this the best way to solve the issue?

Yes, with a proof gap. The state-integrity doctor module owns state-dir durability warnings and the structured health contribution consumes the same issue mapping, so adding a Windows sibling detector there is the narrow maintainable fix.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against b63e06f68aa0.

Label changes

Label justifications:

  • P2: This is a normal-priority Windows doctor diagnostic bug fix with limited blast radius and no evidence of an urgent runtime outage.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🐚 platinum hermit.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body lists test commands but does not show after-fix Windows doctor output, screenshot, logs, or another redacted real behavior artifact demonstrating the new warning. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed

PR surface:

Source +118, Tests +122, Docs +6. Total +246 across 5 files.

View PR surface stats
Area Files Added Removed Net
Source 1 118 0 +118
Tests 2 123 1 +122
Docs 2 7 1 +6
Config 0 0 0 0
Generated 0 0 0 0
Other 0 0 0 0
Total 5 248 2 +246

What I checked:

  • PR diff: The head diff adds a windows-cloud-state-dir issue kind, a Windows cloud storage detector, structured health finding and repair-effect handling, a human noteStateIntegrity warning, tests, and docs updates. (src/commands/doctor-state-integrity.ts:91, 81eaec14bf1e)
  • Current main behavior: Current main calls only detectMacCloudSyncedStateDir before Linux state storage checks in detectStateIntegrityHealthIssues; the source search found no Windows cloud-state detector on main. (src/commands/doctor-state-integrity.ts:779, b63e06f68aa0)
  • Doctor entry points: Human doctor output calls noteStateIntegrity, and the structured health contribution maps detectStateIntegrityHealthIssues through finding and repair-effect converters, so the PR touches the right runtime path for both outputs. (src/flows/doctor-health-contributions.ts:613, b63e06f68aa0)
  • Sibling coverage: Existing current-main sibling tests cover macOS cloud state and Linux SD/eMMC state detectors; the PR adds analogous Windows cloud-storage cases and includes the new test in the commands-light shard map. (src/commands/doctor-state-integrity.cloud-storage.test.ts:1, b63e06f68aa0)
  • Docs context: Current docs describe macOS cloud-synced state-dir warnings and the Windows Gateway page currently lacks the new Windows cloud-state guidance; the PR updates both surfaces to match the new detector. Public docs: docs/gateway/doctor.md. (docs/gateway/doctor.md:400, b63e06f68aa0)
  • Proof gate: The PR body lists commands that were run, but it does not include redacted Windows openclaw doctor output, logs, terminal screenshot, or another after-fix real behavior artifact showing the new warning; GitHub's Real behavior proof check is failing. (81eaec14bf1e)

Likely related people:

  • xialonglee: The current state-integrity module, macOS cloud-state detector, cloud-storage tests, and related docs all blame to commit e172447, whose merged PR metadata lists xialonglee as author. (role: introduced current state-integrity module; confidence: medium; commits: e1724474d639; files: src/commands/doctor-state-integrity.ts, src/commands/doctor-state-integrity.cloud-storage.test.ts, docs/gateway/doctor.md)
  • giodl73-repo: Recent commits in src/flows/doctor-health-contributions.ts expose several Doctor diagnostics as structured findings, adjacent to this PR's structured state-integrity output path. (role: recent adjacent doctor structured-health contributor; confidence: medium; commits: a1cddbdb5787, 4ac5cf863673, 816038e97a5d; files: src/flows/doctor-health-contributions.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal backlog priority with limited blast radius. labels Jul 1, 2026
@openclaw-barnacle

Copy link
Copy Markdown

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

@openclaw-barnacle openclaw-barnacle Bot added the stale Marked as stale due to inactivity label Jul 17, 2026
@clawsweeper

clawsweeper Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix: warn on windows cloud synced state dirs This is item 1/1 in the current shard. Shard 7/22.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@openclaw-barnacle

Copy link
Copy Markdown

Closing due to inactivity.
If you believe this PR should be revived, post in #clawtributors on Discord to talk to a maintainer.
That channel is the escape hatch for high-quality PRs that get auto-closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands Command implementations docs Improvements or additions to documentation gateway Gateway runtime P2 Normal backlog priority with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. size: M stale Marked as stale due to inactivity status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: openclaw doctor misses Windows cloud-synced state dirs

1 participant