Skip to content

fix: treat macos protocol mismatch as terminal#98444

Closed
haruaiclone-droid wants to merge 1 commit into
openclaw:mainfrom
haruaiclone-droid:codex/fix-macos-protocol-mismatch-terminal
Closed

fix: treat macos protocol mismatch as terminal#98444
haruaiclone-droid wants to merge 1 commit into
openclaw:mainfrom
haruaiclone-droid:codex/fix-macos-protocol-mismatch-terminal

Conversation

@haruaiclone-droid

@haruaiclone-droid haruaiclone-droid commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the Swift PROTOCOL_MISMATCH auth detail code
  • classify protocol mismatch connect failures as non-recoverable so macOS stops reconnecting
  • add a GatewayChannel regression test for terminal protocol mismatch failures

Closes #98442

Testing

  • git diff --check
  • Not run: Swift tests (swift --version fails on this Windows environment: Swift toolchain is not installed)

@openclaw-barnacle openclaw-barnacle Bot added app: macos App: macos size: XS triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. labels Jul 1, 2026
@clawsweeper

clawsweeper Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix: treat macos protocol mismatch as terminal This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal backlog priority with limited blast radius. labels Jul 1, 2026
@clawsweeper clawsweeper Bot mentioned this pull request Jul 6, 2026
Merged
@steipete

steipete commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Thanks for the focused report and patch. This is superseded by #98385 / ad59492d3ca9261a941721c864b2bc2278b63957, which landed before this PR was opened.

Current main contains the same PROTOCOL_MISMATCH terminal classification plus version metadata and actionable older-app/older-gateway recovery guidance. Shared OpenClawKit tests cover isNonRecoverable, problem mapping, and structured connect-error parsing, so there is no remaining behavior from this branch to land.

@steipete steipete closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

app: macos App: macos P2 Normal backlog priority with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. size: XS status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: macOS GatewayChannel reconnects after protocol mismatch failures

2 participants

@haruaiclone-droid @steipete