Verify signed marketplace feed refresh#98338
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 9, 2026, 1:41 PM ET / 17:41 UTC. Summary PR surface: Source +315, Tests +571, Generated +10, Other 0. Total +896 across 11 files. Reproducibility: not applicable. as a bug repro, but the changed behavior is source-reproducible: the exact-head harness and focused tests exercise signed refresh, trust persistence, offline signed snapshot reverify, and rollback rejection. Review metrics: 2 noteworthy metrics.
Stored data model Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land this slice only after maintainer security-boundary acceptance on the current head, keeping CLI trust-state display and default ClawHub trust-root work in their separate stacked PRs. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug repro, but the changed behavior is source-reproducible: the exact-head harness and focused tests exercise signed refresh, trust persistence, offline signed snapshot reverify, and rollback rejection. Is this the best way to solve the issue? Yes, this is the best bounded slice: it consumes the already-merged verifier/config primitives in the catalog refresh owner, persists only bounded trust metadata, and leaves CLI visibility/default-root policy to stacked follow-ups. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 745b8c315eaa. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +315, Tests +571, Generated +10, Other 0. Total +896 across 11 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (24 earlier review cycles; latest 8 shown)
|
27be652 to
bf3a3a7
Compare
|
@clawsweeper re-review Applied the duplicate trust-anchor fix: config rejects duplicate key IDs/material and the verifier now counts thresholds over unique normalized public-key material. Added envelope regression coverage for same key material under two key IDs with threshold 2, reran focused tests, tsgo, Kysely, lint/format, and updated the PR body. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
bf3a3a7 to
3ce0cfa
Compare
|
@clawsweeper re-review Final head is 3ce0cfa, rebased on source-profile 16cbe67. The stack now rejects malformed raw base64url keys, rejects duplicate trust anchors, and counts thresholds over unique normalized public-key material. Focused tests, tsgo, Kysely, lint/format, and Codex review are clean; PR body updated. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review The current review already marks proof sufficient, but the label still says waiting on author. Please refresh against head |
308bf3d to
01e1f22
Compare
|
Exact-head update for Validation run in
Additional regression for the ClawSweeper P1: Source-harness proof on exact head: This preserves the intended behavior: a verified signed hosted refresh persists signed trust state, offline mode re-verifies the signed snapshot, and a signed rollback attempt falls back to the newer signed snapshot without replacing it. |
6423fda to
3b6d07c
Compare
|
Restacked exact-head update for The rebase onto current
Source-harness proof on the new exact head: The previous broader validation remains applicable to the same PR-owned diff, and GitHub exact-head CI is running again for this restacked head. |
3b6d07c to
868375b
Compare
|
Second restacked exact-head update for The rebase onto current
Source-harness proof on the new exact head: GitHub exact-head CI is running again for this restacked head. |
|
Merged via squash.
|
Summary
Validation