Streamline OpenClaw onboarding#98218
Conversation
|
Codex review: found issues before merge. Reviewed June 30, 2026, 2:17 PM ET / 18:17 UTC. Summary PR surface: Source +2275, Tests +2011, Docs +1, Other +3. Total +4290 across 55 files. Reproducibility: yes. for the PR-introduced issues: source comparison shows the setup routing change, the removed skill install selection, and the new config key without matching baseline coverage. I did not run the changed CLI flows because this review is read-only. Review metrics: 3 noteworthy metrics.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land only after maintainers confirm the setup/onboarding direction, preserve or fully migrate the baseline setup contract, restore explicit installer consent or record a security decision, refresh config baselines, and sequence this branch against the broader onboarding PR. Do we have a high-confidence way to reproduce the issue? Yes for the PR-introduced issues: source comparison shows the setup routing change, the removed skill install selection, and the new config key without matching baseline coverage. I did not run the changed CLI flows because this review is read-only. Is this the best way to solve the issue? No. The direction may be useful, but this is not the best merge shape until setup compatibility, installer consent, config baseline coverage, and sequencing with the broader onboarding PR are resolved. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 3f147ae5cacc. Label changesLabel justifications:
Evidence reviewedPR surface: Source +2275, Tests +2011, Docs +1, Other +3. Total +4290 across 55 files. View PR surface stats
Security concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
639f234 to
d02d88d
Compare
ee5925b to
e9bc5f6
Compare
e9bc5f6 to
0a6e90d
Compare
|
Land-ready proof for exact head What changed:
Local proof after the latest rebase:
GitHub proof:
Known gap:
|
* feat: streamline onboarding setup flow * fix: harden onboarding preflight installs * test: isolate gateway preflight safety env * fix: keep local gateway probes on loopback * fix: honor onboarding node manager installs * docs: align setup onboarding reference * fix: harden bare gateway probe fallback * fix: honor env gateway auth in bare TUI probe * test: isolate wizard TUI hatch mocks
* feat: streamline onboarding setup flow * fix: harden onboarding preflight installs * test: isolate gateway preflight safety env * fix: keep local gateway probes on loopback * fix: honor onboarding node manager installs * docs: align setup onboarding reference * fix: harden bare gateway probe fallback * fix: honor env gateway auth in bare TUI probe * test: isolate wizard TUI hatch mocks
* feat: streamline onboarding setup flow * fix: harden onboarding preflight installs * test: isolate gateway preflight safety env * fix: keep local gateway probes on loopback * fix: honor onboarding node manager installs * docs: align setup onboarding reference * fix: harden bare gateway probe fallback * fix: honor env gateway auth in bare TUI probe * test: isolate wizard TUI hatch mocks
* feat: streamline onboarding setup flow * fix: harden onboarding preflight installs * test: isolate gateway preflight safety env * fix: keep local gateway probes on loopback * fix: honor onboarding node manager installs * docs: align setup onboarding reference * fix: harden bare gateway probe fallback * fix: honor env gateway auth in bare TUI probe * test: isolate wizard TUI hatch mocks
Summary
openclawlaunch onboarding for fresh config and launch the TUI for configured installs, using a reachable gateway when available and falling back to local mode.openclaw setupa full onboarding alias, including non-interactive auth/provider flags and migration import options.Verification
node scripts/run-vitest.mjs src/cli/program/register.setup.test.ts src/cli/program/register.onboard.test.ts src/wizard/setup.migration-import.test.ts src/wizard/clack-prompter.test.ts src/wizard/navigation-prompter.test.ts src/cli/run-main.exit.test.ts src/wizard/setup.finalize.test.ts src/wizard/clack-navigation-prompts.test.ts src/wizard/setup.test.ts src/commands/onboard-skills.test.tsgit diff --check && git diff --name-only upstream/main..HEAD | xargs pnpm exec oxfmt --check --threads=1node scripts/run-tsgo.mjs -p tsconfig.core.json --incremental --tsBuildInfoFile .artifacts/tsgo-cache/core.tsbuildinfonode scripts/run-tsgo.mjs -p test/tsconfig/tsconfig.core.test.json --incremental --tsBuildInfoFile .artifacts/tsgo-cache/core-test.tsbuildinfo$AUTOREVIEW --mode branch --base upstream/maindocker build -t openclaw:onboarding-main-revamp .docker run --rm openclaw:onboarding-main-revamp openclaw --version->OpenClaw 2026.6.10