fix: close readline interface and destroy read stream in transcript store by zhangLei99586 · Pull Request #98140 · openclaw/openclaw

zhangLei99586 · 2026-06-30T12:05:58Z

Related: #98467

What Problem This Solves

createReadStream + readline.createInterface not cleaned up after for await loop — fd leaks on JSON.parse throw.

Why This Change Was Made

Wrap loop in try/finally that calls lines.close() and stream.destroy().

User Impact

No user-visible change. Prevents fd exhaustion reading large transcripts.

Evidence

Runtime terminal proof:

10/10 tests passed (transcripts-tool.test.ts) — stream.destroyed: true confirmed at runtime

clawsweeper · 2026-06-30T12:08:29Z

Thanks for the context here. I swept through the related work, and this is now duplicate or superseded.

Close: this PR is superseded by the merged canonical transcript cleanup PR; current main has the same stream/readline cleanup plus focused fd-leak regression tests, and this branch is now conflicting with no meaningful unique remainder.

Root-cause cluster
Relationship: superseded
Canonical: #98493
Summary: The merged sibling PR is the canonical fix for the same transcript fd cleanup root cause.

Members:

canonical: fix(transcripts): close readline interface and destroy read stream on error exit #98493 - It merged the same cleanup with regression tests and closed the linked transcript cleanup issue.
fixed_by_candidate: transcripts: file descriptor leak in readUtterancesFromDir stream cleanup #98467 - The issue reports this same transcript reader cleanup bug and was closed by the canonical merged PR.
superseded: fix(transcripts): close stream on parse error in readUtterancesFromDir (fixes #98467) #98584 - A maintainer closed this same-root branch as covered by the canonical merged PR.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Canonical path: The sibling PR #98493 merged on July 1, 2026 and added the same cleanup plus tests, closing #98467.

So I’m closing this here and keeping the remaining discussion on #98493 and #98467.

Review details

Best possible solution:

Keep the merged current-main cleanup and regression tests from the canonical PR, and close this conflicting duplicate branch.

Do we have a high-confidence way to reproduce the issue?

Yes, source-level: the pre-fix bounded transcript reader created readline over an inline stream and could exit on JSON.parse throw without local cleanup. Current main now has Linux fd regression tests for malformed JSON and happy-path cleanup.

Is this the best way to solve the issue?

No for this branch. A same-or-better fix with focused tests already landed through #98493, so merging this conflicting branch is no longer the best path.

Security review:

Security review cleared: The diff only changes local transcript file stream cleanup and does not touch dependencies, workflows, package metadata, permissions, credentials, or secrets.

AGENTS.md: found and applied where relevant.

What I checked:

Repository policy read: Read the full root AGENTS.md and applied the OpenClaw PR-review guidance requiring source, related-item, current-main, release, and history checks before a close verdict. (AGENTS.md:1, 5002a0e9ea99)
Current main source cleanup: Current main creates a named transcript read stream, passes it to readline, then closes the readline interface, destroys the stream, and awaits close when needed in the bounded reader. (src/transcripts/store.ts:199, 5002a0e9ea99)
Current main regression coverage: Current main includes Linux fd regression tests for both malformed JSON and happy-path reads through TranscriptsStore.readUtterancesFromSessionDir. (src/transcripts/store.test.ts:66, 5002a0e9ea99)
Canonical merged fix: The sibling PR fix(transcripts): close readline interface and destroy read stream on error exit #98493 merged on July 1, 2026 and added the same cleanup plus tests, closing transcripts: file descriptor leak in readUtterancesFromDir stream cleanup #98467. (94cb14b97ead)
Current PR state: Live GitHub metadata reports this PR as CONFLICTING/DIRTY after the canonical fix landed; its only changed file is the same transcript store source file. (src/transcripts/store.ts:196, 1f7fac7d6fb9)
Release provenance: The latest release v2026.6.11 still has the old inline createReadStream path and no src/transcripts/store.test.ts, while git tag --contains 94cb14b returned no tags, so the canonical fix is current-main-only/unreleased. (src/transcripts/store.ts:199, e085fa1a3ffd)

Likely related people:

wangmiao0668000666: Authored the merged sibling PR that added the same transcript stream cleanup plus focused regression tests. (role: canonical fix author; confidence: high; commits: 64bac6195c93, 94cb14b97ead; files: src/transcripts/store.ts, src/transcripts/store.test.ts)
vincentkoc: Merged the canonical cleanup PR and closed another same-root transcript cleanup PR as covered by that canonical fix. (role: merger and duplicate cleanup; confidence: high; commits: 94cb14b97ead; files: src/transcripts/store.ts, src/transcripts/store.test.ts)

Codex review notes: model internal, reasoning high; reviewed against 5002a0e9ea99; fix evidence: commit 94cb14b97ead, main fix timestamp 2026-07-01T04:52:13-07:00.

zhangLei99586

@clawsweeper re-review

zhangLei99586 · 2026-07-01T02:24:39Z

@clawsweeper re-review

clawsweeper · 2026-07-01T02:24:41Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

zhangLei99586 · 2026-07-01T06:21:46Z

@clawsweeper review

The createReadStream and readline.createInterface were not cleaned up after use. If JSON.parse threw inside the loop, the file descriptor remained open. Wrap the loop in try/finally to close the readline interface and destroy the underlying stream, ensuring the file descriptor is always released.

zhangLei99586 · 2026-07-01T06:31:09Z

@clawsweeper re-review

clawsweeper · 2026-07-01T06:31:12Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

zhangLei99586 · 2026-07-01T06:46:08Z

@clawsweeper re-review

zhangLei99586 · 2026-07-01T08:18:38Z

@clawsweeper re-review

zhangLei99586 · 2026-07-01T08:29:40Z

@clawsweeper re-review

zhangLei99586 · 2026-07-01T08:33:33Z

Runtime behavior proof — terminal output from after-fix execution:

zhangLei99586 · 2026-07-01T08:35:16Z

Runtime behavior proof (terminal output):

zhangLei99586 · 2026-07-01T08:35:52Z

@clawsweeper re-review

zhangLei99586 · 2026-07-01T08:40:43Z

@clawsweeper re-review

zhangLei99586 · 2026-07-01T08:45:14Z

@clawsweeper re-review

stream.destroy() starts async teardown but returns immediately, so the fd could still be open when the method rethrows. Wait for the 'close' event when the stream is not already closed to ensure the descriptor is released before the caller handles the rejection.

zhangLei99586 · 2026-07-01T14:11:32Z

@clawsweeper re-review

clawsweeper · 2026-07-01T14:11:34Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

zhangLei99586 · 2026-07-02T15:35:07Z

@clawsweeper re-review

zhangLei99586 · 2026-07-03T06:24:40Z

@clawsweeper re-review

vincentkoc · 2026-07-06T07:52:21Z

Closing as superseded by #98493, which landed the same readline/stream cleanup in commit 94cb14b. Thanks for the contribution.

openclaw-barnacle Bot added the size: XS label Jun 30, 2026

zhangLei99586 commented Jul 1, 2026

View reviewed changes

zhangLei99586 force-pushed the fix/readline-stream-leak branch from a49365d to f6e7dd1 Compare July 1, 2026 06:30

clawsweeper Bot mentioned this pull request Jul 1, 2026

transcripts: file descriptor leak in readUtterancesFromDir stream cleanup #98467

Closed

wangmiao0668000666 mentioned this pull request Jul 1, 2026

fix(transcripts): close readline interface and destroy read stream on error exit #98493

Merged

clawsweeper Bot added status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. labels Jul 2, 2026

vincentkoc self-assigned this Jul 6, 2026

vincentkoc closed this Jul 6, 2026

Uh oh!

Uh oh!

Conversation

zhangLei99586 commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Uh oh!

clawsweeper Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhangLei99586 left a comment

Choose a reason for hiding this comment

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

clawsweeper Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

clawsweeper Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

zhangLei99586 commented Jul 1, 2026

Uh oh!

clawsweeper Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zhangLei99586 commented Jul 2, 2026

Uh oh!

zhangLei99586 commented Jul 3, 2026

Uh oh!

vincentkoc commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zhangLei99586 commented Jun 30, 2026 •

edited

Loading

clawsweeper Bot commented Jun 30, 2026 •

edited

Loading

clawsweeper Bot commented Jul 1, 2026 •

edited

Loading

clawsweeper Bot commented Jul 1, 2026 •

edited

Loading

clawsweeper Bot commented Jul 1, 2026 •

edited

Loading