Skip to content

fix(reply): skip gateway secrets.resolve for exec SecretRefs#97979

Closed
arkyu2077 wants to merge 1 commit into
openclaw:mainfrom
arkyu2077:fix-96653-reply-secretrefs
Closed

fix(reply): skip gateway secrets.resolve for exec SecretRefs#97979
arkyu2077 wants to merge 1 commit into
openclaw:mainfrom
arkyu2077:fix-96653-reply-secretrefs

Conversation

@arkyu2077

@arkyu2077 arkyu2077 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What Problem This Solves

Reply turns with exec-backed models.providers.*.apiKey SecretRefs currently call secrets.resolve against the gateway even though that RPC cannot execute those providers. The client immediately falls back to local resolution, so the turn succeeds, but every reply floods the gateway log with a misleading UNAVAILABLE error.

Summary

  • bypass reply-path secrets.resolve RPCs when active target SecretRefs already require local exec resolution
  • resolve those reply credentials locally up front instead of emitting a guaranteed UNAVAILABLE gateway error each turn
  • add a regression test covering models.providers.*.apiKey exec SecretRefs on the reply path

Evidence

  • pnpm exec vitest run src/agents/provider-transport-fetch.test.ts src/cli/command-secret-gateway.test.ts --maxWorkers 1
  • added regression coverage that asserts reply skips the gateway RPC, resolves models.providers.google.apiKey locally, and records resolved_local without calling callGateway

Closes #96653

@openclaw-barnacle openclaw-barnacle Bot added cli CLI command changes triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. size: S r: too-many-prs Auto-close: author has more than twenty active PRs. labels Jun 30, 2026
@openclaw-barnacle

Copy link
Copy Markdown

Closing this PR because the author has more than 20 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli CLI command changes size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: reply-path secrets.resolve floods gateway log with UNAVAILABLE for model-provider exec SecretRefs (degrades correctly, ~1 line/turn)

1 participant