fix(reply): skip gateway secrets.resolve for exec SecretRefs#97979
Closed
arkyu2077 wants to merge 1 commit into
Closed
fix(reply): skip gateway secrets.resolve for exec SecretRefs#97979arkyu2077 wants to merge 1 commit into
arkyu2077 wants to merge 1 commit into
Conversation
|
Closing this PR because the author has more than 20 active PRs in this repo. Please reduce the active PR queue and reopen or resubmit once it is back under the limit. You can close your own PRs to get back under the limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Reply turns with exec-backed
models.providers.*.apiKeySecretRefs currently callsecrets.resolveagainst the gateway even though that RPC cannot execute those providers. The client immediately falls back to local resolution, so the turn succeeds, but every reply floods the gateway log with a misleadingUNAVAILABLEerror.Summary
secrets.resolveRPCs when active target SecretRefs already require local exec resolutionUNAVAILABLEgateway error each turnmodels.providers.*.apiKeyexec SecretRefs on the reply pathEvidence
pnpm exec vitest run src/agents/provider-transport-fetch.test.ts src/cli/command-secret-gateway.test.ts --maxWorkers 1replyskips the gateway RPC, resolvesmodels.providers.google.apiKeylocally, and recordsresolved_localwithout callingcallGatewayCloses #96653