Skip to content

ci: bump ClawHub package publish workflow#97907

Merged
Patrick-Erichsen merged 1 commit into
mainfrom
pe/bump-clawhub-publish-workflow-family-fix
Jun 29, 2026
Merged

ci: bump ClawHub package publish workflow#97907
Patrick-Erichsen merged 1 commit into
mainfrom
pe/bump-clawhub-publish-workflow-family-fix

Conversation

@Patrick-Erichsen

Copy link
Copy Markdown
Contributor

What Problem This Solves

OpenClaw's existing-plugin ClawHub publish workflow was pinned to an older ClawHub reusable workflow SHA. That meant republishing code plugins such as @openclaw/discord, @openclaw/slack, @openclaw/voice-call, and @openclaw/whatsapp would still use ClawHub code from before the package-family detector fix, so packages containing openclaw.plugin.json plus skills/ markers could continue to be classified as bundle-plugin.

Why This Change Was Made

ClawHub PR openclaw/clawhub#2931 changed package-family detection so real bundle manifests win first, openclaw.plugin.json forces code-plugin, and loose skills/ markers only classify as bundle plugins after that. This PR updates the OpenClaw reusable workflow pin to the ClawHub merge commit containing that fix and updates the workflow acceptance assertion that guards the pin.

User Impact

Republishing the affected OpenClaw plugins through plugin-clawhub-release.yml will use the fixed ClawHub package publisher, avoiding the package-family mismatch that blocks updates for plugins that are actually OpenClaw code plugins.

Evidence

  • pnpm format:check .github/workflows/plugin-clawhub-release.yml test/scripts/package-acceptance-workflow.test.ts
  • git diff --check
  • node scripts/run-vitest.mjs test/scripts/package-acceptance-workflow.test.ts (40 passed)
  • PATH="/opt/homebrew/bin:$PATH" pnpm check:workflows
  • Autoreview local mode: clean, no accepted/actionable findings

@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Jun 29, 2026
@clawsweeper

clawsweeper Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge. Reviewed June 29, 2026, 3:08 PM ET / 19:08 UTC.

Summary
The PR updates OpenClaw's Plugin ClawHub Release workflow to call a newer pinned ClawHub package-publish reusable workflow and changes the guard test to expect that SHA.

PR surface: Tests -3, Config 0. Total -3 across 2 files.

Reproducibility: Source-level yes, live no: current main points at the old ClawHub publisher SHA and the upstream target contains the detector fix, but no real workflow dry-run or publish dispatch was provided.

Review metrics: 2 noteworthy metrics.

  • Reusable workflow pin: 1 changed. The single changed SHA determines which ClawHub publisher code runs from OpenClaw's plugin release workflow.
  • Upstream pin delta: 346 ClawHub commits, 1 reusable workflow changed. Maintainers need to review more than the final detector commit because the old pinned publisher is 346 commits behind the new target.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🦐 gold shrimp
Result: blocked until real behavior proof is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P1] Add a redacted plugin-clawhub-release.yml dry-run or publish log showing the affected package is classified as code-plugin.
  • Have a release/workflow owner explicitly review or accept the ClawHub pin delta from 9d49df... to 28409ee....

Proof guidance:

  • [P1] Needs real behavior proof before merge: The PR body provides local checks only; it still needs a redacted workflow dry-run or publish log showing the new pinned publisher behavior before merge. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Risk before merge

  • [P1] The new pin moves OpenClaw from ClawHub 9d49df109d4ad3dc8a6ecf05d26b39f46d294721 to 28409ee6ce9d088c9ddf0d6913cde6597f83f362, a 346-commit upstream delta that includes package-publish workflow and lockfile changes, so a release/workflow owner still needs to accept the executable publisher code.
  • [P1] The PR body lists local checks, but no redacted plugin-clawhub-release.yml dry-run or publish output proves the new pin classifies an OpenClaw code plugin with skills/ markers as code-plugin in the real workflow.
  • [P1] The protected maintainer label makes this a human-handled release automation PR rather than a conservative cleanup close or automated repair candidate.

Maintainer options:

  1. Require dry-run publish proof (recommended)
    Ask for a redacted plugin-clawhub-release.yml dry-run or equivalent publish log showing the new pin classifies an openclaw.plugin.json plus skills/ package as code-plugin before merge.
  2. Accept after owner trust review
    A release/workflow owner can explicitly accept the 346-commit ClawHub pin delta after reviewing the upstream publisher changes and exact-head checks.
  3. Pause for a narrower publisher pin
    If the upstream delta is too broad to review now, pause until ClawHub provides a smaller reviewed publisher SHA or maintainer-owned proof.

Next step before merge

  • [P1] The protected label, privileged workflow pin, and missing real dry-run proof require release/workflow owner handling rather than an automated repair lane.

Security
Needs attention: The patch intentionally changes executable release-publisher code reached through a privileged reusable workflow, so a maintainer trust review and proof are still required.

Review details

Best possible solution:

Have a release/workflow owner review the ClawHub upstream delta, add redacted real dry-run or publish proof, then merge the narrow pin update if the publisher behavior is verified.

Do we have a high-confidence way to reproduce the issue?

Source-level yes, live no: current main points at the old ClawHub publisher SHA and the upstream target contains the detector fix, but no real workflow dry-run or publish dispatch was provided.

Is this the best way to solve the issue?

Yes for the OpenClaw code shape: updating the pinned reusable workflow SHA and its guard assertion is the narrow fix. It is not merge-ready until the upstream publisher delta is accepted and real dry-run proof is added or explicitly waived.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 82dfd8910743.

Label changes

Label changes:

  • add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🦐 gold shrimp.
  • remove rating: 🦪 silver shellfish: Current PR rating is rating: 🧂 unranked krab, so this older rating label is no longer current.

Label justifications:

  • P2: This is normal-priority release automation maintenance that affects plugin publishing but is not an immediate user-facing runtime outage.
  • merge-risk: 🚨 automation: The diff changes the reusable workflow SHA used by plugin publishing, so merge affects release automation outside ordinary CI checks.
  • merge-risk: 🚨 security-boundary: The called publisher workflow runs with id-token: write and executes ClawHub code from the new SHA, making the exact upstream pin a trust boundary.
  • rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🦐 gold shrimp.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body provides local checks only; it still needs a redacted workflow dry-run or publish log showing the new pinned publisher behavior before merge. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.
Evidence reviewed

PR surface:

Tests -3, Config 0. Total -3 across 2 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 1 2 5 -3
Docs 0 0 0 0
Config 1 1 1 0
Generated 0 0 0 0
Other 0 0 0 0
Total 2 3 6 -3

Security concerns:

  • [medium] Review broad upstream publisher pin delta — .github/workflows/plugin-clawhub-release.yml:390
    The changed workflow line moves the ClawHub publisher to a SHA 346 upstream commits ahead of the old pin, and the called workflow runs with id-token: write; maintainers should accept that upstream code delta or request a narrower/proven pin before merge.
    Confidence: 0.86

What I checked:

Likely related people:

  • Patrick-Erichsen: Authored the upstream ClawHub package-family fix and prior merged OpenClaw ClawHub release workflow changes in the same workflow/test surface. (role: recent area contributor and upstream ClawHub fix author; confidence: high; commits: 28409ee6ce9d, 6cf06e8e7eb0, f05e9873c6d2; files: .github/workflows/plugin-clawhub-release.yml, test/scripts/package-acceptance-workflow.test.ts, openclaw/clawhub:packages/clawhub/src/cli/commands/packages.ts)
  • onutc: Authored merged OpenClaw PR CI: add ClawHub plugin release workflow #59179, which added the ClawHub plugin release workflow and original publish automation surface. (role: introduced workflow; confidence: high; commits: fa9e1e3d8eb2; files: .github/workflows/plugin-clawhub-release.yml, scripts/plugin-clawhub-publish.sh, scripts/lib/plugin-clawhub-release.ts)
  • vincentkoc: Recently changed the ClawHub release workflow behavior in commit f71ef47288739ef97e855f20e73ee79fc2ba2dbc, so he is a plausible release-workflow safety reviewer. (role: adjacent release workflow contributor; confidence: medium; commits: f71ef4728873, aa69b12d0086; files: .github/workflows/plugin-clawhub-release.yml, test/scripts/package-acceptance-workflow.test.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal backlog priority with limited blast radius. merge-risk: 🚨 security-boundary 🚨 May affect sandboxing, authorization, credentials, or sensitive data. merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Jun 29, 2026
@Patrick-Erichsen
Patrick-Erichsen merged commit d43366b into main Jun 29, 2026
195 of 207 checks passed
@Patrick-Erichsen
Patrick-Erichsen deleted the pe/bump-clawhub-publish-workflow-family-fix branch June 29, 2026 19:17
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jun 30, 2026
QiuYuang pushed a commit to QiuYuang/openclaw that referenced this pull request Jul 1, 2026
chenyangjun-xy pushed a commit to chenyangjun-xy/openclaw that referenced this pull request Jul 1, 2026
chenyangjun-xy pushed a commit to chenyangjun-xy/openclaw that referenced this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. merge-risk: 🚨 security-boundary 🚨 May affect sandboxing, authorization, credentials, or sensitive data. P2 Normal backlog priority with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. size: XS status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant