fix(discord): guard JSON.parse against malformed API response bodies by lsr911 · Pull Request #97889 · openclaw/openclaw

lsr911 · 2026-06-29T17:35:52Z

What Problem This Solves

extensions/discord/src/api.ts:198 calls JSON.parse(text) on the Discord API response body without try/catch. Malformed JSON → unhandled SyntaxError → process crash.

Changes

extensions/discord/src/api.ts: wrap JSON.parse(text) in try/catch → DiscordApiError("malformed JSON", 0)
extensions/discord/src/api.test.ts: test verifying malformed JSON → DiscordApiError
test/_proof_discord_json_guard.mts: v3 — calls requestDiscord with custom fetcher returning malformed JSON, exercises actual changed code path

Label: bugfix | merge-risk: 🟢 minimal | AI-assisted

Evidence

Real HTTP proof — calls requestDiscord (L2)

$ node --import tsx test/_proof_discord_json_guard.mts

PASS  malformed JSON: throws DiscordApiError :: type=DiscordApiError
PASS  malformed JSON: message describes malformed JSON :: msg="Discord API /users/@me returned malformed JSON"
PASS  malformed JSON: status=0 (not retryable) :: status=0
PASS  rate-limit: still throws DiscordApiError :: type=DiscordApiError
PASS  rate-limit: status preserved :: status=429
PASS  valid JSON: parsed correctly :: result={"id":"42","name":"test"}

[proof] 6 PASS, 0 FAIL

Unit test

pnpm exec vitest run extensions/discord/src/api.test.ts
 ✓ throws DiscordApiError on malformed JSON success response body
 Test Files  1 passed (1)

Fix history

v1: catch (cause) → lint error
v2: → catch + standalone proof (manually simulated)
v3: proof calls requestDiscord with custom fetcher returning malformed JSON, exercises the actual changed try/catch path

clawsweeper · 2026-06-29T17:37:01Z

Codex review: needs maintainer review before merge. Reviewed July 1, 2026, 8:28 PM ET / 00:28 UTC.

Summary
The branch wraps Discord requestDiscord successful-response JSON.parse failures in DiscordApiError and adds a colocated malformed-JSON regression test.

PR surface: Source +7, Tests +18. Total +25 across 2 files.

Reproducibility: yes. A custom fetcher returning malformed HTTP 200 JSON through fetchDiscord/requestDiscord directly exercises current main's raw parse path; I did not run it because this review is read-only, but the source path is direct and the PR body includes terminal proof.

Review metrics: none identified.

Stored data model
Persistent data-model change detected: serialized state: extensions/discord/src/api.ts. Confirm migration or upgrade compatibility proof before merge.

Root-cause cluster
Relationship: canonical
Canonical: #97889
Summary: This PR is the canonical candidate for malformed successful JSON in Discord requestDiscord; the Matrix sibling is merged and the Discord webhook OOM PR is adjacent but distinct.

Members:

same_root_cause: fix(matrix): guard JSON.parse against malformed homeserver response bodies #97973 - Merged Matrix PR applies the same malformed successful JSON guard pattern to a different channel HTTP client.
adjacent_distinct: fix(discord): bound webhook JSON response reads to prevent OOM #98628 - Open Discord webhook PR also concerns JSON response handling, but it targets webhook response-size bounding rather than requestDiscord malformed-body parsing.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Next step before merge

No automated repair remains; a maintainer needs to clear the explicit human-review/automerge pause or decide not to land this PR.

Security
Cleared: No concrete security or supply-chain regression was found; the diff hardens Discord response parsing and does not change dependencies, workflows, permissions, package metadata, or secret handling.

Review details

Best possible solution:

Land the narrow requestDiscord parse guard and regression test once a maintainer clears the human-review/automerge gate.

Do we have a high-confidence way to reproduce the issue?

Yes. A custom fetcher returning malformed HTTP 200 JSON through fetchDiscord/requestDiscord directly exercises current main's raw parse path; I did not run it because this review is read-only, but the source path is direct and the PR body includes terminal proof.

Is this the best way to solve the issue?

Yes. Catching the parse failure inside requestDiscord is the narrow owner-boundary fix because fetchDiscord callers share that helper and the retry policy already limits retries to Discord 429 errors.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 3558391a75fd.

Label changes

Label justifications:

P2: This is a normal-priority Discord robustness bugfix with limited blast radius in one shared API helper and its colocated regression test.
rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (terminal): The PR body includes after-fix terminal output exercising malformed, rate-limited, and valid requestDiscord paths, and the final head keeps the runtime guard plus regression test.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes after-fix terminal output exercising malformed, rate-limited, and valid requestDiscord paths, and the final head keeps the runtime guard plus regression test.

Evidence reviewed

PR surface:

Source +7, Tests +18. Total +25 across 2 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	1	8	1	+7
Tests	1	18	0	+18
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	2	26	1	+25

What I checked:

Current main behavior: Current main still decodes a non-empty successful Discord API response body and calls raw JSON.parse(text), so a malformed HTTP 200 body escapes as SyntaxError. (extensions/discord/src/api.ts:206, 3558391a75fd)
Latest release behavior: The latest release v2026.6.11 also uses raw successful-response JSON.parse(text), so this fix has not shipped yet. (extensions/discord/src/api.ts:198, e085fa1a3ffd)
PR runtime guard: The PR head catches successful-response parse failures and throws DiscordApiError("Discord API ... returned malformed JSON", 0). (extensions/discord/src/api.ts:206, 3573b455d2fd)
PR regression test: The added test drives fetchDiscord with a malformed HTTP 200 body and expects the normalized malformed-JSON DiscordApiError. (extensions/discord/src/api.test.ts:324, 3573b455d2fd)
Retry contract: retryAsync stops when shouldRetry is false, and requestDiscord retries only DiscordApiError status 429, so the new status 0 malformed-JSON error is not retried. (src/infra/retry.ts:156, 3558391a75fd)
Caller and sibling surface read: fetchDiscord is shared by Discord probe, directory, guild, channel, and user resolution paths; sibling Discord REST code already coerces malformed JSON rather than exposing raw parser errors. (extensions/discord/src/resolve-channels.ts:84, 3558391a75fd)

Likely related people:

Eva: git blame for the current requestDiscord helper and raw parse line points to commit 48974b5765d36b5229dd22dba27952b6a10dcb25. (role: current implementation author; confidence: medium; commits: 48974b5765d3; files: extensions/discord/src/api.ts, extensions/discord/src/api.test.ts)
Ayaan Zaidi: The same current-helper blame commit was committed by Ayaan Zaidi, making them a routing candidate for the current shape of this file. (role: committer of current implementation; confidence: medium; commits: 48974b5765d3; files: extensions/discord/src/api.ts)
steipete: Path history shows Peter Steinberger authored the retry runtime SDK seam and earlier Discord API retry/error work that this helper relies on. (role: adjacent retry/API contributor; confidence: high; commits: c222a44e6f4e, f70ac0c7c239, 80e6c070bfc2; files: extensions/discord/src/api.ts, src/plugin-sdk/retry-runtime.ts, src/infra/retry.ts)
scoootscooob: Path history shows this contributor moved the Discord implementation into extensions/, defining the current plugin owner boundary for this code. (role: extension migration contributor; confidence: medium; commits: 5682ec37fada; files: extensions/discord/src/api.ts, src/discord/api.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Takhoffman · 2026-07-01T11:41:35Z

@clawsweeper automerge

clawsweeper · 2026-07-01T11:41:39Z

🦞🧹
ClawSweeper automerge is enabled.

Head: 3573b455d2fd
Label: clawsweeper:automerge
Action: exact-head review queued (workflow sweep.yml, event repository_dispatch).
Flow: review this head, repair/rebase only if needed, then re-review the exact repaired head before merge.

Draft PRs stay fix-only until GitHub marks them ready for review. Pause with /clawsweeper stop.

Automerge progress:

2026-07-01 23:51:44 UTC automerge wait 8911d2507393 (blocked) in 15m 9s Run: https://github.com/openclaw/clawsweeper/actions/runs/28554836429 exact-head ClawSweeper review requires another repair

2026-07-01 23:43:39 UTC review queued c8d650d8a10b (queued)

2026-07-01 23:51:47 UTC repair finished 8911d2507393 (pushed) in 15m 13s Run: https://github.com/openclaw/clawsweeper/actions/runs/28554836429 repair_contributor_branch

2026-07-02 00:07:37 UTC review requested repair 8911d2507393 (structured ClawSweeper needs-human verdict with repairable P-severity findings...)

2026-07-01 23:52:09 UTC repair queued 8911d2507393 (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/28555524971

2026-07-02 00:01:04 UTC review queued 8911d2507393 (queued)

2026-07-01 23:54:00 UTC repair started (running) in 1s Run: https://github.com/openclaw/clawsweeper/actions/runs/28555524971 automerge-openclaw-openclaw-97889

2026-07-01 23:54:18 UTC validation plan (passed) in 19s Run: https://github.com/openclaw/clawsweeper/actions/runs/28555524971 pnpm check:changed; pnpm lint; pnpm check:test-types

2026-07-01 23:54:29 UTC Codex write preflight (passed) in 30s Run: https://github.com/openclaw/clawsweeper/actions/runs/28555524971 danger-full-access

2026-07-01 23:59:24 UTC Codex edit 1 7fca39c9218f (complete) in 5m 24s Run: https://github.com/openclaw/clawsweeper/actions/runs/28555524971 exit 0

2026-07-02 00:09:46 UTC validation and review 1 3573b455d2fd (complete) in 15m 46s Run: https://github.com/openclaw/clawsweeper/actions/runs/28555524971 already-current

2026-07-02 00:11:23 UTC repair completed 3573b455d2fd (branch updated) in 17m 23s Run: https://github.com/openclaw/clawsweeper/actions/runs/28555524971 initial automerge rebase is delegated to Codex repair

2026-07-02 00:11:22 UTC review queued 3573b455d2fd (after repair)

2026-07-02 00:17:00 UTC automerge wait 3573b455d2fd (human) in 23m Run: https://github.com/openclaw/clawsweeper/actions/runs/28555524971 exact-head ClawSweeper review requires human handling

2026-07-02 00:17:01 UTC repair finished 3573b455d2fd (pushed) in 23m 2s Run: https://github.com/openclaw/clawsweeper/actions/runs/28555524971 repair_contributor_branch

2026-07-02 00:17:30 UTC review queued 3573b455d2fd (queued)

Wrap JSON.parse(text) in requestDiscord with try/catch to prevent a malformed Discord API response body from throwing an unhandled SyntaxError and crashing the process. On parse failure, throw a DiscordApiError with a descriptive message so the caller can handle it gracefully. Co-Authored-By: Claude <[email protected]> Signed-off-by: lsr911 <[email protected]>

…9 (validation-1)

Signed-off-by: lsr911 <[email protected]>

clawsweeper · 2026-07-02T00:17:03Z

🦞✅
ClawSweeper is pausing this repair loop for human review.

Source: clawsweeper[bot]
Reason: - No automated repair remains; a maintainer needs to clear the explicit human-review/automerge pause or decide not to land this PR.; Cleared: No concrete security or supply-chain regression was found; the diff hardens Discord response parsing and does not change dependencies, workflows, permissions, package metadata, or secret handling. (sha=3573b455d2fdaec2891d3660abc7e37fcccbef88)

Why human review is needed:
This item has security-sensitive risk. ClawSweeper is pausing instead of making an autonomous change that could affect trust, credentials, permissions, or exposure.

What the maintainer can do as a next step:
If the maintainer accepts the current risk and wants ClawSweeper to continue merge gates, comment @clawsweeper approve. If the security-sensitive detail still needs changes, describe the safe path or push the fix, then comment @clawsweeper automerge. If the risk should not be automated, keep the PR paused for manual review or comment @clawsweeper stop.

I added clawsweeper:human-review and left the final call with a maintainer.

vincentkoc · 2026-07-02T00:49:44Z

Maintainer review complete on exact head 3573b455d2fdaec2891d3660abc7e37fcccbef88.

Land-ready proof:

node scripts/run-vitest.mjs extensions/discord/src/api.test.ts - 17/17 passed.
Direct requestDiscord malformed-JSON probe with retry.attempts=3 - returned DiscordApiError with status 0, exact path diagnostic, and one fetch call.
.agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main --stream-engine-output - clean, no findings, correctness confidence 0.98.
git diff --check origin/main...HEAD - passed.
OPENCLAW_TESTBOX=1 scripts/pr prepare-run 97889 - exact-head hosted CI/Testbox gates passed; 57 relevant checks complete with no failures or pending checks.

The ordinary local prepare path was intentionally stopped when pnpm asked to remove and reinstall all workspace module directories from the symlinked worktree. That was a dependency-layout prompt, not a patch failure; no shared modules were modified.

The final merge-base diff remains the narrow two-file Discord response guard. Valid JSON, blank bodies, response-size limits, and HTTP 429 retry behavior remain unchanged; malformed successful JSON now uses the owned non-retryable Discord error type.

vincentkoc · 2026-07-02T00:50:05Z

Merged via squash.

Prepared head SHA: 3573b455d2fdaec2891d3660abc7e37fcccbef88
Landed commit: 050e1f3b5c9fdd7148b045d02d54bd7a0ba21057

* origin/main: test(gateway): isolate live release agent state test(plugins): repair prerelease validation fixtures fix(discord): guard JSON.parse against malformed API response bodies (#97889) fix(codex): preserve app approvals in side forks (#98812) fix(agents): don't inject A2A turns into isolated-cron sessions_send (#92257) (#92283) fix(browser): guard setDeep against empty keys array (#98138) docs(telegram): move maintainer decisions into scoped AGENTS.md fix(ios): generate light app store screenshots only fix(gateway): distinguish reachable gateway from failed status probe (#98183)

…penclaw#97889) * fix(discord): guard JSON.parse against malformed API response bodies Wrap JSON.parse(text) in requestDiscord with try/catch to prevent a malformed Discord API response body from throwing an unhandled SyntaxError and crashing the process. On parse failure, throw a DiscordApiError with a descriptive message so the caller can handle it gracefully. Co-Authored-By: Claude <[email protected]> Signed-off-by: lsr911 <[email protected]> * fix(clawsweeper): address review for automerge-openclaw-openclaw-97889 (validation-1) * chore: trigger CI re-run for flaky checks-node-compact-small-whole-2 Signed-off-by: lsr911 <[email protected]> * chore: trigger CI re-run for flaky runtime-inventory-drift-check Signed-off-by: lsr911 <[email protected]> * chore: trigger CI re-run for flaky checks-node-compact-large-whole-1 Signed-off-by: lsr911 <[email protected]> * fix(discord): guard JSON.parse against malformed API response bodies * fix(discord): guard JSON.parse against malformed API response bodies --------- Signed-off-by: lsr911 <[email protected]> Co-authored-by: Claude <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com>

openclaw-barnacle Bot added channel: discord Channel integration: discord size: XS labels Jun 29, 2026

lsr911 force-pushed the fix/discord-json-parse-guard branch from 29e4b74 to 73da0d9 Compare June 29, 2026 18:43

openclaw-barnacle Bot added size: S and removed size: XS labels Jun 29, 2026

lsr911 force-pushed the fix/discord-json-parse-guard branch from 73da0d9 to 853e64a Compare June 30, 2026 01:35

lsr911 mentioned this pull request Jun 30, 2026

fix(matrix): guard JSON.parse against malformed homeserver response bodies #97973

Merged

clawsweeper Bot added the clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge label Jul 1, 2026

clawsweeper Bot force-pushed the fix/discord-json-parse-guard branch from 853e64a to 9dadf44 Compare July 1, 2026 12:01

openclaw-barnacle Bot added extensions: qa-lab size: M and removed size: S labels Jul 1, 2026

clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed merge-risk: 🚨 automation 🚨 May affect CI, automerge, proof capture, label sync, or maintainer automation. labels Jul 1, 2026

lsr911 and others added 7 commits July 2, 2026 00:05

fix(clawsweeper): address review for automerge-openclaw-openclaw-9788…

cd4592a

…9 (validation-1)

chore: trigger CI re-run for flaky checks-node-compact-small-whole-2

489ffcb

Signed-off-by: lsr911 <[email protected]>

chore: trigger CI re-run for flaky runtime-inventory-drift-check

fc89ac4

Signed-off-by: lsr911 <[email protected]>

chore: trigger CI re-run for flaky checks-node-compact-large-whole-1

40541ac

Signed-off-by: lsr911 <[email protected]>

fix(discord): guard JSON.parse against malformed API response bodies

f1a0e18

fix(discord): guard JSON.parse against malformed API response bodies

3573b45

clawsweeper Bot force-pushed the fix/discord-json-parse-guard branch from 8911d25 to 3573b45 Compare July 2, 2026 00:11

openclaw-barnacle Bot added size: XS and removed size: S labels Jul 2, 2026

vincentkoc self-assigned this Jul 2, 2026

vincentkoc merged commit 050e1f3 into openclaw:main Jul 2, 2026
113 of 120 checks passed

This was referenced Jul 2, 2026

fix(minimax): guard music generation SSE JSON.parse against malformed frames #98048

Closed

fix(discord): guard parseDiscordGatewayInfoBody JSON.parse against malformed API responses #98845

Closed

Haderach-Ram mentioned this pull request Jul 2, 2026

Ecosystem Digest — 2026-07-02 Haderach-Ram/openclaw-radar#67

Open

lsr911 mentioned this pull request Jul 2, 2026

fix(codex-supervisor): guard loadCodexSupervisorEndpoints JSON.parse against malformed env input #98857

Closed

github-actions Bot mentioned this pull request Jul 2, 2026

📡 Upstream Digest — 2026-07-02 02:32 UTC curtismercier/openclaw-mods#1186

Open

jiashu6 mentioned this pull request Jul 7, 2026

fix(gateway): guard JSON.parse in MCP loopback probe against malforme… #101759

Closed

27 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(discord): guard JSON.parse against malformed API response bodies#97889

fix(discord): guard JSON.parse against malformed API response bodies#97889
vincentkoc merged 7 commits into
openclaw:mainfrom
lsr911:fix/discord-json-parse-guard

lsr911 commented Jun 29, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

Takhoffman commented Jul 1, 2026

Uh oh!

clawsweeper Bot commented Jul 1, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jul 2, 2026 •

edited

Loading

Uh oh!

vincentkoc commented Jul 2, 2026

Uh oh!

Uh oh!

vincentkoc commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

lsr911 commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Changes

Evidence

Real HTTP proof — calls requestDiscord (L2)

Unit test

Fix history

Uh oh!

clawsweeper Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Takhoffman commented Jul 1, 2026

Uh oh!

clawsweeper Bot commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vincentkoc commented Jul 2, 2026

Uh oh!

Uh oh!

vincentkoc commented Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lsr911 commented Jun 29, 2026 •

edited

Loading

clawsweeper Bot commented Jun 29, 2026 •

edited

Loading

clawsweeper Bot commented Jul 1, 2026 •

edited

Loading

clawsweeper Bot commented Jul 2, 2026 •

edited

Loading