harden WhatsApp WebSocket URL override#97697
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 29, 2026, 1:47 PM ET / 17:47 UTC. Summary PR surface: Source +15, Tests +19. Total +34 across 2 files. Reproducibility: yes. from source inspection: current main passes the env fallback through as a raw string, while Baileys constructs a Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge the validation follow-up once maintainers accept the current-main-only fail-closed env semantics and leave broader QA Crabline wiring to its separate PR. Do we have a high-confidence way to reproduce the issue? Yes, from source inspection: current main passes the env fallback through as a raw string, while Baileys constructs a Is this the best way to solve the issue? Yes, this is the narrowest maintainable layer for the remaining issue: validate the trusted env fallback in AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 5f60724b6d7b. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +15, Tests +19. Total +34 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
7693d0f to
8a9e23f
Compare
Summary
mainafter feat(whatsapp): support Baileys WebSocket URL override #97155 merged the canonical WhatsApp BaileyswaWebSocketUrloverride.OPENCLAW_WHATSAPP_WEB_SOCKET_URLenv fallback.waWebSocketUrlcall options over environment.Verification
node scripts/run-vitest.mjs run --config test/vitest/vitest.extension-whatsapp.config.ts whatsapp/src/session.test.tspnpm exec oxfmt --check extensions/whatsapp/src/session.ts extensions/whatsapp/src/session.test.tspnpm installafter onepnpm exec oxlintattempt hit dependency materializationENOENT; install reported already up to date.pnpm exec oxlint --deny-warnings --tsconfig config/tsconfig/oxlint.extensions.json extensions/whatsapp/src/session.ts extensions/whatsapp/src/session.test.ts.agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main