chore: link MCP gateway transport QA coverage#97609
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 28, 2026, 10:06 PM ET / 02:06 UTC. Summary PR surface: Tests -20, Other -107. Total -127 across 13 files. Reproducibility: not applicable. this is QA coverage cleanup rather than a bug report. I checked the current-main absence, catalog discovery path, Docker harness mount path, and moved helper call paths instead of reproducing a failing user flow. Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Land the focused QA coverage cleanup after maintainer review and required checks, keeping coverage claims scoped to existing Gateway client tests and shared MCP bridge fixtures. Do we have a high-confidence way to reproduce the issue? Not applicable; this is QA coverage cleanup rather than a bug report. I checked the current-main absence, catalog discovery path, Docker harness mount path, and moved helper call paths instead of reproducing a failing user flow. Is this the best way to solve the issue? Yes; linking existing Gateway coverage through native YAML scenario metadata and consolidating one-use helper coverage is narrower than adding new taxonomy IDs or runtime behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 938855082ade. Label changesLabel justifications:
Evidence reviewedPR surface: Tests -20, Other -107. Total -127 across 13 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
0f9e49c to
69657cf
Compare
69657cf to
2aff6ea
Compare
2aff6ea to
458d009
Compare
What Problem This Solves
The QA scenario inventory did not link existing Gateway/MCP transport evidence for the WebSocket connect request, protocol range, and startup retry behavior used by MCP channel bridge clients.
Why This Change Was Made
Adds a native QA scenario wrapper in
qa/scenarios/runtime/mcp-gateway-connect-startup-retry.yamlwith primary coverage for existing IDs only:gateway.connect-request,gateway.protocol-version-negotiation, andgateway.startup-retry.It also finishes the script-to-QA migration for the MCP channel bridge helpers: the MCP Docker client and shared MCP fixture now live under
test/e2e/qa-lab/runtime, while the shell runner remains inscripts/e2eas Docker orchestration. The standalone MCP connect-timeout and WebSocket-open scripts/tests are deleted.Non-goal: no taxonomy changes, and no primary claim for
anthropic.mcp-tool-bridgebecause these tests do not exercise the Anthropic Claude CLI bridge path.User Impact
Operators get more accurate QA evidence for existing Gateway WebSocket coverage IDs without extra script-owned helper paths. The Docker MCP channel smoke keeps the same shell entrypoint, but its TypeScript assertions now live with the QA Lab E2E fixtures.
Evidence
node scripts/run-vitest.mjs test/e2e/qa-lab/runtime/mcp-gateway-transport.e2e.test.ts test/scripts/cron-mcp-cleanup-docker-client.test.ts test/scripts/test-projects.test.ts extensions/qa-lab/src/scenario-catalog.test.ts --reporter=verbosegit diff --checkpnpm openclaw qa suite --provider-mode mock-openai --scenario mcp-gateway-connect-startup-retry --output-dir .artifacts/qa-e2e/mcp-gateway-connect-startup-retry-qa-fixture-splitGW_URL= GW_TOKEN= node --import tsx test/e2e/qa-lab/runtime/mcp-channels-docker-client.ts(expectedmissing GW_URLafter module imports).agents/skills/autoreview/scripts/autoreview --mode local