test: stabilize startup session migration flake#97370
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 28, 2026, 1:33 AM ET / 05:33 UTC. Summary PR surface: Tests +44. Total +44 across 3 files. Reproducibility: no. deterministic current-main reproduction was run. The linked Actions job failed the compact shard and current source shows the gateway test exercises real plugin discovery, so the flake path is plausible but not a high-confidence repeated repro. Review metrics: none identified. Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the test-only reshuffle after remaining required checks finish, keeping gateway startup tests narrow and plugin-owned session-store discovery covered in infra and registry tests. Do we have a high-confidence way to reproduce the issue? No deterministic current-main reproduction was run. The linked Actions job failed the compact shard and current source shows the gateway test exercises real plugin discovery, so the flake path is plausible but not a high-confidence repeated repro. Is this the best way to solve the issue? Yes. Moving plugin-owned migration behavior coverage into infra and registry tests is a narrower maintainable fix than keeping a gateway wrapper test that loads bundled plugin discovery. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 119dc4bd821e. Label changesLabel justifications:
Evidence reviewedPR surface: Tests +44. Total +44 across 3 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
* test: stabilize startup session migration flake * test: cover voice call doctor session ids
* test: stabilize startup session migration flake * test: cover voice call doctor session ids
* test: stabilize startup session migration flake * test: cover voice call doctor session ids
* test: stabilize startup session migration flake * test: cover voice call doctor session ids
Summary
state-migrations.orphan-keys.test.ts, with explicit plugin agent IDs for migration behavior cases.plugins.load.pathsand verifies its session-store agent IDs.Verification
OPENCLAW_VITEST_MAX_WORKERS=2 node scripts/run-vitest.mjs --config test/vitest/vitest.gateway-server.config.ts src/gateway/server-startup-log.test.ts src/gateway/server-startup-memory.test.ts src/gateway/server-startup-plugins.test.ts src/gateway/server-startup-post-attach.test.ts src/gateway/server-startup-session-migration.test.ts src/gateway/server-startup-web-fetch-bind.test.ts src/gateway/server-startup.test.ts --reporter=verbosenode scripts/run-vitest.mjs --config test/vitest/vitest.infra.config.ts src/infra/state-migrations.orphan-keys.test.ts --reporter=verbosenode scripts/run-vitest.mjs --config test/vitest/vitest.plugins.config.ts src/plugins/doctor-contract-registry.load-paths.test.ts --reporter=verbosenode scripts/run-vitest.mjs extensions/voice-call/doctor-contract-api.test.ts --reporter=verbose -t "reports top-level and per-number session-store agents".agents/skills/autoreview/scripts/autoreview --mode local-> clean, no accepted/actionable findingsgit diff --checkObserved flake: https://github.com/openclaw/openclaw/actions/runs/28275435633/job/83781270309