fix: align talk settings native select rows#97346
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close: the useful work is superseded by #96925, which fixes the same Talk settings selected-label root cause more completely and has live mergeable/proof-positive evidence. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Canonical path: Land #96925 as the canonical source/test fix, then close the duplicate candidate branches and the linked issue after merge. So I’m closing this here and keeping the remaining discussion on #96925. Review detailsBest possible solution: Land #96925 as the canonical source/test fix, then close the duplicate candidate branches and the linked issue after merge. Do we have a high-confidence way to reproduce the issue? Yes. Current main source renders Voice and Sensitivity with an extra selected-label span before the select while Model has only a label and input, matching the reporter screenshot and sibling proof. Is this the best way to solve the issue? No for this PR as the best landing path. The source fix idea is valid, but #96925 removes the same root cause more completely and already has inspected screenshot proof. Security review: Security review cleared: The diff only changes Control UI rendering, CSS, and focused tests; it does not touch dependencies, CI, secrets, permissions, package metadata, or code-execution surfaces. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against 69af58ba2613. |
Summary\n- remove the extra native select value label rendered inside Talk settings rows\n- keep the select itself as the single visible value source so Voice and Sensitivity align with the Model row\n- update the Talk settings test to validate native select values/options instead of the removed duplicate label span\n\n## Testing\n- node scripts/run-vitest.mjs ui/src/ui/views/chat.test.ts\n\nCloses #96915