Skip to content

ci: log macOS Swift build phases#97151

Merged
RomneyDa merged 1 commit into
mainfrom
ci/log-macos-swift-build-phases
Jun 28, 2026
Merged

ci: log macOS Swift build phases#97151
RomneyDa merged 1 commit into
mainfrom
ci/log-macos-swift-build-phases

Conversation

@RomneyDa

Copy link
Copy Markdown
Member

What Problem This Solves

The macOS packaging log currently looks like it repeats the same SwiftPM fetch/build work without saying why. Release packaging actually builds the app and MLX TTS helper for each release architecture, so the repeated Swift output is expected but hard to read.

Why This Change Was Made

This adds explicit log lines before each existing Swift build invocation in scripts/package-mac-app.sh, naming the product, configuration, and architecture being built. It does not change the build commands or packaging behavior.

User Impact

Maintainers inspecting macOS release runs can distinguish the app/helper and arm64/x86_64 phases without digging into the script.

Evidence

  • bash -n scripts/package-mac-app.sh
  • git diff --check

@openclaw-barnacle openclaw-barnacle Bot added scripts Repository scripts size: XS maintainer Maintainer-authored PR labels Jun 27, 2026
@clawsweeper

clawsweeper Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed June 26, 2026, 10:18 PM ET / 02:18 UTC.

Summary
The PR adds log lines before each Swift build phase in scripts/package-mac-app.sh, naming the product, build configuration, and architecture.

PR surface: Other +2. Total +2 across 1 file.

Reproducibility: not applicable. This PR is an observability cleanup, not a bug report. Source inspection of current main confirms the repeated Swift app/helper builds that the new log lines describe.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🌊 off-meta tidepool
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • Protected maintainer-labeled PR should stay in the normal maintainer review lane; no narrow automated repair is needed.

Security
Cleared: The diff only adds shell echo log lines before existing Swift build commands and does not change dependency sources, permissions, secrets, packaging outputs, or command execution behavior.

Review details

Best possible solution:

If maintainers want clearer macOS release logs, land this narrow logging change after normal required checks complete; no broader packaging redesign is needed.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this PR is an observability cleanup, not a bug report. Source inspection of current main confirms the repeated Swift app/helper builds that the new log lines describe.

Is this the best way to solve the issue?

Yes. Logging immediately before the two existing swift build commands is the narrowest maintainable way to distinguish product and architecture phases without changing packaging behavior.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 552ec2b49d4a.

Label changes

Label justifications:

  • P3: This is low-risk release-script observability cleanup, not a user-facing runtime regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The external-contributor proof gate does not apply because this PR is authored by a repository member and only changes release-script logging.
Evidence reviewed

PR surface:

Other +2. Total +2 across 1 file.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 0 0 0 0
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 1 2 0 +2
Total 1 2 0 +2

What I checked:

Likely related people:

  • cgdusek: Authored merged universal-binary packaging work that changed scripts/package-mac-app.sh and the architecture behavior this PR logs. (role: feature-history contributor; confidence: medium; commits: 8c798d40b7b7, 833d5173bb69, 1c15b88682a4; files: scripts/package-mac-app.sh, docs/platforms/mac/release.md)
  • osolmaz: Authored merged macOS release automation work that touched scripts/package-mac-app.sh and the release workflow context for this script. (role: release automation contributor; confidence: medium; commits: 36372687a6a1, 889f3426a864, cc571684e9df; files: scripts/package-mac-app.sh, .github/workflows/macos-release.yml, docs/reference/RELEASING.md)
  • ImLukeF: Authored the merged MLX Talk provider work adjacent to the helper product named by the added build log. (role: adjacent MLX Talk contributor; confidence: low; commits: d4360c3e7480, ff4f984f052d, 7bb4012db56a; files: apps/macos/Package.swift, apps/macos/Sources/OpenClaw/TalkMLXSpeechSynthesizer.swift, apps/macos/Sources/OpenClaw/TalkModeRuntime.swift)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels Jun 27, 2026
@RomneyDa
RomneyDa merged commit 69af58b into main Jun 28, 2026
166 of 172 checks passed
@RomneyDa
RomneyDa deleted the ci/log-macos-swift-build-phases branch June 28, 2026 05:06
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jun 28, 2026
QiuYuang pushed a commit to QiuYuang/openclaw that referenced this pull request Jul 1, 2026
chenyangjun-xy pushed a commit to chenyangjun-xy/openclaw that referenced this pull request Jul 1, 2026
chenyangjun-xy pushed a commit to chenyangjun-xy/openclaw that referenced this pull request Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. scripts Repository scripts size: XS status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant