ci: log macOS Swift build phases#97151
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 26, 2026, 10:18 PM ET / 02:18 UTC. Summary PR surface: Other +2. Total +2 across 1 file. Reproducibility: not applicable. This PR is an observability cleanup, not a bug report. Source inspection of current main confirms the repeated Swift app/helper builds that the new log lines describe. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: If maintainers want clearer macOS release logs, land this narrow logging change after normal required checks complete; no broader packaging redesign is needed. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR is an observability cleanup, not a bug report. Source inspection of current main confirms the repeated Swift app/helper builds that the new log lines describe. Is this the best way to solve the issue? Yes. Logging immediately before the two existing AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 552ec2b49d4a. Label changesLabel justifications:
Evidence reviewedPR surface: Other +2. Total +2 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
What Problem This Solves
The macOS packaging log currently looks like it repeats the same SwiftPM fetch/build work without saying why. Release packaging actually builds the app and MLX TTS helper for each release architecture, so the repeated Swift output is expected but hard to read.
Why This Change Was Made
This adds explicit log lines before each existing Swift build invocation in
scripts/package-mac-app.sh, naming the product, configuration, and architecture being built. It does not change the build commands or packaging behavior.User Impact
Maintainers inspecting macOS release runs can distinguish the app/helper and arm64/x86_64 phases without digging into the script.
Evidence
bash -n scripts/package-mac-app.shgit diff --check