fix(telegram): retain socket failure context#97130
Merged
Merged
Conversation
Co-authored-by: zhang-guiping <[email protected]>
openclaw-barnacle
Bot
added
channel: telegram
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(telegram): retain socket failure context This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Contributor
Author
|
Land-ready maintainer review complete. Fixups:
Proof:
Before/after: the probe fallback warning changed from a false DNS assertion with Known proof gaps: none. |
Contributor
Author
|
Merged via squash.
|
This was referenced Jun 27, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jun 27, 2026
Co-authored-by: zhang-guiping <[email protected]>
This was referenced Jun 27, 2026
xydigit-zt
pushed a commit
to xydigit-zt/xydigit-zt-openclaw
that referenced
this pull request
Jun 28, 2026
Co-authored-by: zhang-guiping <[email protected]>
QiuYuang
pushed a commit
to QiuYuang/openclaw
that referenced
this pull request
Jul 1, 2026
Co-authored-by: zhang-guiping <[email protected]>
chenyangjun-xy
pushed a commit
to chenyangjun-xy/openclaw
that referenced
this pull request
Jul 1, 2026
Co-authored-by: zhang-guiping <[email protected]>
chenyangjun-xy
pushed a commit
to chenyangjun-xy/openclaw
that referenced
this pull request
Jul 3, 2026
Co-authored-by: zhang-guiping <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Fixes #94620. Supersedes #96830 while preserving @zhangguiping-xydt's contribution credit.
When a Telegram startup probe fails and explicitly promotes the transport fallback, the transport currently discards the original error. That produces
codes=noneand can pair a local socket failure with the inaccurate claim that a DNS-resolved IP was unreachable.Why This Change Was Made
forceFallbackso the existing transport diagnostic reports its structured socket code.EADDRNOTAVAILfetch failure is not automatically retried, while a probe can still promote the alternate IPv4 or pinned-IP path.The original proposal disabled probe fallback for
EADDRNOTAVAIL. Maintainer review found that too broad: Linux ephemeral-port allocation is destination-sensitive, so a different remote Telegram IP can still provide a usable socket tuple. Keeping recovery while preserving the real error is the bounded owner-local fix.User Impact
Telegram startup fallback logs now retain
EADDRNOTAVAILand avoid misleading DNS wording. Existing alternate-IP recovery remains available, including when a different destination tuple can recover from local port pressure.Evidence
node scripts/run-vitest.mjs extensions/telegram/src/fetch.test.ts extensions/telegram/src/probe.test.tsmain.node_modules/.bin/oxfmt --check extensions/telegram/src/fetch.ts extensions/telegram/src/probe.ts extensions/telegram/src/fetch.test.ts extensions/telegram/src/probe.test.tsnode_modules/.bin/oxlint --deny-warnings extensions/telegram/src/fetch.ts extensions/telegram/src/probe.ts extensions/telegram/src/fetch.test.ts extensions/telegram/src/probe.test.tsgit diff --checkEADDRNOTAVAIL(errno=-49); direct fallback was false; two explicit promotions returned true and retainedcodes=EADDRNOTAVAIL.tbx_01kw38m62y2gccvpbgy5kafgx8EADDRNOTAVAIL(errno=-99) with the same fallback decisions.pnpm check:changedfor the extension and extension-test lanes.