docs: clarify macOS release workflow refs#97116
Merged
Merged
Conversation
Contributor
|
Codex review: needs changes before merge. Reviewed June 26, 2026, 7:07 PM ET / 23:07 UTC. Summary PR surface: Docs +41. Total +41 across 1 file. Reproducibility: yes. for the review finding: source inspection of the PR head shows the mac skill changed to Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Copy recommended automerge instructionNext step before merge
Security Review findings
Review detailsBest possible solution: Merge after Do we have a high-confidence way to reproduce the issue? Yes for the review finding: source inspection of the PR head shows the mac skill changed to Is this the best way to solve the issue? No, not yet; updating the mac skill is the right layer, but the maintainable fix needs the sibling release-maintainer runbook aligned in the same PR. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a82902c725b2. Label changesLabel justifications:
Evidence reviewedPR surface: Docs +41. Total +41 across 1 file. View PR surface stats
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
clawsweeper
Bot
added
proof: sufficient
Member
Author
|
@clawsweeper re-review |
Contributor
|
🦞🧹 Reason: re-review requires an open issue or PR. |
wangmiao0668000666
pushed a commit
to wangmiao0668000666/openclaw
that referenced
this pull request
Jun 27, 2026
* docs: clarify macOS release workflow refs * docs: clarify macOS release repo roles * docs: document macOS release approval gate * docs: align maintainer macOS release repo refs
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jun 27, 2026
* docs: clarify macOS release workflow refs * docs: clarify macOS release repo roles * docs: document macOS release approval gate * docs: align maintainer macOS release repo refs
xydigit-zt
pushed a commit
to xydigit-zt/xydigit-zt-openclaw
that referenced
this pull request
Jun 28, 2026
* docs: clarify macOS release workflow refs * docs: clarify macOS release repo roles * docs: document macOS release approval gate * docs: align maintainer macOS release repo refs
QiuYuang
pushed a commit
to QiuYuang/openclaw
that referenced
this pull request
Jul 1, 2026
* docs: clarify macOS release workflow refs * docs: clarify macOS release repo roles * docs: document macOS release approval gate * docs: align maintainer macOS release repo refs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The macOS release skill made it easy to confuse the workflow ref shown in GitHub Actions with the source ref that the workflow checks out. It also did not make the two repos explicit enough:
openclaw/openclawowns the product release page, whileopenclaw/releasesowns the restricted macOS signing/notarization/publish workflows.Why This Change Was Made
This updates
.agents/skills/release-openclaw-mac/SKILL.mdwith the exact public handoff command and explains the split between public OpenClaw validation and the release-ops publisher. The public validation should run fromrelease/YYYY.M.PATCHso Actions displays the release branch, while the release-opsopenclaw/releasespublisher runs from its own trustedmainworkflow ref and selects public source throughtag/source_refinputs.User Impact
Future macOS release recovery work has a copy-paste command that matches prior successful stable macOS handoff runs and a clear warning not to use
--ref mainor--ref vYYYY.M.PATCHfor the public validation workflow. It also states that public handoff validation never uploads macOS assets, regardless ofpreflight_only, and that release-ops preflight/publish may pause at the protectedmac-releaseenvironment for Vincent or another reviewer to approve.Evidence
git diff --checkmacos-release.ymldispatch from--ref release/2026.6.10created successful run28269425203withheadBranch=release/2026.6.10andheadSha=aa69b12d0086b631b139c1435c9621a5783e3a40.OpenClaw macOS Publishhas a real-publish guard requiring workflow refrefs/heads/main.OpenClaw macOS Publishuses protected environmentmac-releasein thebuild_sign_and_packagejob.