[codex] fix Feishu login QR rendering#97087
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 26, 2026, 3:03 PM ET / 19:03 UTC. Summary PR surface: Source 0, Tests +18. Total +18 across 2 files. Reproducibility: yes. from source inspection: current main routes Feishu scan setup through Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Land this focused Feishu QR print-path fix after normal maintainer and CI gates; keep the broader Feishu startup-timeout work tracked separately. Do we have a high-confidence way to reproduce the issue? Yes, from source inspection: current main routes Feishu scan setup through Is this the best way to solve the issue? Yes. The PR uses the existing OpenClaw compact QR renderer on the narrow Feishu print path, avoids the old upstream AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against e5123e44b0f5. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source 0, Tests +18. Total +18 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Co-authored-by: NianJiuZst <180004567+users.noreply.github.com>
Co-authored-by: NianJiuZst <180004567+users.noreply.github.com>
Co-authored-by: NianJiuZst <180004567+users.noreply.github.com>
Co-authored-by: NianJiuZst <180004567+users.noreply.github.com>
What Problem This Solves
openclaw channels login --channel feishucan render an oversized and distorted terminal QR code during the scan-to-create setup path. The Feishu registration URL is long enough that the default full terminal QR renderer becomes roughly twice as wide as the compact renderer, which can wrap in normal terminal windows and make the QR code unscannable.Why This Change Was Made
Feishu's app-registration QR print path was calling
renderQrTerminal(url)without compact mode. The shared media runtime already supports compact half-block QR rendering, and WhatsApp login already uses that mode for terminal QR display. This change routes Feishu scan-to-create QR output through the same compact renderer by passing{ small: true }.The regression test locks the Feishu print path to compact rendering and keeps the stdout newline behavior intact.
User Impact
Users who choose QR scanning in
openclaw channels login --channel feishushould now see a QR code that fits normal terminal widths and remains scannable instead of a huge wrapped block.Evidence
Automated checks:
pnpm test extensions/feishu/src/app-registration.test.ts -- --reporter=verbosepnpm test src/media/qr-terminal.render.test.ts -- --reporter=verbosepnpm exec oxfmt --check --threads=1 extensions/feishu/src/app-registration.ts extensions/feishu/src/app-registration.test.tspnpm changed:lanes --jsonpnpm test:changedgit diff --check.agents/skills/autoreview/scripts/autoreview --mode localreported no accepted/actionable findings.Manual terminal behavior proof:
Before: simulated Feishu registration URL length
402rendered with defaultqrcodeterminal mode as75rows and max150visible columns.After: the same URL rendered through Feishu
printQrCodeas38rows and max75visible columns, using compact half-block QR output.Real behavior screenshots: