fix(opencode-go): treat block-boundary SSE events as liveness for idle timer#96991
Closed
lsr911 wants to merge 1 commit into
Closed
fix(opencode-go): treat block-boundary SSE events as liveness for idle timer#96991lsr911 wants to merge 1 commit into
lsr911 wants to merge 1 commit into
Conversation
lsr911
force-pushed
the
fix/issue-96518-Bug-opencode-go-stalled-str
branch
from
June 26, 2026 08:47
1a9b028 to
ef75efe
Compare
lsr911
force-pushed
the
fix/issue-96518-Bug-opencode-go-stalled-str
branch
from
June 26, 2026 08:48
ef75efe to
83bcef1
Compare
lsr911
force-pushed
the
fix/issue-96518-Bug-opencode-go-stalled-str
branch
from
June 26, 2026 08:49
83bcef1 to
7191d18
Compare
…e timer Adds text_end, thinking_end, toolcall_start, toolcall_end to the isProviderProgressEvent liveness predicate. These SSE boundary events are sent between content blocks and must reset the idle timer to prevent premature timeouts on slow-but-live connections. Includes regression test verifying all 4 event types prevent abort when emitted within the idle window.
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(opencode-go): treat block-boundary SSE events as liveness for idle timer This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
lsr911
force-pushed
the
fix/issue-96518-Bug-opencode-go-stalled-str
branch
from
June 26, 2026 08:49
7191d18 to
83710dd
Compare
Contributor
Author
|
Closing: replaced by clean branch. See new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
OpenCode Go sends block-boundary SSE events between content blocks. The stalled-stream liveness wrapper only recognized text_delta/thinking_delta/toolcall_delta as progress, causing premature timeouts. Adding text_end, thinking_end, toolcall_start, toolcall_end treats them as liveness.
Evidence
Vitest (includes new regression test for all 4 event types):
Label: bug
AI-assisted.