fix(ui): remove redundant selected-label span to align Talk settings fields#96923
fix(ui): remove redundant selected-label span to align Talk settings fields#96923krissding wants to merge 2 commits into
Conversation
… to fix alignment with Model input The renderNativeTalkSelect function added an extra agent-chat__talk-select-label span between the field label and the <select> element. In the .agent-chat__talk-field flex-direction:column layout, this extra child pushed the select element one row lower than the adjacent Model <input>, which only has the label span + input. Since the native <select> element already displays the selected option, the extra label span was redundant. Removing it restores vertical alignment of Voice, Model, and Sensitivity fields in the Talk settings popover. Closes openclaw#96915 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
Thanks for the context here. I did a careful shell check against current Close: current main already contains the Talk settings source/test fix from the merged sibling PR, and the live branch now has zero changed files against main. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. So I’m closing this as already implemented rather than keeping a duplicate issue open. Review detailsBest possible solution: Keep the merged current-main source/test fix from #96925 and close duplicate no-op branches rather than merging another PR. Do we have a high-confidence way to reproduce the issue? No for current main: source inspection shows the selected-label render path is gone from the Talk settings helper. The latest release tag still contains the old path, so the bug was real but is now fixed only on main. Is this the best way to solve the issue? Yes: the current-main fix removes the redundant DOM child from the shared native select renderer and updates focused tests, which is cleaner than CSS-offsetting the mismatch. Security review: Security review cleared: Security review cleared: the live PR diff is empty, and the original proposed UI/test-only change did not touch dependencies, secrets, permissions, CI, package metadata, or code-execution surfaces. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against a202dd0faf56; fix evidence: commit 4a4657a1828f, main fix timestamp 2026-06-28T18:40:45-07:00. |
clawsweeper
Bot
added
rating: 🧂 unranked krab
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
|
ClawSweeper applied the proposed close for this PR.
|
1 participant
What Problem This Solves
Fixes #96915: Voice and Sensitivity select fields were misaligned with the Model input field in the Talk settings popover due to an extra
agent-chat__talk-select-labelspan that added a vertical row above each<select>element.Why This Change Was Made
Root cause:
renderNativeTalkSelect()rendered an extra<span class="agent-chat__talk-select-label">between the field label and the<select>. The.agent-chat__talk-fieldusesflex-direction: columnwithgap: 6px, so this extra child pushed the select one row lower than the adjacent Model<input>, which only has the label span + input (2 children vs 3 children).Since the native
<select>element already displays the currently selected option value, the extra label span was redundant.Real behavior proof
Before fix:
After fix:
All three fields now have 2 children each → vertically aligned.
Evidence
pnpm buildpassespnpm checkpassesMerge Risk
<select>element natively displays the selected valueAI-assisted: built with Claude Code