Stabilize Google Meet chrome-node launch configuration#96908
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 25, 2026, 10:48 PM ET / 02:48 UTC. Summary PR surface: Source +200, Tests +184. Total +384 across 7 files. Reproducibility: yes. at source level. Current main appends the macOS Chrome URL after Review metrics: 2 noteworthy metrics.
Stored data model Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this maintainer-labeled PR after owner review accepts the compatibility/security-boundary change and relevant CI is green, then close or supersede the older overlapping policy PR so only one Google Meet chrome-node policy path remains. Do we have a high-confidence way to reproduce the issue? Yes, at source level. Current main appends the macOS Chrome URL after Is this the best way to solve the issue? Yes, this appears to be the best fix shape: Google Meet owns the command policy, the gateway already has the pre-dispatch policy hook, and the macOS argument fix lives at the node-host launch point. The remaining question is maintainer acceptance of the intentional compatibility/security-boundary change. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 6830aa39eaa1. Label changesLabel justifications:
Evidence reviewedPR surface: Source +200, Tests +184. Total +384 across 7 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@openclaw-mantis visual task: verify a Gateway Google Meet chrome-node join uses configured Chrome profile and audio helper commands on a paired macOS node. |
What Problem This Solves
Google Meet's Chrome and chrome-node paths need to use the same configured launch, audio, and profile settings consistently across setup checks, local Chrome control, and paired node hosts.
Why This Change Was Made
This change keeps Google Meet chrome-node launch parameters derived from the plugin's configured runtime settings, while preserving the existing profile ownership split:
browser.defaultProfile.chrome.browserProfileremains the chrome-node host profile setting.User Impact
No new config surface is added.
Existing local Chrome users should continue using
browser.defaultProfilefor profile selection. Existing chrome-node users can continue usingchrome.browserProfileand configured audio commands. The Google Meet transcribe and agent talk-back paths continue to work with the existing Chrome/BlackHole/SoX setup.Evidence
node scripts/run-vitest.mjs extensions/google-meet/src/node-invoke-policy.test.ts extensions/google-meet/index.test.ts extensions/google-meet/node-host.test.ts src/gateway/node-invoke-plugin-policy.test.tspnpm tsgo:extensions && pnpm tsgo:test:extensionspnpm buildgooglemeet setup --jsonwith SoX availablegooglemeet test-speechin Chrome agent mode with speech output confirmed