fix(llm): preserve structured tool results as text across providers#96895
fix(llm): preserve structured tool results as text across providers#96895arkyu2077 wants to merge 1 commit into
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 25, 2026, 10:19 PM ET / 02:19 UTC. Summary PR surface: Source +53, Tests +91. Total +144 across 7 files. Reproducibility: yes. from source: current provider and transport converters filter only text blocks and fall back to Review metrics: 2 noteworthy metrics.
Stored data model Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Make one type-safe extractor cover every active tool-result replay path, including Do we have a high-confidence way to reproduce the issue? Yes from source: current provider and transport converters filter only text blocks and fall back to Is this the best way to solve the issue? No. The helper direction is plausible, but this PR is not the best complete fix until it is type-safe, covers the active Responses transport path, and includes real behavior proof. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 6830aa39eaa1. Label changesLabel justifications:
Evidence reviewedPR surface: Source +53, Tests +91. Total +144 across 7 files. View PR surface stats
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
I think this PR is now superseded by #97742 / current I rechecked the current That means the best fix path appears to be the already-merged #97742, not reviving #96895. If maintainers want to keep #96857 open for the remaining "text-only after long session/truncation" reports, that should be tracked separately from this structured-provider converter PR. |
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
Summary
(see attached image)session_status-style tool results in all three provider pathsTesting
Closes #96857