fix: add windowsHide to all spawn calls to prevent visible console windows on Windows#96839
fix: add windowsHide to all spawn calls to prevent visible console windows on Windows#96839shihao-lao wants to merge 2 commits into
Conversation
…ndows on Windows Fixes openclaw#96835 Multiple spawn() calls across the codebase were missing the windowsHide: true option, causing visible cmd/PowerShell console windows to flash on every command execution on Windows. This was a regression from previous behavior. Files fixed: - src/agents/sessions/exec.ts - src/agents/sessions/tools/find.ts - src/agents/sessions/tools/grep.ts - src/agents/tool-search.ts - src/agents/provider-local-service.ts - src/agents/sandbox/ssh.ts (3 spawn calls) - src/auto-reply/reply/stage-sandbox-media.ts - src/daemon/launchd-restart-handoff.ts - src/process/respawn-child-runner.ts
|
Codex review: needs real behavior proof before merge. Reviewed July 1, 2026, 11:07 PM ET / 03:07 UTC. Summary PR surface: Source +7. Total +7 across 8 files. Reproducibility: no. high-confidence live reproduction was performed. Source inspection shows current main still has direct production spawn sites without Review metrics: none identified. Stored data model Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Merge the remaining Do we have a high-confidence way to reproduce the issue? No high-confidence live reproduction was performed. Source inspection shows current main still has direct production spawn sites without Is this the best way to solve the issue? Yes for the remaining direct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 4a2a97777e35. Label changesLabel justifications:
Evidence reviewedPR surface: Source +7. Total +7 across 8 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
Summary
Fixes #96835
After upgrading from v2026.6.8 to v2026.6.10, every exec call creates a visible cmd/PowerShell console window on Windows. While src/process/supervisor/adapters/child.ts already has windowsHide: true, 9 other spawn() call sites across the codebase were missing this option.
Changes
Added windowsHide: true to all spawn() calls that were missing it:
Testing