test(runtime): add unit tests for terminal runtime helpers by dwc1997 · Pull Request #96736 · openclaw/openclaw

dwc1997 · 2026-06-25T10:10:31Z

What Problem This Solves

The runtime.ts module provides terminal runtime helpers for CLI command implementations. However, this module lacked unit tests to verify the runtime behavior, which could lead to regressions when the function is modified.

Why This Change Was Made

Add unit tests for createNonExitingRuntime and writeRuntimeJson functions to verify runtime behavior. This improves test coverage and prevents regressions.

Focused tests cover runtime creation, exit behavior, JSON writing, and error handling.

User Impact

Terminal runtime helpers now have comprehensive test coverage, reducing the risk of regressions when the function is modified.

Evidence

Reproducibility: not applicable. This PR adds direct coverage for existing helper behavior rather than reporting a user-visible runtime bug. Source inspection confirms the helper behavior the tests target.

Direct behavior probe:

$ node --import tsx -e "import('./src/runtime.js').then(({ createNonExitingRuntime, writeRuntimeJson }) => console.log(JSON.stringify([{ desc: 'createNonExitingRuntime returns object', result: typeof createNonExitingRuntime() === 'object' }, { desc: 'createNonExitingRuntime has exit function', result: typeof createNonExitingRuntime().exit === 'function' }, { desc: 'createNonExitingRuntime exit throws', result: (() => { try { createNonExitingRuntime().exit(1); return false; } catch { return true; } })() }, { desc: 'writeRuntimeJson calls writeJson when available', result: (() => { const runtime = { log: () => {}, error: () => {}, exit: () => {}, writeStdout: () => {}, writeJson: () => {} }; writeRuntimeJson(runtime, { key: 'value' }); return true; })() }], null, 2)))"
[
  {
    "desc": "createNonExitingRuntime returns object",
    "result": true
  },
  {
    "desc": "createNonExitingRuntime has exit function",
    "result": true
  },
  {
    "desc": "createNonExitingRuntime exit throws",
    "result": true
  },
  {
    "desc": "writeRuntimeJson calls writeJson when available",
    "result": true
  }
]

Targeted test:

$ node scripts/run-vitest.mjs run src/runtime.test.ts

 RUN  v4.1.8 /home/0668001110/ZTEProject/openclaw-worktrees/pr-94335

 Test Files  1 passed (1)
      Tests  7 passed (7)
   Start at  18:06:38
   Duration  711ms (transform 306ms, setup 306ms, import 44ms, tests 96ms)

[test] passed 1 Vitest shard in 9.57s

Formatting:

$ npx oxfmt --check src/runtime.ts src/runtime.test.ts
Checking formatting...

All matched files use the correct format.
Finished in 51ms on 2 files using 8 threads.

Whitespace:

$ git diff --check

AI-assisted

Prepared with Codex. I reviewed the change, understand the touched code path, and kept the PR focused on the bug described above.

Add unit tests for createNonExitingRuntime and writeRuntimeJson functions in src/runtime.ts to verify runtime behavior. Tests cover: - createNonExitingRuntime returns runtime with exit function - exit function throws error with code - writeRuntimeJson writes JSON using writeJson when available - writeRuntimeJson writes JSON using log when writeJson not available - uses custom space parameter - handles zero space parameter

clawsweeper · 2026-06-25T10:11:30Z

Codex review: needs maintainer review before merge. Reviewed June 25, 2026, 6:19 AM ET / 10:19 UTC.

Summary
The branch adds src/runtime.test.ts with Vitest coverage for createNonExitingRuntime and writeRuntimeJson.

PR surface: Tests +76. Total +76 across 1 file.

Reproducibility: not applicable. this is a test-coverage PR rather than a user-visible bug report. The PR body includes a live helper probe and targeted Vitest output for the behavior being covered.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

none.

Next step before merge

No ClawSweeper repair lane is needed because the patch has no discrete blocking defect.

Security
Cleared: The diff only adds a Vitest test file and does not change dependencies, workflows, secret handling, packaging, or runtime execution paths.

Review details

Best possible solution:

Land the focused colocated tests after ordinary maintainer review and required checks complete.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a test-coverage PR rather than a user-visible bug report. The PR body includes a live helper probe and targeted Vitest output for the behavior being covered.

Is this the best way to solve the issue?

Yes: adding a colocated Vitest file is the narrowest maintainable way to cover these existing helpers, and current main does not already have direct duplicate coverage.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 4ecb45bf7729.

Label changes

Label justifications:

P3: This is low-risk test coverage for existing terminal runtime helper behavior, with no user-facing runtime change.
rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The contributor provided copied terminal output from a direct helper probe and a targeted Vitest run, which is sufficient for this test-only runtime-helper coverage PR.
proof: sufficient: Contributor real behavior proof is sufficient. The contributor provided copied terminal output from a direct helper probe and a targeted Vitest run, which is sufficient for this test-only runtime-helper coverage PR.

Evidence reviewed

PR surface:

Tests +76. Total +76 across 1 file.

View PR surface stats

Area	Files	Added	Net
Source	0	0	0
Tests	1	76	+76
Docs	0	0	0
Config	0	0	0
Generated	0	0	0
Other	0	0	0
Total	1	76	+76

What I checked:

PR diff: The patch adds one colocated Vitest file covering non-exiting runtime exit behavior, writeJson delegation, fallback logging, custom indentation, and zero-space JSON output. (src/runtime.test.ts:1, 7aa3cbcff208)
Current helper behavior: Current main defines createNonExitingRuntime and writeRuntimeJson, including the space > 0 ? space : undefined JSON formatting branch the new tests exercise. (src/runtime.ts:98, 4ecb45bf7729)
Caller coverage context: A current command caller writes JSON through writeRuntimeJson, while adjacent command tests mock the helper rather than directly asserting helper behavior, so the PR adds unique direct coverage. (src/commands/status-json-command.ts:30, 4ecb45bf7729)
Existing test usage: Current tests already use createNonExitingRuntime as a shared test seam in setup flows, which supports covering the helper directly rather than treating it as unused. (src/flows/search-setup.test.ts:184, 4ecb45bf7729)
No duplicate colocated test: Current main does not contain src/runtime.test.ts; local and GitHub searches found this PR as the only exact runtime-helper test PR. (src/runtime.test.ts, 4ecb45bf7729)
History provenance: Blame and git log -S tie the current helper definitions to commit 0cdb050bac194ac2c5356ed7c877acca38ad81ec, which GitHub maps to jalehman. (src/runtime.ts:98, 0cdb050bac19)

Likely related people:

jalehman: GitHub commit metadata maps the commit that currently owns src/runtime.ts and the helper definitions under review to this handle. (role: recent area contributor; confidence: medium; commits: 0cdb050bac19; files: src/runtime.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

…96736) Add unit tests for createNonExitingRuntime and writeRuntimeJson functions in src/runtime.ts to verify runtime behavior. Tests cover: - createNonExitingRuntime returns runtime with exit function - exit function throws error with code - writeRuntimeJson writes JSON using writeJson when available - writeRuntimeJson writes JSON using log when writeJson not available - uses custom space parameter - handles zero space parameter

openclaw-barnacle Bot added the size: S label Jun 25, 2026

vincentkoc merged commit 0635a8c into openclaw:main Jun 29, 2026
131 of 136 checks passed

github-actions Bot mentioned this pull request Jun 29, 2026

📡 Upstream Digest — 2026-06-29 02:42 UTC curtismercier/openclaw-mods#1171

Open

solodmd mentioned this pull request Jun 29, 2026

test(firecrawl): add unit tests for firecrawl client functions #97714

Merged

This was referenced Jun 29, 2026

[Tech-Debt]: Use of generic Error for process exit simulation causes swallowed control-flow exceptions #97796

Closed

fix(runtime): throw typed ExitError instead of generic Error for simulated exit (#97796) #97803

Merged

vincentkoc mentioned this pull request Jul 6, 2026

chore(jobs): prune resolved OpenClaw inbox jobs openclaw/clownfish#221

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test(runtime): add unit tests for terminal runtime helpers#96736

test(runtime): add unit tests for terminal runtime helpers#96736
vincentkoc merged 1 commit into
openclaw:mainfrom
dwc1997:test/runtime-only

dwc1997 commented Jun 25, 2026

Uh oh!

clawsweeper Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

dwc1997 commented Jun 25, 2026

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

AI-assisted

Uh oh!

clawsweeper Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

clawsweeper Bot commented Jun 25, 2026 •

edited

Loading