perf(plugins): reuse installed manifest realpaths#96710
Merged
Conversation
vincentkoc
marked this pull request as ready for review
June 25, 2026 08:32
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: perf(plugins): reuse installed manifest realpaths This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Member
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jun 26, 2026
Co-authored-by: sheyanmin <[email protected]>
QiuYuang
pushed a commit
to QiuYuang/openclaw
that referenced
this pull request
Jul 1, 2026
Co-authored-by: sheyanmin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
resolveInstalledManifestRegistryIndexFingerprint()rebuilds package realpaths while fingerprinting mutable installed plugin indexes. Original PR #94347 caught the hot-path waste, but its branch is stale/conflicting and includes unrelated budget edits.Fixes #90362.
Why This Change Was Made
This keeps the realpath memo at the installed manifest registry lifecycle boundary, alongside the existing installed package path and metadata process caches. The cache is bounded and cleared through the existing plugin metadata lifecycle clear hook.
Original optimization credited to @sheyanmin in #94347.
User Impact
Installed plugin registry fingerprinting avoids repeated realpath filesystem work across repeated mutable index builds. No user-visible behavior, config, migration, or environment contract changes.
Evidence
git diff --checknode_modules/.bin/oxfmt --check src/plugins/manifest-registry-installed.ts src/plugins/manifest-registry-installed.test.tsnode scripts/run-vitest.mjs src/plugins/manifest-registry-installed.test.ts(17 tests).agents/skills/autoreview/scripts/autoreview --mode branch --base origin/maincheck:changed, providerblacksmith-testbox, idtbx_01kvyyhpd06bd4hq7trpkcn9fn, Actions run https://github.com/openclaw/openclaw/actions/runs/28157447437run_fc3938c56111, leasecbx_9807702a477b, focused plugin test andcheck:changedpassed