fix(cron): preserve enabled-with-defaults failure alert through store roundtrip (fixes #96589) (AI-assisted) by clawsweeper[bot] · Pull Request #96615 · openclaw/openclaw

clawsweeper · 2026-06-25T01:08:18Z

Makes #96601 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
Known failing checks:

Failing check: checks-node-compact-small-whole-2:FAILURE (https://github.com/openclaw/openclaw/actions/runs/28137899679/job/83328677905)

Source

Replacement for #96601 because the source branch could not be updated.

Original contributor: @liuhao1024.

… roundtrip (fixes #96589) (AI-assisted) Co-authored-by: liuhao1024 <[email protected]>

clawsweeper · 2026-06-25T01:09:16Z

Codex review: passed. Reviewed June 24, 2026, 9:14 PM ET / 01:14 UTC.

Summary
The PR preserves failure_alert_disabled === 0 as the enabled-with-defaults failure-alert state and adds focused codec roundtrip tests.

PR surface: Source +2, Tests +54. Total +56 across 2 files.

Reproducibility: yes. At source level, current main encodes failureAlert: {} with failure_alert_disabled = 0, then decodes it as undefined when all explicit alert option columns are null.

Review metrics: none identified.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #96589
Summary: This PR is the replacement candidate fix for the defaults-only cron failure-alert reload bug tracked by the canonical issue.

Members:

canonical: cron: failure alerts enabled with defaults (--failure-alert) silently stop firing after gateway restart #96589 - The issue reports the same defaults-only failureAlert: {} SQLite roundtrip loss and is linked as the bug this PR fixes.
superseded: fix(cron): preserve enabled-with-defaults failure alert through store roundtrip (fixes #96589) (AI-assisted) #96601 - The current PR body says it replaces the closed source PR because that branch could not be updated.
partial_overlap: failureAlert (after=1) never fires on 2026.6.5 — every errored run stuck at delivery_status 'not-requested' #92058 - This also reports missed failure alerts, but it involves populated failureAlert.after = 1 and delivery-status persistence rather than defaults-only store decoding.
partial_overlap: fix(cron): persist failure alert delivery status #95129 - This open PR is the candidate fix for the adjacent delivery-status persistence issue, not the defaults-only sentinel loss fixed here.
partial_overlap: [Bug]: failureAlert silently drops when cron stalls in runtime-plugins phase — lastFailureNotificationDeliveryStatus="unknown", operator never sees the failure #89847 - This also concerns missed failure alerts, but its reported root is runtime-plugins stall behavior and unknown delivery state rather than defaults-only store decoding.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

none.

Risk before merge

[P1] No full gateway restart proof was run for this replacement PR; confidence comes from the exact SQLite codec/reload source path, focused tests, and copied after-fix terminal proof from the source PR.

Maintainer options:

Decide the mitigation before merge
Land the narrow codec/test fix through the automerge and CI gates, then close cron: failure alerts enabled with defaults (--failure-alert) silently stop firing after gateway restart #96589 as fixed.
Pause or close
Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

[P2] No repair lane is needed; the PR already implements the narrow fix and should be handled by exact-head review, CI, and automerge gates.

Security
Cleared: The diff only changes cron TypeScript codec logic and adds a Vitest test file; no security or supply-chain concern was found.

Review details

Best possible solution:

Land the narrow codec/test fix through the automerge and CI gates, then close #96589 as fixed.

Do we have a high-confidence way to reproduce the issue?

Yes. At source level, current main encodes failureAlert: {} with failure_alert_disabled = 0, then decodes it as undefined when all explicit alert option columns are null.

Is this the best way to solve the issue?

Yes. The writer already uses failure_alert_disabled === 0 as the enabled sentinel, so preserving that sentinel in the decoder is the narrowest maintainable fix without adding runtime fallback logic or config surface.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 8a5cb85c31e5.

Label changes

Label changes:

add P1: The PR fixes a user-enabled cron alert path that can silently stop notifying after gateway restart, breaking an operator-facing notification workflow.
add proof: sufficient: Contributor real behavior proof is sufficient. The source PR body includes after-fix terminal output showing the codec roundtrip now returns {} for enabled-with-defaults, and this replacement PR carries the same fix.
add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🦞 diamond lobster.
add status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (terminal): The source PR body includes after-fix terminal output showing the codec roundtrip now returns {} for enabled-with-defaults, and this replacement PR carries the same fix.

Label justifications:

P1: The PR fixes a user-enabled cron alert path that can silently stop notifying after gateway restart, breaking an operator-facing notification workflow.
rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🦞 diamond lobster.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (terminal): The source PR body includes after-fix terminal output showing the codec roundtrip now returns {} for enabled-with-defaults, and this replacement PR carries the same fix.
proof: sufficient: Contributor real behavior proof is sufficient. The source PR body includes after-fix terminal output showing the codec roundtrip now returns {} for enabled-with-defaults, and this replacement PR carries the same fix.

Evidence reviewed

PR surface:

Source +2, Tests +54. Total +56 across 2 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	1	3	1	+2
Tests	1	54	0	+54
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	2	57	1	+56

What I checked:

Root policy read: Root AGENTS.md was read fully and applied; there is no scoped src/cron/AGENTS.md, so the root review and SQLite compatibility guidance applies. (AGENTS.md:1, 8a5cb85c31e5)
Current main writes the enabled sentinel: bindFailureAlertColumns({}) writes failure_alert_disabled: 0 while all explicit alert option columns may remain null. (src/cron/store/failure-alert-codec.ts:33, 8a5cb85c31e5)
Current main drops that sentinel on read: failureAlertFromRow returns undefined when all explicit option columns are empty without considering failure_alert_disabled === 0. (src/cron/store/failure-alert-codec.ts:49, 8a5cb85c31e5)
Runtime reload consumes the decoder: rowToCronJob calls failureAlertFromRow and only includes failureAlert when the decoded value is not undefined, so the scheduler loses the per-job alert after reload. (src/cron/store/row-codec.ts:218, 8a5cb85c31e5)
Resolver distinguishes defaults from absence: resolveFailureAlert returns null when job config is absent and global alerts are not enabled; an empty object proceeds with default alert policy. (src/cron/service/failure-alerts.ts:75, 8a5cb85c31e5)
CLI can create the defaults-only state: openclaw cron edit <job> --failure-alert with no nested alert flags creates an empty failureAlert object in the patch. (src/cli/cron-cli/register.cron-edit.ts:541, 8a5cb85c31e5)

Likely related people:

Shakker: Current blame for failure-alert-codec.ts, row-codec.ts, and failure-alerts.ts points to commit c81fec0, which introduced the split cron store codec path in this checkout. (role: current codec line author; confidence: high; commits: c81fec0370c4; files: src/cron/store/failure-alert-codec.ts, src/cron/store/row-codec.ts, src/cron/service/failure-alerts.ts)
0xbrak: Authored the original configurable cron failure-alert feature in merged PR 24789, including per-job failureAlert, CLI flags, and service tests. (role: introduced behavior; confidence: medium; commits: e6fbcccae808, 4637b90c070f; files: src/cli/cron-cli/register.cron-edit.ts, src/cron/service.failure-alert.test.ts, src/cron/types.ts)
Takhoffman: Merged PR 24789 and authored follow-up failure-alert semantics commits in that branch; also requested automerge on the source PR that this PR replaces. (role: feature merger and adjacent contributor; confidence: medium; commits: f99ba28d4b81, 4637b90c070f; files: src/cli/cron-cli/register.cron-edit.ts, src/cron/service.failure-alert.test.ts, src/cron/types.ts)
kesor: Authored merged PR 31059, which expanded cron failure-alert and failure-destination behavior around the same alert contract. (role: recent adjacent contributor; confidence: medium; commits: b03645b480e6, f538c16eb9a0; files: src/cron/service.failure-alert.test.ts, src/cron/service/jobs.ts, src/cron/types.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

clawsweeper · 2026-06-25T01:17:34Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=bd9b2a179853641432ad284b87658b77437c216a)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-06-25T01:17:31Z
Merge commit: a21144d8a606

What merged:

The PR preserves failure_alert_disabled === 0 as the enabled-with-defaults failure-alert state and adds focused codec roundtrip tests.
PR surface: Source +2, Tests +54. Total +56 across 2 files.
Reproducibility: yes. At source level, current main encodes failureAlert: {} with failure_alert_disabled = 0, then decodes it as undefined when all explicit alert option columns are null.

Automerge notes:

No ClawSweeper repair was needed after automerge opt-in.

The automerge loop is complete.

Automerge progress:

2026-06-25 01:15:09 UTC review passed bd9b2a179853 (structured ClawSweeper verdict: pass (sha=bd9b2a179853641432ad284b87658b77437c2...)

2026-06-25 01:17:34 UTC merged bd9b2a179853 (merged by ClawSweeper automerge)

… roundtrip (fixes openclaw#96589) (AI-assisted) (openclaw#96615) Summary: - The PR preserves `failure_alert_disabled === 0` as the enabled-with-defaults failure-alert state and adds focused codec roundtrip tests. - PR surface: Source +2, Tests +54. Total +56 across 2 files. - Reproducibility: yes. At source level, current main encodes `failureAlert: {}` with `failure_alert_disabled = 0`, then decodes it as `undefined` when all explicit alert option columns are null. Automerge notes: - No ClawSweeper repair was needed after automerge opt-in. Validation: - ClawSweeper review passed for head bd9b2a1. - Required merge gates passed before the squash merge. Prepared head SHA: bd9b2a1 Review: openclaw#96615 (comment) Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: liuhao1024 <[email protected]> Approved-by: takhoffman

… roundtrip (fixes openclaw#96589) (AI-assisted) (openclaw#96615) Summary: - The PR preserves `failure_alert_disabled === 0` as the enabled-with-defaults failure-alert state and adds focused codec roundtrip tests. - PR surface: Source +2, Tests +54. Total +56 across 2 files. - Reproducibility: yes. At source level, current main encodes `failureAlert: {}` with `failure_alert_disabled = 0`, then decodes it as `undefined` when all explicit alert option columns are null. Automerge notes: - No ClawSweeper repair was needed after automerge opt-in. Validation: - ClawSweeper review passed for head bd9b2a1. - Required merge gates passed before the squash merge. Prepared head SHA: bd9b2a1 Review: openclaw#96615 (comment) Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: liuhao1024 <[email protected]> Approved-by: takhoffman (cherry picked from commit a21144d)

fix(cron): preserve enabled-with-defaults failure alert through store…

bd9b2a1

… roundtrip (fixes #96589) (AI-assisted) Co-authored-by: liuhao1024 <[email protected]>

clawsweeper Bot added clawsweeper:automerge Maintainer opted this PR into bounded ClawSweeper-reviewed automerge clawsweeper Tracked by ClawSweeper automation labels Jun 25, 2026

clawsweeper Bot mentioned this pull request Jun 25, 2026

fix(cron): preserve enabled-with-defaults failure alert through store roundtrip (fixes #96589) (AI-assisted) #96601

Closed

1 task

openclaw-barnacle Bot added the size: S label Jun 25, 2026

clawsweeper Bot merged commit a21144d into main Jun 25, 2026
146 of 158 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-96601 branch June 25, 2026 01:17

clawsweeper Bot mentioned this pull request Jun 25, 2026

fix(cron): preserve enabled-with-defaults failureAlert across store round trips #96602

Closed

Haderach-Ram mentioned this pull request Jun 25, 2026

Ecosystem Digest — 2026-06-25 Haderach-Ram/openclaw-radar#61

Open

github-actions Bot mentioned this pull request Jun 25, 2026

📡 Upstream Digest — 2026-06-25 02:33 UTC curtismercier/openclaw-mods#1149

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(cron): preserve enabled-with-defaults failure alert through store roundtrip (fixes #96589) (AI-assisted)#96615

fix(cron): preserve enabled-with-defaults failure alert through store roundtrip (fixes #96589) (AI-assisted)#96615
clawsweeper[bot] merged 1 commit into
mainfrom
clawsweeper/automerge-openclaw-openclaw-96601

clawsweeper Bot commented Jun 25, 2026

Uh oh!

clawsweeper Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

clawsweeper Bot commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

Uh oh!

Uh oh!

Conversation

clawsweeper Bot commented Jun 25, 2026

Source

Uh oh!

clawsweeper Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

clawsweeper Bot commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

0 participants

clawsweeper Bot commented Jun 25, 2026 •

edited

Loading