fix(qqbot): truncate reminder job name on a code-point boundary by WeeLi-009 · Pull Request #96575 · openclaw/openclaw

WeeLi-009 · 2026-06-24T22:38:41Z

Summary: The QQBot reminder job name was sliced to 20 UTF-16 units, tearing an emoji at the boundary into a lone surrogate. This truncates on a code-point boundary so multi-unit characters stay intact.

What Problem This Solves

QQBot reminder job names were truncated with a raw UTF-16 .slice() budget. Inputs that place an emoji or other astral character on the truncation boundary can leave a lone surrogate in the generated job name.

Trigger example:

xxxxxxxxxxxxxxxxxxx😀tail

The first 20 UTF-16 units contain 19 ASCII characters plus only the emoji high surrogate, producing a malformed string such as:

Reminder: xxxxxxxxxxxxxxxxxxx\ud83d…

Fix

extensions/qqbot/src/engine/tools/remind-logic.ts now builds reminder job names with the shared truncateUtf16Safe helper instead of raw .slice() truncation.

That keeps the existing 20 UTF-16-unit job-name budget and ellipsis behavior, while relying on the shared helper's range validation to avoid cutting between surrogate pairs. The generated job name remains escaped/serializable as a well-formed JavaScript string even when the input contains emoji at the boundary.

Evidence

Command run from a temporary worktree checked out at fix/qqbot-jobname-surrogate:

node --import tsx demo.mts

The demo imports the real generateJobName function from extensions/qqbot/src/engine/tools/remind-logic.ts, reproduces the old raw .slice(0, 20) behavior, then calls the fixed function.

INPUT
content="xxxxxxxxxxxxxxxxxxx😀tail"
utf16_length=25

BEFORE old raw slice(0, 20)
output="Reminder: xxxxxxxxxxxxxxxxxxx\ud83d…"
boundary_char_code=0xd83d
boundary_code_point=0xd83d
lone_surrogate=true
string_from_boundary=�

AFTER generateJobName from remind-logic.ts
output="Reminder: xxxxxxxxxxxxxxxxxxx…"
lone_surrogate=false
utf16_length=30

The old path leaves a lone high surrogate (0xd83d). The fixed generateJobName output is well-formed and the lone-surrogate check returns false.

Tests

Vitest coverage was added for generateJobName in extensions/qqbot/src/engine/tools/remind-logic.test.ts.

The tests cover:

short reminder content remaining unchanged;
long ASCII content preserving the existing 20 UTF-16-unit truncation plus ellipsis behavior;
exactly-fitting emoji content staying unchanged;
emoji/surrogate-boundary truncation dropping the whole split pair and producing no lone surrogate.

clawsweeper · 2026-06-24T22:39:37Z

Codex review: needs maintainer review before merge. Reviewed June 26, 2026, 2:07 AM ET / 06:07 UTC.

Summary
The branch changes QQBot reminder job-name generation to use truncateUtf16Safe and adds tests for ASCII, emoji, and surrogate-boundary truncation.

PR surface: Source +1, Tests +34. Total +35 across 2 files.

Reproducibility: yes. at source level: current main slices the trimmed reminder content at UTF-16 unit 20, so 19 ASCII units followed by an emoji can leave a lone high surrogate before the ellipsis. The PR body also includes terminal proof from the real generateJobName path showing the old lone surrogate and the fixed output.

Review metrics: 1 noteworthy metric.

Default-name reminder builders: 2 covered. Both one-shot and recurring QQBot reminder builders share generateJobName, so one helper change covers the default job-name paths before merge.

Merge readiness
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Next step before merge

No ClawSweeper repair is needed; the remaining action is normal maintainer review and merge handling for the existing PR.

Security
Cleared: The diff only changes QQBot string truncation and colocated tests, with no secrets, auth, dependency, CI, packaging, or code-execution surface changes.

Review details

Best possible solution:

Land the helper-based QQBot reminder fix after normal maintainer approval, keeping the shared SDK text helper as the single truncation implementation.

Do we have a high-confidence way to reproduce the issue?

Yes, at source level: current main slices the trimmed reminder content at UTF-16 unit 20, so 19 ASCII units followed by an emoji can leave a lone high surrogate before the ellipsis. The PR body also includes terminal proof from the real generateJobName path showing the old lone surrogate and the fixed output.

Is this the best way to solve the issue?

Yes. Reusing the existing truncateUtf16Safe SDK helper is the narrowest maintainable fix; a QQBot-local surrogate guard would duplicate shared text-boundary logic.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 4fc504d321b6.

Label changes

Label justifications:

P2: This is a bounded QQBot reminder string-handling bug with limited blast radius and no evidence of outage, data loss, or security impact.
rating: 🦞 diamond lobster: Overall readiness is 🦞 diamond lobster; proof is 🦞 diamond lobster and patch quality is 🦞 diamond lobster.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (terminal): The PR body provides terminal output from a demo importing the real generateJobName, showing the old raw slice produced a lone surrogate and the fixed function does not.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body provides terminal output from a demo importing the real generateJobName, showing the old raw slice produced a lone surrogate and the fixed function does not.

Evidence reviewed

PR surface:

Source +1, Tests +34. Total +35 across 2 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	1	2	1	+1
Tests	1	39	5	+34
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	2	41	6	+35

What I checked:

Repository policy read: Read the full root AGENTS.md and scoped extensions/AGENTS.md; the plugin-boundary rule supports using public openclaw/plugin-sdk/* subpaths from bundled plugins. (extensions/AGENTS.md:16, 4fc504d321b6)
Current main still has the bug path: generateJobName currently builds the default name with trimmed.slice(0, 20), so a valid astral character starting at the truncation boundary can leave a dangling high surrogate before the ellipsis. (extensions/qqbot/src/engine/tools/remind-logic.ts:174, 4fc504d321b6)
Both default-name job builders share the fixed function: The one-shot and recurring reminder builders both use params.name || generateJobName(content), so changing generateJobName covers both QQBot reminder default job-name paths. (extensions/qqbot/src/engine/tools/remind-logic.ts:191, 4fc504d321b6)
Helper contract is the right boundary: truncateUtf16Safe delegates to sliceUtf16Safe, whose end-boundary logic backs off when the slice would end after a high surrogate and before the matching low surrogate; the helper is exported through openclaw/plugin-sdk/text-utility-runtime. (src/utils.ts:100, 4fc504d321b6)
PR head implements the narrow fix and tests it: The PR imports truncateUtf16Safe, replaces the raw slice in generateJobName, and adds tests for exact emoji fit plus surrogate-boundary truncation with no lone-surrogate assertion. (extensions/qqbot/src/engine/tools/remind-logic.ts:172, b24820bad481)
Latest release does not already contain the fix: v2026.6.10 still shows the same raw trimmed.slice(0, 20) implementation, and no local branch or tag contains the PR head SHA, so this PR remains necessary. (extensions/qqbot/src/engine/tools/remind-logic.ts:174, aa69b12d0086)

Likely related people:

cxyhhhhh: Merged PR feat(qqbot): extract self-contained engine/ architecture with QR-code onboarding, approval handling #67960 added the QQBot engine architecture and the initial remind-logic.ts/test surface containing the default job-name path. (role: introduced QQBot reminder engine; confidence: high; commits: 5e72e39c1852; files: extensions/qqbot/src/engine/tools/remind-logic.ts, extensions/qqbot/src/engine/tools/remind-logic.test.ts, extensions/qqbot/src/bridge/tools/remind.ts)
GaosCode: Merged PR fix(qqbot): schedule reminders through cron gateway #70937 changed the same QQBot reminder engine, bridge tool, and tests while routing reminders through Gateway cron. (role: recent reminder-flow contributor; confidence: high; commits: 28497515fe1e; files: extensions/qqbot/src/engine/tools/remind-logic.ts, extensions/qqbot/src/engine/tools/remind-logic.test.ts, extensions/qqbot/src/bridge/tools/remind.ts)
zhang-guiping: Current-main blame attributes the present generateJobName raw-slice lines and shared UTF-16 helper lines to commit bead84f0ee6e, so they are relevant for routing current behavior questions. (role: current-main line author; confidence: medium; commits: bead84f0ee6e; files: extensions/qqbot/src/engine/tools/remind-logic.ts, src/utils.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

generateJobName truncated reminder content with String.slice(0, 20) on a UTF-16 code-unit index, so an astral character (e.g. an emoji) landing on the boundary was cut into a lone surrogate, producing a malformed cron job name. Truncate with the shared truncateUtf16Safe helper so a surrogate pair is never split, keeping the existing 20-unit budget and ellipsis suffix. Adds a test asserting the truncated job name contains no lone surrogate.

…aw#96575) generateJobName truncated reminder content with String.slice(0, 20) on a UTF-16 code-unit index, so an astral character (e.g. an emoji) landing on the boundary was cut into a lone surrogate, producing a malformed cron job name. Truncate with the shared truncateUtf16Safe helper so a surrogate pair is never split, keeping the existing 20-unit budget and ellipsis suffix. Adds a test asserting the truncated job name contains no lone surrogate.

…aw#96575) generateJobName truncated reminder content with String.slice(0, 20) on a UTF-16 code-unit index, so an astral character (e.g. an emoji) landing on the boundary was cut into a lone surrogate, producing a malformed cron job name. Truncate with the shared truncateUtf16Safe helper so a surrogate pair is never split, keeping the existing 20-unit budget and ellipsis suffix. Adds a test asserting the truncated job name contains no lone surrogate. (cherry picked from commit d693ed4)

…aw#96575) generateJobName truncated reminder content with String.slice(0, 20) on a UTF-16 code-unit index, so an astral character (e.g. an emoji) landing on the boundary was cut into a lone surrogate, producing a malformed cron job name. Truncate with the shared truncateUtf16Safe helper so a surrogate pair is never split, keeping the existing 20-unit budget and ellipsis suffix. Adds a test asserting the truncated job name contains no lone surrogate.

openclaw-barnacle Bot added channel: qqbot size: XS triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. labels Jun 24, 2026

WeeLi-009 force-pushed the fix/qqbot-jobname-surrogate branch from 465ec46 to b57f463 Compare June 25, 2026 00:23

openclaw-barnacle Bot removed the triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. label Jun 25, 2026

WeeLi-009 force-pushed the fix/qqbot-jobname-surrogate branch from b57f463 to b24820b Compare June 25, 2026 13:26

github-actions Bot mentioned this pull request Jun 26, 2026

🦞 OpenClaw 生态日报 2026-06-26 96loveslife/big_model_radar#60

Open

clawsweeper Bot added rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels Jun 26, 2026

vincentkoc merged commit d693ed4 into openclaw:main Jun 27, 2026
103 of 105 checks passed

github-actions Bot mentioned this pull request Jun 27, 2026

📡 Upstream Digest — 2026-06-27 16:59 UTC curtismercier/openclaw-mods#1160

Open

This was referenced Jun 28, 2026

fix(auth): recover from malformed API-key profiles #97520

Merged

improve: show edit mismatch candidate lines #97512

Closed

fix(llm): preserve structured tool result text across providers #97450

Closed

This was referenced Jun 30, 2026

fix(qqbot): drop dangling surrogates in gateway log previews #98129

Closed

fix(qqbot): drop dangling surrogates in messaging log previews #98131

Closed

clawsweeper Bot mentioned this pull request Jul 2, 2026

fix(qqbot): bound plain-number minute input in parseRelativeTime to prevent overflow #99038

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(qqbot): truncate reminder job name on a code-point boundary#96575

fix(qqbot): truncate reminder job name on a code-point boundary#96575
vincentkoc merged 1 commit into
openclaw:mainfrom
WeeLi-009:fix/qqbot-jobname-surrogate

WeeLi-009 commented Jun 24, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jun 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

WeeLi-009 commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Fix

Evidence

Tests

Uh oh!

clawsweeper Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

WeeLi-009 commented Jun 24, 2026 •

edited

Loading

clawsweeper Bot commented Jun 24, 2026 •

edited

Loading