refactor: narrow bundled session runtime barrels#96507
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 24, 2026, 1:07 PM ET / 17:07 UTC. Summary PR surface: Source +38, Tests +75, Other +2. Total +115 across 11 files. Reproducibility: not applicable. this is a refactor/private API cleanup PR, not a bug report with a failing user flow. The behavior-preservation claim is source-checkable through the accessor and model override paths plus focused tests. Review metrics: 1 noteworthy metric.
Stored data model Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Keep this in the normal maintainer PR flow, with final merge gated on the remaining CI and any maintainer review for the protected label. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a refactor/private API cleanup PR, not a bug report with a failing user flow. The behavior-preservation claim is source-checkable through the accessor and model override paths plus focused tests. Is this the best way to solve the issue? Yes; this is the best current shape for this slice because it reuses the existing session accessor seam, preserves Feishu latest-read semantics, and preserves Mattermost parent model override inheritance without widening private runtime barrels. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 4ae0a5d958a0. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +38, Tests +75, Other +2. Total +115 across 11 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
What Problem This Solves
Path 3.1b still had Feishu and Mattermost bundled runtime barrels exporting deprecated session whole-store helpers even though the remaining production callers only need targeted session-entry reads. That kept private bundled runtime/API surfaces wider than the accessor migration needs.
Why This Change Was Made
The runtime read paths can use the existing session accessor seam directly while preserving current behavior, including latest-read semantics and Mattermost parent model-override inheritance. Feishu doctor/migration code keeps its file-backed compatibility import because doctor cleanup is the correct owner for that legacy whole-store mutation.
User Impact
No user-visible behavior change is intended. Feishu reasoning previews and Mattermost model-picker summaries continue to read the same session metadata, but the bundled runtime barrels no longer expose deprecated whole-store helpers for those hot paths.
Evidence
node scripts/run-vitest.mjs extensions/feishu/src/reasoning-preview.test.ts extensions/mattermost/src/mattermost/model-picker.test.ts src/plugin-sdk/session-store-runtime.test.ts test/scripts/check-session-accessor-boundary.test.tspassed 4 Vitest shards.node scripts/check-session-accessor-boundary.mjspassed.git diff --checkpassed.AGENTS_HOME="$HOME/.agents" "$HOME/.agents/skills/autoreview/scripts/autoreview" --mode branch --base upstream/mainreported no accepted/actionable findings.Refs #88838