fix(qa): issue unique mock tool call ids#96338
Merged
Merged
Conversation
openclaw-barnacle
Bot
added
extensions: qa-lab
size: XS
maintainer
vincentkoc
marked this pull request as ready for review
June 24, 2026 08:40
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(qa): issue unique mock tool call ids This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Member
Author
|
Merged via squash.
|
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jun 25, 2026
QiuYuang
pushed a commit
to QiuYuang/openclaw
that referenced
this pull request
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The QA runtime parity soak can report a tool error when a scenario legitimately repeats the same tool call. The QA mock provider reused the same
call_id, function item id, and response id for identical tool name/argument pairs, which violates the provider tool-call identity contract.Why This Change Was Made
Keep the existing argument hash for readable, repeatable diagnostics, then append a process-local monotonic sequence to every emitted mock function call. This preserves the useful prefix while guaranteeing distinct identities across repeated turns. The regression test sends the same request twice and asserts distinct call ids.
User Impact
No production runtime behavior changes. Release QA parity and soak runs no longer produce false tool-error failures from duplicate mock tool-call ids.
Evidence
node scripts/run-vitest.mjs extensions/qa-lab/src/providers/mock-openai/server.test.ts --runruntime-long-context-cache-stability