fix(slack): stop logging inbound message previews#96312
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed July 4, 2026, 1:06 PM ET / 17:06 UTC. Summary PR surface: Source +2, Tests +38. Total +40 across 2 files. Reproducibility: yes. Source inspection on current main shows Slack Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the metadata-only Slack verbose log after redacted real Slack ingress proof shows the runtime log is content-free and maintainer handling clears the protected-label flow. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection on current main shows Slack Is this the best way to solve the issue? Yes. The patch is the narrow owner-boundary fix: it keeps AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against c78b0d59f5a2. Label changesLabel justifications:
Evidence reviewedPR surface: Source +2, Tests +38. Total +40 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
a28dce4 to
06bf20d
Compare
06bf20d to
47d039f
Compare
|
Maintainer verification is complete on exact head
The local live artifact contains workspace metadata and was intentionally not published. |
|
Merged via squash.
|
What Problem This Solves
Slack verbose ingress logging currently includes the first 160 characters of every prepared inbound message. That can copy direct-message text, channel text, or resolved attachment text into production logs even when operators only need routing and correlation data.
Why This Change Was Made
User Impact
Operators keep the metadata needed to correlate Slack ingress with routing and sessions, while inbound message text is no longer duplicated into verbose logs. Message preparation and delivery behavior are unchanged.
Evidence
47d039f9a0fe9b1e9800872b09f74f2efb80857e.node scripts/run-vitest.mjs extensions/slack/src/monitor/message-handler/prepare.test.ts— 1 file, 92 tests passed.tbx_01kwq136yxfgxrhfmyt925swen— changed extension production/test typechecks, focused lint, database-first and media guards, and import-cycle checks passed. Actions: https://github.com/openclaw/openclaw/actions/runs/28713269172git diff --checkpasses.patch is correct, confidence 0.98).47d039f9a0fe9b1e9800872b09f74f2efb80857epassed through the native Slack driver in 4259ms. With debug file logging enabled, the run emitted two metadata-onlyslack inbound:entries and zero occurrences of the live input phrase, generated marker prefix, orpreview=. The local artifact contains workspace metadata and is intentionally not published.