Add marketplace feed entries command#96158
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 28, 2026, 5:07 PM ET / 21:07 UTC. Summary PR surface: Source +125, Tests +224, Docs +12. Total +361 across 5 files. Reproducibility: not applicable. this is a feature PR, not a current-main bug report. Current main and v2026.6.10 do not provide Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land only after maintainers accept the entries command, options, and output shape as intentional public CLI surface, leaving telemetry to #96194 and broader activation to later work. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a feature PR, not a current-main bug report. Current main and v2026.6.10 do not provide Is this the best way to solve the issue? Yes, pending maintainer acceptance: the implementation reuses the existing hosted catalog loader, redaction helper, source-profile validation, and install resolver instead of creating a parallel marketplace reader. The remaining question is product/API acceptance of the new CLI/output contract. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 686a2876c7f4. Label changesLabel justifications:
Evidence reviewedPR surface: Source +125, Tests +224, Docs +12. Total +361 across 5 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
76baf5a to
9dcb7b7
Compare
ebe4078 to
c1029ae
Compare
9dcb7b7 to
0e4486b
Compare
c1029ae to
cb818b4
Compare
|
Rebased on the shared marketplace URL redaction fix from #96155 and added entries-command coverage so JSON/text output redacts query strings, fragments, username, and password from emitted feed URLs and fallback errors. @clawsweeper re-review |
0e4486b to
15b033a
Compare
cb818b4 to
13cea8e
Compare
|
@clawsweeper re-review |
c8f2d3e to
77dbf95
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
77dbf95 to
fd69293
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
fd69293 to
1289a25
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Merged via squash.
Thanks @giodl73-repo! |
Merged via squash. Prepared head SHA: 1289a25 Co-authored-by: giodl73-repo <[email protected]> Co-authored-by: giodl73-repo <[email protected]> Reviewed-by: @giodl73-repo
Merged via squash. Prepared head SHA: 1289a25 Co-authored-by: giodl73-repo <[email protected]> Co-authored-by: giodl73-repo <[email protected]> Reviewed-by: @giodl73-repo
Merged via squash. Prepared head SHA: 1289a25 Co-authored-by: giodl73-repo <[email protected]> Co-authored-by: giodl73-repo <[email protected]> Reviewed-by: @giodl73-repo
Merged via squash. Prepared head SHA: 1289a25 Co-authored-by: giodl73-repo <[email protected]> Co-authored-by: giodl73-repo <[email protected]> Reviewed-by: @giodl73-repo
Uh oh!
There was an error while loading. Please reload this page.