fix(video-task): add delivering status to break self-deadlock in scheduleMediaGenerationTaskCompletion by zw-xysk · Pull Request #95993 · openclaw/openclaw

zw-xysk · 2026-06-23T06:23:20Z

What Problem This Solves

scheduleMediaGenerationTaskCompletion keeps the task running during wakeTaskCompletion, creating a self-deadlock where the next video_generate call is blocked until the woken agent turn finishes. Sequential video generation workflows pay a ~3.5-4 min "release tax" per segment.

Evidence

Fix

Added delivering to TaskStatus and TASK_STATUSES, exported markTaskDeliveringByRunId, and updated all downstream Record mappings for type completeness.

Verification

# Core logic tests
$ npx vitest run src/agents/media-generation-task-status-shared.test.ts
✓ Tests  ✅ Passed

# Type completeness (all Record<TaskStatus> mappings updated)
$ npx vitest run src/tasks/task-registry.test.ts src/commands/flows.test.ts src/commands/status.test.ts
✓ Tests  ✅ Passed

# Downstream snapshot tests
$ npx vitest run src/gateway/server-reload-handlers.test.ts
✓ Tests  ✅ Passed

What was not tested

Real video generation pipeline (requires cloud provider credentials).

Checks

16 files, +69/-14. Lockfile unchanged.

…duleMediaGenerationTaskCompletion Introduce a non-terminal 'delivering' task status that separates 'media generated' from 'delivery confirmed', breaking the self-deadlock where scheduleMediaGenerationTaskCompletion kept the task 'running' during wakeTaskCompletion, blocking the agent from starting distinct follow-up video generation requests. Changes: - Add 'delivering' to TaskStatus type and TASK_STATUSES set - Export markTaskDeliveringByRunId to transition tasks to delivering state - Update isTaskStillBlockingDuplicateGuard call sites so delivering tasks no longer block new, distinct media generation requests - Set delivering status in scheduleMediaGenerationTaskCompletion after media generation completes (before wakeTaskCompletion) - Update all active-task-status checks across task registry, executor, flow registry, and audit to recognize delivering as non-terminal ClawSweeper review: 'a focused repair is plausible' Issue: openclaw#95701 Co-Authored-By: 赵旺0668001248 <[email protected]>

zw-xysk · 2026-06-23T06:23:35Z

@clawsweeper re-review

clawsweeper · 2026-06-23T06:23:38Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

…espect module boundaries The agents/tools/media-generate-background-shared.ts was importing directly from task-registry.ts, violating the approved import seam boundary. Now imported via runtime-internal.ts (the approved facade).

zw-xysk · 2026-06-23T06:43:11Z

Fixed module boundary violation — imported markTaskDeliveringByRunId via runtime-internal.ts instead of directly from task-registry.ts. @clawsweeper re-review

…e completeness The 'delivering' status was added to TaskStatus but three Record mappings were not updated, causing TS2741 errors in CI: - TASK_STATUS_ICONS (commands-tasks.ts): add delivering → 📦 - TASK_STATUS_TO_LEDGER_STATUS (tasks.ts): add delivering → running - createEmptyTaskStatusCounts (summary.ts): add delivering → 0 Co-Authored-By: Claude (via Anthropic API) <[email protected]>

zw-xysk · 2026-06-23T08:16:39Z

Fixed CI type-completeness errors: added the missing delivering status to three downstream Record mappings that must cover all TaskStatus values.

TASK_STATUS_ICONS: delivering → 📦
TASK_STATUS_TO_LEDGER_STATUS: delivering → running
createEmptyTaskStatusCounts: delivering → 0

@clawsweeper re-review

clawsweeper · 2026-06-23T08:16:42Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

TaskStatusCounts now requires 'delivering', so all test fixtures with inline byStatus objects must include delivering: 0. - status.summary.redaction.test.ts, status.summary.test.ts - task-domain-views.test.ts, flows.test.ts Co-Authored-By: Claude (via Anthropic API) <[email protected]>

zw-xysk · 2026-06-23T08:59:19Z

Fixed remaining CI failures: added delivering: 0 to 4 test fixtures with inline byStatus objects, and updated flows.test.ts snapshot.

@clawsweeper re-review

clawsweeper · 2026-06-23T08:59:22Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

TaskStatusCounts now requires 'delivering', so all test fixtures with inline byStatus objects must include delivering: 0. - task-registry.test.ts: summary assertion - status.test.ts: 3 byStatus blocks - server-reload-handlers.test.ts: reload guard assertion Co-Authored-By: Claude (via Anthropic API) <[email protected]>

zw-xysk · 2026-06-23T09:32:00Z

Fixed 4 more test fixtures with missing delivering. CI should pass now.

@clawsweeper re-review

clawsweeper · 2026-06-23T09:32:03Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

New file added on main was missing from the expected test project list, causing CI failure on the merge commit. Not related to delivering changes. Co-Authored-By: Claude (via Anthropic API) <[email protected]>

zw-xysk · 2026-06-23T10:32:39Z

Fixed pre-existing test snapshot issue (check-workflows.test.ts missing from expected list). Not related to delivering changes.

@clawsweeper re-review

clawsweeper · 2026-06-23T10:32:41Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

clawsweeper · 2026-06-23T19:47:45Z

Codex review: needs real behavior proof before merge. Reviewed June 23, 2026, 3:54 PM ET / 19:54 UTC.

Summary
The branch adds a delivering task status, marks generated media tasks before completion wake delivery, updates active-task/status/gateway mappings, and adjusts task/status tests.

PR surface: Source +59, Tests +10. Total +69 across 23 files.

Reproducibility: yes. The source path and production report show provider completion progress is recorded while the task remains active until wakeTaskCompletion returns; I did not run a live BytePlus repro in this read-only review.

Review metrics: 1 noteworthy metric.

Task Status Vocabulary: 1 added. A new persisted task status affects registry parsing, summaries, gateway mapping, docs, and any task/flow consumer that treats unknown nonterminal states as failure.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #95701
Summary: This PR and the narrower open PR both target the same canonical video-generation deadlock issue; neither has merged yet.

Members:

canonical: video_generate background task stays "running" for minutes after media ready — self-deadlock between wake (expectFinal) and completeTaskRun #95701 - The issue contains the production report, source-level root cause, and suggested repair boundary for the video task deadlock.
fixed_by_candidate: fix(video): skip delivering tasks in active-task prompt guard #96018 - This open PR also claims to fix the canonical issue with a narrower progress-marker-based prompt-guard change.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🦪 silver shellfish
Result: blocked until real behavior proof from a real setup is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

[P1] Preserve same-request duplicate protection during the delivery phase and add focused coverage for that case.
[P1] Add redacted real behavior proof such as terminal output, logs, or a short recording/artifact showing two distinct sequential video requests no longer wait on the prior delivery wake.
Resolve whether maintainers want this broader persisted status approach or the narrower candidate at fix(video): skip delivering tasks in active-task prompt guard #96018.

Proof guidance:

[P1] Needs real behavior proof before merge: The PR body provides unit-test and formatting results only; it does not include after-fix real sequential video-generation proof from a live or realistic setup. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Risk before merge

[P1] Adding a persisted delivering task status changes the task-state vocabulary and needs compatibility/docs/API consumer proof beyond green CI.
[P1] The PR body lists unit tests and formatting only; it does not show a real sequential video_generate run, terminal output, logs, or a redacted provider-session artifact proving the deadlock is gone.
[P1] There is an open narrower candidate at fix(video): skip delivering tasks in active-task prompt guard #96018, so maintainers should decide whether this broader status-machine change is worth carrying.

Maintainer options:

Repair Before Merge (recommended)
Split delivery-phase prompt suppression from same-request duplicate detection, and cover the delivering phase with focused duplicate-guard tests before this branch lands.
Use The Narrower Candidate
If maintainers prefer not to add a persisted task status, pause or close this PR after choosing the narrower candidate at fix(video): skip delivering tasks in active-task prompt guard #96018.
Accept The New Status Deliberately
Maintainers may keep the new status shape, but should require task-flow, gateway, CLI/docs, and upgrade proof for the expanded task-state vocabulary.

Next step before merge

[P1] Needs human/contributor follow-up: the patch has a concrete duplicate-guard regression, missing real behavior proof, and a competing narrower candidate for the same canonical issue.

Security
Cleared: The diff does not add dependencies, secrets handling, external downloads, workflow permissions, or new code-execution surfaces.

Review findings

[P1] Preserve the same-request duplicate guard — src/agents/tools/media-generate-background-shared.ts:463-468
[P2] Map delivering through mirrored flow status — src/tasks/task-registry.types.ts:10

Review details

Best possible solution:

Land a narrow fix for the canonical issue that unblocks distinct follow-up video requests after media is ready while preserving same-request duplicate protection, delivery-confirmation closeout, and task/status compatibility.

Do we have a high-confidence way to reproduce the issue?

Yes. The source path and production report show provider completion progress is recorded while the task remains active until wakeTaskCompletion returns; I did not run a live BytePlus repro in this read-only review.

Is this the best way to solve the issue?

No. Introducing a delivery phase is plausible, but this patch lets identical requests bypass the duplicate guard during delivery and needs real behavior proof before it is the best fix.

Full review comments:

[P1] Preserve the same-request duplicate guard — src/agents/tools/media-generate-background-shared.ts:463-468
This transition makes a generated-but-undelivered task use the new delivering status, but the duplicate guard only recognizes queued, running, or recent succeeded tasks. During the delivery wake, an identical video_generate request can now miss the existing task and start a duplicate job, contrary to the tool contract and PR safety claim; split prompt-context suppression from same-request duplicate detection and add a delivering-phase duplicate test.
Confidence: 0.9
[P2] Map delivering through mirrored flow status — src/tasks/task-registry.types.ts:10
Adding delivering to the global TaskStatus union leaves deriveTaskFlowStatusFromTask with no matching case, so any task with a parent flow that enters this new nonterminal state falls through to failed. Either keep the delivery phase out of the global task status machine or map it as a running/nonterminal flow state with coverage.
Confidence: 0.74

Overall correctness: patch is incorrect
Overall confidence: 0.86

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against c24d266b2d09.

Label changes

Label changes:

add P2: This is a real but bounded video-generation workflow bug fix with limited blast radius, not an emergency runtime outage.
add merge-risk: 🚨 compatibility: The PR adds a new persisted task status and maps it through task/gateway surfaces, which can affect upgrades and clients.
add merge-risk: 🚨 session-state: The change alters how in-flight media tasks participate in session duplicate guards and active-task prompt state.
add rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🦪 silver shellfish.
add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body provides unit-test and formatting results only; it does not include after-fix real sequential video-generation proof from a live or realistic setup. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Label justifications:

P2: This is a real but bounded video-generation workflow bug fix with limited blast radius, not an emergency runtime outage.
merge-risk: 🚨 compatibility: The PR adds a new persisted task status and maps it through task/gateway surfaces, which can affect upgrades and clients.
merge-risk: 🚨 session-state: The change alters how in-flight media tasks participate in session duplicate guards and active-task prompt state.
rating: 🧂 unranked krab: Overall readiness is 🧂 unranked krab; proof is 🧂 unranked krab and patch quality is 🦪 silver shellfish.
status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The PR body provides unit-test and formatting results only; it does not include after-fix real sequential video-generation proof from a live or realistic setup. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Evidence reviewed

PR surface:

Source +59, Tests +10. Total +69 across 23 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	15	73	14	+59
Tests	8	10	0	+10
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	23	83	14	+69

What I checked:

Canonical issue context: The linked issue reports production video_generate runs staying running after media is ready, and it remains open with another open candidate fix at fix(video): skip delivering tasks in active-task prompt guard #96018.
Current main behavior: Current main still records Generated media; delivering completion, awaits wakeTaskCompletion, and only then calls completeTaskRun, so the reported deadlock path is not already fixed on main. (src/agents/tools/media-generate-background-shared.ts:447, c24d266b2d09)
Duplicate-guard contract: The current shared duplicate guard treats only queued and running tasks as blocking, and the duplicate-guard path falls back through the same active-task helper. (src/agents/media-generation-task-status-shared.ts:86, c24d266b2d09)
PR-introduced status transition: The PR marks the task delivering before completion wake delivery finishes, which means the existing same-request duplicate guard no longer sees that in-flight task unless the guard logic is split or extended. (src/agents/tools/media-generate-background-shared.ts:463, e3f4a642767a)
Latest release behavior: The latest release still has the pre-PR ordering: progress is recorded, completion wake is awaited, and completeTaskRun follows afterward. (src/agents/tools/media-generate-background-shared.ts:420, c645ec4555c0)
History routing: Current checkout blame for the media lifecycle, shared media status helper, and task-flow status mapping points at a recent broad current-main commit, so ownership routing is low-confidence but concrete. (src/agents/media-generation-task-status-shared.ts:86, e11539234b0f)

Likely related people:

Shakker: Current checkout blame for the shared media lifecycle/status helper and task-flow status derivation points to a recent broad commit; the grafted history makes this a routing hint rather than original authorship proof. (role: recent current-main carrier; confidence: low; commits: e11539234b0f; files: src/agents/tools/media-generate-background-shared.ts, src/agents/media-generation-task-status-shared.ts, src/tasks/task-flow-registry.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

vincentkoc · 2026-06-24T12:38:09Z

Superseded by the canonical fix in PR #96018, now merged as ae9474b5fdc0c2f90a2b82356734d86637754d97.

The landed fix resolves the same delivery-phase self-deadlock without expanding the task-status schema with a competing delivering state. It preserves existing status/duplicate semantics and adds prompt-aware regression coverage.

Closing this duplicate lane. Reopen only with a concrete regression not covered by the landed behavior.

zw-xysk · 2026-06-25T00:51:02Z

补充了测试通过证明。@clawsweeper re-review

zw-xysk · 2026-06-25T01:25:18Z

Updated PR body with required What Problem This Solves and Evidence sections (English headers). @clawsweeper re-review

openclaw-barnacle Bot added agents Agent runtime and tooling size: S labels Jun 23, 2026

openclaw-barnacle Bot added the gateway Gateway runtime label Jun 23, 2026

openclaw-barnacle Bot added the commands Command implementations label Jun 23, 2026

zw-xysk and others added 2 commits June 23, 2026 17:30

fix(video-task): add delivering to remaining status.test.ts byStatus

b49bc09

fix(video-task): add check-workflows to test project snapshot

e3f4a64

New file added on main was missing from the expected test project list, causing CI failure on the merge commit. Not related to delivering changes. Co-Authored-By: Claude (via Anthropic API) <[email protected]>

clawsweeper Bot mentioned this pull request Jun 23, 2026

fix(video): skip delivering tasks in active-task prompt guard #96018

Merged

4 tasks

vincentkoc closed this Jun 24, 2026

openclaw-barnacle Bot added the triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. label Jun 25, 2026

openclaw-barnacle Bot removed the triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. label Jun 25, 2026

Uh oh!

Uh oh!

Conversation

zw-xysk commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Evidence

Fix

Verification

What was not tested

Checks

Uh oh!

zw-xysk commented Jun 23, 2026

Uh oh!

clawsweeper Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zw-xysk commented Jun 23, 2026

Uh oh!

zw-xysk commented Jun 23, 2026

Uh oh!

clawsweeper Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zw-xysk commented Jun 23, 2026

Uh oh!

clawsweeper Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zw-xysk commented Jun 23, 2026

Uh oh!

clawsweeper Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zw-xysk commented Jun 23, 2026

Uh oh!

clawsweeper Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vincentkoc commented Jun 24, 2026

Uh oh!

zw-xysk commented Jun 25, 2026

Uh oh!

zw-xysk commented Jun 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zw-xysk commented Jun 23, 2026 •

edited

Loading

clawsweeper Bot commented Jun 23, 2026 •

edited

Loading

clawsweeper Bot commented Jun 23, 2026 •

edited

Loading

clawsweeper Bot commented Jun 23, 2026 •

edited

Loading

clawsweeper Bot commented Jun 23, 2026 •

edited

Loading

clawsweeper Bot commented Jun 23, 2026 •

edited

Loading

clawsweeper Bot commented Jun 23, 2026 •

edited

Loading