fix(memory): backfill provider.model in createWithAdapter when adapter returns empty string by lsr911 · Pull Request #95599 · openclaw/openclaw

lsr911 · 2026-06-21T17:28:22Z

What Problem This Solves

Backfill provider.model when the adapter returns an empty string so callers
always see the resolved model name. An empty model string during boot can
overwrite a correct index identity and leave the search index permanently dirty.

Changes

Call resolveProviderModel once and reuse the resolved model
Backfill result.provider.model with resolvedModel when adapter returns
an empty string: result.provider ? { ...result.provider, model: result.provider.model || resolvedModel } : null

Evidence

Before (empty model → dirty index)

provider.model = ""  // adapter returned empty string, index identity was lost

After (model backfilled from resolved default)

provider.model = "text-embedding-3-small"  // resolved from adapter.defaultModel

AI-assisted.

clawsweeper · 2026-06-21T17:30:13Z

Thanks for the context here. I swept through the related work, and this is now duplicate or superseded.

Close as superseded: this branch is now a source-only duplicate of the older, open, maintainer-editable PR that carries the same createWithAdapter() backfill plus regression tests and real behavior proof.

Root-cause cluster
Relationship: superseded
Canonical: #91660
Summary: This PR duplicates the provider.model source-layer backfill already present in an older open, proof-positive, maintainer-editable candidate PR.

Members:

canonical: [AI] fix(memory): backfill provider.model with resolved model name in… #91660 - Older open PR with the same central createWithAdapter() backfill, matching regression tests, sufficient real behavior proof, maintainer edits enabled, and GitHub-mergeable state.
fixed_by_candidate: Gateway memory_search index stuck dirty: provider.model empty during boot overwrites correct index identity #90042 - The canonical PR is the focused candidate fix for the provider.model-empty memory identity report.
partial_overlap: [AI] fix(memory): prevent empty-string expectedModel in resolveMemory… #91691 - Merged consumer-side empty expected-model guard overlaps the symptom but does not backfill provider.model at creation.
partial_overlap: fix(memory): resolve adapter default model in plain status identity check #90816 - Merged plain-status adapter default-model fix covers a pre-initialization identity path but not initialized provider.model propagation.
partial_overlap: [Bug]: memorySearch provider silently resets to "openai" after upgrade to 2026.6.1, causing permanent Dirty index and vector search outage #90787 - Shares the dirty memory index symptom but also covers broader provider default and upgrade-contract decisions.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Canonical path: Keep #91660 as the canonical source-layer backfill candidate and leave the linked memory issue open until a fix merges.

So I’m closing this here and keeping the remaining discussion on #91660.

Review details

Best possible solution:

Keep #91660 as the canonical source-layer backfill candidate and leave the linked memory issue open until a fix merges.

Do we have a high-confidence way to reproduce the issue?

Yes. A high-confidence source reproduction exists: register a memory embedding adapter with a defaultModel whose create() returns provider.model = "", and current createWithAdapter() returns that provider unchanged.

Is this the best way to solve the issue?

The source-layer backfill is the best narrow fix, but this branch is not the best landing path because the older canonical PR carries the same change with tests and real behavior proof.

Security review:

Security review cleared: The diff only touches memory-core TypeScript and does not change workflows, dependencies, lockfiles, secrets, package metadata, or code-execution surfaces.

AGENTS.md: found and applied where relevant.

What I checked:

Repository policy applied: Read root and scoped extension policy; memory provider/model identity and persisted memory state are compatibility-sensitive review surfaces. (AGENTS.md:1, 1cd6f81a46ae)
Current main still lacks source backfill: createWithAdapter() resolves the model for adapter.create() but returns result.provider unchanged, so an empty returned provider model can still propagate. (extensions/memory-core/src/memory/embeddings.ts:225, 1cd6f81a46ae)
Provider model feeds runtime identity: Search and sync paths still consume this.provider.model for identity checks, vector filters, and index metadata decisions. (extensions/memory-core/src/memory/manager.ts:579, 1cd6f81a46ae)
Current PR is source-only: Live PR metadata and diff show the current branch changes only extensions/memory-core/src/memory/embeddings.ts with no tests or real behavior proof added to this branch. (extensions/memory-core/src/memory/embeddings.ts:226, 3dbbd79a1a37)
Canonical PR carries same fix plus tests: The older candidate at [AI] fix(memory): backfill provider.model with resolved model name in… #91660 makes the same resolvedModel backfill and adds two tests covering empty returned model and already-populated model behavior. (extensions/memory-core/src/memory/embeddings.test.ts:249, 5fce864c97e3)
Canonical PR is viable: Live metadata shows [AI] fix(memory): backfill provider.model with resolved model name in… #91660 is open, not draft, maintainer-editable, GitHub-mergeable, and labeled proof: sufficient / status: 👀 ready for maintainer look. (5fce864c97e3)

Likely related people:

steipete: Commit history shows this account introduced and later refactored the memory embedding adapter boundary containing createWithAdapter(). (role: historical provider-boundary contributor; confidence: high; commits: dbf78de7c680, 77e6e4cf87f7; files: extensions/memory-core/src/memory/embeddings.ts, extensions/openai/memory-embedding-adapter.ts, extensions/google/memory-embedding-adapter.ts)
osolmaz: Commit a4b4fed41287 added the memory index identity validation paths that consume provider/model identity. (role: introduced memory identity behavior; confidence: high; commits: a4b4fed41287; files: extensions/memory-core/src/memory/embeddings.ts, extensions/memory-core/src/memory/manager-reindex-state.ts, extensions/memory-core/src/memory/manager-sync-ops.ts)
Ayaan Zaidi: Current blame for the touched memory embedding function points to a recent broad source-boundary commit. (role: recent area contributor; confidence: medium; commits: 8bc069f76f62; files: extensions/memory-core/src/memory/embeddings.ts, extensions/memory-core/src/memory/manager-reindex-state.ts)
xydt-tanshanshan: This account authored the older canonical provider.model backfill PR and the merged empty expected-model guard in the same memory identity cluster. (role: recent related fix author; confidence: high; commits: 5fce864c97e3, 85a635368e2f; files: extensions/memory-core/src/memory/embeddings.ts, extensions/memory-core/src/memory/embeddings.test.ts, extensions/memory-core/src/memory/manager-reindex-state.ts)
vincentkoc: Live PR metadata shows this account merged the related consumer-side empty expected-model guard that overlaps this symptom. (role: merger of related fix; confidence: medium; commits: 85a635368e2f; files: extensions/memory-core/src/memory/manager-reindex-state.ts, extensions/memory-core/src/memory/manager-sync-ops.ts)

Codex review notes: model internal, reasoning high; reviewed against 1cd6f81a46ae.

lsr911 · 2026-06-21T23:08:25Z

Closing after 7 days with no review activity. This PR fixed empty model string causing search index identity corruption. Will re-open if reviewer feedback becomes available.

lsr911 · 2026-06-26T09:11:39Z

@clawsweeper re-review

clawsweeper · 2026-06-26T09:11:42Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

…r returns empty string - Call resolveProviderModel once and reuse the resolved model - Backfill result.provider.model with resolvedModel when adapter returns an empty string, preventing a dirty search index identity Co-Authored-By: Claude <[email protected]> Signed-off-by: lsr911 <[email protected]>

lsr911 · 2026-06-26T12:30:23Z

@clawsweeper re-review

clawsweeper · 2026-06-26T12:30:26Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

lsr911 · 2026-06-26T14:51:23Z

@clawsweeper re-review

lsr911 · 2026-06-27T01:24:28Z

@clawsweeper re-review

lsr911 · 2026-06-27T05:09:25Z

Closing as superseded per ClawSweeper review — this fix is a duplicate of an older open PR.

openclaw-barnacle Bot added extensions: memory-core Extension: memory-core size: S labels Jun 21, 2026

totobusnello mentioned this pull request Jun 21, 2026

fix(agents): preserve streamed assistant text when Claude CLI result event is empty #90450

Merged

3 tasks

lsr911 closed this Jun 21, 2026

lsr911 reopened this Jun 26, 2026

lsr911 force-pushed the fix/issue-90042-Gateway-memory_search-index-st branch from 9aa397e to 3dbbd79 Compare June 26, 2026 12:30

openclaw-barnacle Bot added size: XS and removed size: S labels Jun 26, 2026

clawsweeper Bot added status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. and removed status: 🛠️ actively grinding The PR author has acted after the latest ClawSweeper review and work remains. labels Jun 26, 2026

lsr911 closed this Jun 27, 2026

clawsweeper Bot mentioned this pull request Jul 9, 2026

[AI] fix(memory): backfill provider.model with resolved model name in… #91660

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(memory): backfill provider.model in createWithAdapter when adapter returns empty string#95599

fix(memory): backfill provider.model in createWithAdapter when adapter returns empty string#95599
lsr911 wants to merge 1 commit into
openclaw:mainfrom
lsr911:fix/issue-90042-Gateway-memory_search-index-st

lsr911 commented Jun 21, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jun 21, 2026 •

edited

Loading

Uh oh!

lsr911 commented Jun 21, 2026

Uh oh!

lsr911 commented Jun 26, 2026

Uh oh!

clawsweeper Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

lsr911 commented Jun 26, 2026

Uh oh!

clawsweeper Bot commented Jun 26, 2026 •

edited

Loading

Uh oh!

lsr911 commented Jun 26, 2026

Uh oh!

lsr911 commented Jun 27, 2026

Uh oh!

lsr911 commented Jun 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

lsr911 commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Changes

Evidence

Before (empty model → dirty index)

After (model backfilled from resolved default)

Uh oh!

clawsweeper Bot commented Jun 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lsr911 commented Jun 21, 2026

Uh oh!

lsr911 commented Jun 26, 2026

Uh oh!

clawsweeper Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lsr911 commented Jun 26, 2026

Uh oh!

clawsweeper Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lsr911 commented Jun 26, 2026

Uh oh!

lsr911 commented Jun 27, 2026

Uh oh!

lsr911 commented Jun 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lsr911 commented Jun 21, 2026 •

edited

Loading

clawsweeper Bot commented Jun 21, 2026 •

edited

Loading

clawsweeper Bot commented Jun 26, 2026 •

edited

Loading

clawsweeper Bot commented Jun 26, 2026 •

edited

Loading