fix(tavily): allow env fallback for unresolved apiKey refs#95450
fix(tavily): allow env fallback for unresolved apiKey refs#95450arkyu2077 wants to merge 1 commit into
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close as superseded: this PR targets a real Tavily SecretRef fallback bug, but the branch is not a safe landing candidate and the same remaining work is already owned by the stronger open sibling at #95110. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Canonical path: Continue review on #95110, land one guarded Tavily-local inspect-mode resolver with exact-head proof, then close or retarget the sibling fallback PRs. So I’m closing this here and keeping the remaining discussion on #95110. Review detailsBest possible solution: Continue review on #95110, land one guarded Tavily-local inspect-mode resolver with exact-head proof, then close or retarget the sibling fallback PRs. Do we have a high-confidence way to reproduce the issue? Yes, at source level. Current main calls strict Tavily SecretRef normalization before the documented Is this the best way to solve the issue? No. The Tavily resolver is the right boundary, but this branch is not the best implementation because it uses an unsupported mode and discards the SecretRef metadata needed to guard ambient fallback. Security review: Security review needs attention: The diff introduces a concrete credential-boundary concern by allowing ambient env fallback after explicit unavailable SecretRefs.
AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against 78f7de01c1aa. |
Summary
process.env.TAVILY_API_KEYwhen the runtime snapshot has not inlined the ref yetTesting
Closes #95109