fix(os): use sw_vers for macOS version on Darwin instead of os.release() by sunlit-deng · Pull Request #95225 · openclaw/openclaw

sunlit-deng · 2026-06-20T04:39:47Z

What Problem This Solves

Fixes an issue where agents running on macOS 26 (Tahoe) could receive Darwin kernel metadata in their runtime prompt instead of the macOS product version, causing prompt context such as Darwin 25.x to describe the host incorrectly.

Why This Change Was Made

The runtime prompt OS helper now uses sw_vers -productVersion only on Darwin and keeps the historical ${os.type()} ${os.release()} shape on Linux and Windows. The Darwin runtime label is cached by the raw OS tuple, and resolveOsSummary().release remains the raw kernel release for status JSON and trajectory compatibility.

User Impact

macOS 26 users now get runtime prompt context like os=macOS 26.4 (arm64) instead of os=Darwin 25.4.0 (arm64), while Linux and Windows prompt labels stay unchanged.

Evidence

node scripts/run-vitest.mjs src/infra/os-summary.test.ts - 9 tests passed. Covers Darwin sw_vers product version, blank sw_vers fallback, Windows/Linux legacy output, raw resolveOsSummary().release, and cached Darwin runtime prompt lookup.
node scripts/run-vitest.mjs src/agents/system-prompt.test.ts src/agents/embedded-agent-runner/run/attempt-system-prompt.test.ts - 94 tests passed across the prompt renderer and embedded attempt prompt surface.
node scripts/run-oxlint.mjs src/infra/os-summary.ts src/infra/os-summary.test.ts src/agents/cli-runner/helpers.ts src/agents/embedded-agent-runner/compact.ts src/agents/embedded-agent-runner/run/attempt.ts - passed.
git diff --check - passed.

Live macOS proof from this branch's implementation:

uname -r: 25.4.0
sw_vers -productVersion: 26.4
node: v26.0.0
os.type/os.release/os.arch: Darwin 25.4.0 arm64
resolveRuntimeOsLabel(): macOS 26.4
resolveOsSummary(): {"platform":"darwin","arch":"arm64","release":"25.4.0","label":"macos 26.4 (arm64)"}
runtime line: Runtime: session=redacted | sessionId=redacted | host=redacted-host | os=macOS 26.4 (arm64) | node=v26.0.0 | model=redacted/provider | thinking=off

Observed result: on a real macOS 26.4 / Darwin 25.4.0 host, the runtime prompt renders os=macOS 26.4 (arm64) while resolveOsSummary().release remains the raw kernel release. Non-Darwin runtime labels preserve the previous ${os.type()} ${os.release()} shape, including Windows_NT ....

AI-assisted: built with Codex

clawsweeper · 2026-06-20T04:41:05Z

Codex review: needs maintainer review before merge. Reviewed June 29, 2026, 10:11 AM ET / 14:11 UTC.

Summary
The PR adds a shared runtime OS label helper that uses sw_vers -productVersion on Darwin, routes CLI/embedded/compaction runtime prompt metadata through it, and adds regression coverage for Darwin and non-Darwin label behavior.

PR surface: Source +34, Tests +79. Total +113 across 5 files.

Reproducibility: yes. Source inspection shows current main and v2026.6.10 pass raw os.release() into runtime prompt metadata, and the issue/PR proof provides Tahoe host facts where Darwin 25.x should render as macOS 26.x.

Review metrics: 2 noteworthy metrics.

Runtime Prompt Producers: 3 changed. CLI, embedded attempt, and embedded compaction all share this runtime OS invariant, so reviewers should confirm the helper covers every prompt path.
Darwin Subprocess Path: 1 cached helper added. Prompt construction now reaches a Darwin-only sw_vers subprocess path, making cache scope and non-Darwin preservation important before merge.

Stored data model
Persistent data-model change detected: persistent cache schema: src/infra/os-summary.ts. Confirm migration or upgrade compatibility proof before merge.

Root-cause cluster
Relationship: fixed_by_candidate
Canonical: #95145
Summary: This PR is one viable candidate fix for the canonical macOS Tahoe runtime prompt OS metadata issue; no fix has landed on current main, and several sibling PRs share the same root cause.

Members:

canonical: Bug: Darwin kernel version 25.x incorrectly mapped to macOS 15.x (should be macOS 26 / Tahoe) #95145 - The issue is the original report with macOS 26 / Darwin 25 host facts and expected runtime metadata behavior.
same_root_cause: fix(runtime-prompt): use macOS product version on Darwin (#95145) #95189 - Open mergeable PR with closing syntax and live macOS proof for the same runtime prompt OS metadata bug.
same_root_cause: fix(agent-core): bound harness exec stdout/stderr at 16 MiB #95195 - Open mergeable PR that routes the same prompt producers through a similar helper but remains proof-labeled.
same_root_cause: fix(agents): use macOS product version in runtime prompt OS metadata #95216 - Open mergeable PR found in live search that targets the same macOS product-version runtime prompt issue.
superseded: fix(infra): resolve macOS product version via sw_vers for runtime prompt #95158 - Closed unmerged earlier attempt at the same helper and runtime prompt routing change.
1 more in the report.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

none.

Risk before merge

[P1] Several open same-root PRs target the same canonical issue; maintainers should choose one branch to land and then close the remaining duplicates to avoid review churn and conflicting helper shapes.

Maintainer options:

Decide the mitigation before merge
Land one canonical runtime OS helper that uses sw_vers only for Darwin prompt metadata, preserves exact non-Darwin prompt output and raw summary release fields, then close the remaining duplicate candidate PRs.
Pause or close
Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

No automated repair is needed; maintainers should pick the canonical linked PR and let normal CI/mergeability gate that selected branch.

Security
Cleared: No concrete security or supply-chain concern was found; the diff adds no dependency/workflow changes and invokes a fixed local sw_vers command without a shell.

Review details

Best possible solution:

Land one canonical runtime OS helper that uses sw_vers only for Darwin prompt metadata, preserves exact non-Darwin prompt output and raw summary release fields, then close the remaining duplicate candidate PRs.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection shows current main and v2026.6.10 pass raw os.release() into runtime prompt metadata, and the issue/PR proof provides Tahoe host facts where Darwin 25.x should render as macOS 26.x.

Is this the best way to solve the issue?

Yes. This branch is a narrow maintainable fix: it centralizes the runtime prompt label helper, preserves non-Darwin output, keeps serialized summary release raw, and covers the invariants in focused tests.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against be94853de0d0.

Label changes

Label changes:

remove merge-risk: 🚨 compatibility: Current PR review selected no merge-risk labels.

Label justifications:

P2: This is a normal-priority agent runtime metadata bugfix with limited blast radius but real impact on macOS Tahoe prompt context.
rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body includes copied live macOS 26.4 after-fix output showing uname, sw_vers, resolveRuntimeOsLabel(), resolveOsSummary(), and the rendered runtime line with private host/session details redacted.
proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes copied live macOS 26.4 after-fix output showing uname, sw_vers, resolveRuntimeOsLabel(), resolveOsSummary(), and the rendered runtime line with private host/session details redacted.

Evidence reviewed

PR surface:

Source +34, Tests +79. Total +113 across 5 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	4	43	9	+34
Tests	1	80	1	+79
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	5	123	10	+113

What I checked:

Repository policy read: Root AGENTS.md was read fully; its PR review guidance applies because this touches agent runtime prompt behavior and requires caller/callee/sibling evidence before verdict. (AGENTS.md:9, be94853de0d0)
Scoped agent policy read: Scoped agent-runner guidance was read; it favors focused prompt/helper tests for runtime-context construction, matching this PR's helper-level coverage. (src/agents/embedded-agent-runner/run/AGENTS.md:7, be94853de0d0)
Current main still has raw Darwin prompt path: The embedded attempt runtime prompt still sets runtime.os from os.type() plus os.release(), which exposes Darwin 25.x on Tahoe hosts before rendering. (src/agents/embedded-agent-runner/run/attempt.ts:1928, be94853de0d0)
Renderer exposes caller-provided OS string: buildRuntimeLine() renders runtimeInfo.os and appends architecture, so caller-provided Darwin kernel metadata reaches model prompt context. (src/agents/system-prompt.ts:1404, be94853de0d0)
Latest release still ships old behavior: The latest release tag v2026.6.10 still contains the raw runtime prompt expression in the embedded attempt path, so no shipped release has this fix. (src/agents/embedded-agent-runner/run/attempt.ts:1936, aa69b12d0086)
PR head helper behavior: At PR head, resolveRuntimeOsLabel() returns macOS <productVersion> on Darwin and preserves the historical ${os.type()} ${release} shape off Darwin. (src/infra/os-summary.ts:35, 7eb118f2891b)

Likely related people:

steipete: Introduced runtime info into system prompts and later unified system prompt runtime params; also introduced the OS summary helper used by adjacent diagnostics/status behavior. (role: feature-history contributor; confidence: high; commits: f70fd30cd3b6, 55d034358d3c, 1eb50ffac476; files: src/agents/system-prompt.ts, src/agents/cli-runner/helpers.ts, src/agents/system-prompt-params.ts)
zhangguiping-xydt: Recent commit touched the same runtime prompt metadata construction and prompt tests while adding session identity to runtime prompts. (role: recent runtime prompt contributor; confidence: medium; commits: 78c66742ab97; files: src/agents/cli-runner/helpers.ts, src/agents/embedded-agent-runner/run/attempt.ts, src/agents/system-prompt.ts)
vincentkoc: Recent GitHub history shows repeated work in the CLI helper and embedded attempt runner areas that surround this prompt metadata path. (role: recent adjacent owner; confidence: medium; commits: 92d1f04de340, 7f6a93eb8efd, bda4404f695a; files: src/agents/cli-runner/helpers.ts, src/agents/embedded-agent-runner/run/attempt.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

…nel version Addresses ClawSweeper P1 findings on openclaw#95225: 1. Cache sw_vers output for process lifetime: resolveDarwinProductVersion() is called on the agent prompt hot path (3 callers via resolveOsProductLabel). Without caching, every prompt build spawns a synchronous subprocess. Added module-level cache + _resetCachedDarwinProductVersion() for tests. 2. Keep resolveOsSummary().release as os.release(): changing release from raw kernel to product version breaks status JSON and trajectory metadata consumers that expect the Darwin kernel release. The darwin product version is now used only in the label field.

…sion Addresses ClawSweeper P1 findings on openclaw#95225: 1. Cache sw_vers output for process lifetime: resolveDarwinProductVersion() is called on the agent prompt hot path (3 callers via resolveOsProductLabel). Without caching, every prompt build spawns a synchronous subprocess. Added module-level cache + _resetCachedDarwinProductVersion() for tests. 2. Keep resolveOsSummary().release as os.release(): changing release from raw kernel to product version breaks status JSON and trajectory metadata consumers that expect the Darwin kernel release. The darwin product version is now used only in the label field.

sunlit-deng · 2026-06-23T03:08:00Z

@clawsweeper re-review

clawsweeper · 2026-06-23T03:08:02Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

sunlit-deng · 2026-06-29T13:57:22Z

@clawsweeper re-review

clawsweeper · 2026-06-29T13:57:26Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

…e() (openclaw#95225) * fix(os): use sw_vers for macOS version on Darwin instead of os.release() * fix: cache sw_vers, keep resolveOsSummary().release as raw kernel version Addresses ClawSweeper P1 findings on openclaw#95225: 1. Cache sw_vers output for process lifetime: resolveDarwinProductVersion() is called on the agent prompt hot path (3 callers via resolveOsProductLabel). Without caching, every prompt build spawns a synchronous subprocess. Added module-level cache + _resetCachedDarwinProductVersion() for tests. 2. Keep resolveOsSummary().release as os.release(): changing release from raw kernel to product version breaks status JSON and trajectory metadata consumers that expect the Darwin kernel release. The darwin product version is now used only in the label field. * fix(os): preserve runtime OS labels off Darwin

fix(os): use sw_vers for macOS version on Darwin instead of os.release()

5631c9d

openclaw-barnacle Bot added agents Agent runtime and tooling size: XS labels Jun 20, 2026

github-actions Bot mentioned this pull request Jun 20, 2026

🦞 OpenClaw 生态日报 2026-06-20 litang9/big_model_radar#90

Open

clawsweeper Bot added the merge-risk: 🚨 compatibility 🚨 May break existing users, config, migrations, defaults, or upgrade paths. label Jun 21, 2026

openclaw-barnacle Bot added size: XL and removed size: XS labels Jun 23, 2026

sunlit-deng force-pushed the fix/issue-95145 branch from 26f7eb4 to 5631c9d Compare June 23, 2026 03:04

openclaw-barnacle Bot added size: XS and removed size: XL labels Jun 23, 2026

openclaw-barnacle Bot added size: S and removed size: XS labels Jun 23, 2026

clawsweeper Bot removed the merge-risk: 🚨 availability 🚨 May cause crashes, hangs, restart loops, stalls, or process outages. label Jun 23, 2026

brokemac79 mentioned this pull request Jun 25, 2026

[codex] Route PR close reviews to autoclose openclaw/clawsweeper#371

Merged

clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. labels Jun 28, 2026

fix(os): preserve runtime OS labels off Darwin

7eb118f

vincentkoc merged commit 825d9a6 into openclaw:main Jun 29, 2026
128 of 135 checks passed

github-actions Bot mentioned this pull request Jun 29, 2026

📡 Upstream Digest — 2026-06-29 16:52 UTC curtismercier/openclaw-mods#1174

Open

vincentkoc mentioned this pull request Jul 6, 2026

chore(jobs): prune resolved OpenClaw inbox jobs openclaw/clownfish#221

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(os): use sw_vers for macOS version on Darwin instead of os.release()#95225

fix(os): use sw_vers for macOS version on Darwin instead of os.release()#95225
vincentkoc merged 3 commits into
openclaw:mainfrom
sunlit-deng:fix/issue-95145

sunlit-deng commented Jun 20, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jun 20, 2026 •

edited

Loading

Uh oh!

sunlit-deng commented Jun 23, 2026

Uh oh!

clawsweeper Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

sunlit-deng commented Jun 29, 2026

Uh oh!

clawsweeper Bot commented Jun 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

sunlit-deng commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Problem This Solves

Why This Change Was Made

User Impact

Evidence

Uh oh!

clawsweeper Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sunlit-deng commented Jun 23, 2026

Uh oh!

clawsweeper Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sunlit-deng commented Jun 29, 2026

Uh oh!

clawsweeper Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sunlit-deng commented Jun 20, 2026 •

edited

Loading

clawsweeper Bot commented Jun 20, 2026 •

edited

Loading

clawsweeper Bot commented Jun 23, 2026 •

edited

Loading

clawsweeper Bot commented Jun 29, 2026 •

edited

Loading