Skip to content

refactor(skills): trim bundled starter set#95132

Draft
fuller-stack-dev wants to merge 48 commits into
openclaw:mainfrom
fuller-stack-dev:codex/clawhub-skill-cleanup
Draft

refactor(skills): trim bundled starter set#95132
fuller-stack-dev wants to merge 48 commits into
openclaw:mainfrom
fuller-stack-dev:codex/clawhub-skill-cleanup

Conversation

@fuller-stack-dev

@fuller-stack-dev fuller-stack-dev commented Jun 19, 2026

Copy link
Copy Markdown
Member

Summary

  • stacked on refactor(plugins): move owner skills into plugins #95664, which now owns the Canvas, Discord, Slack, voice-call, and WhatsApp skill relocation
  • reduce the core-bundled starter set from 57 skill directories to 14:
    clawhub, diagram-maker, gifgrep, gog, healthcheck, mcporter,
    model-usage, node-connect, peekaboo, skill-creator, songsee,
    spotify-player, summarize, and weather
  • publish Sherpa ONNX TTS as the official external ClawHub-only plugin
    @openclaw/sherpa-onnx-tts, register its trusted official catalog entry, and
    support bare-ID install resolution for ClawHub-only official plugins
  • remove 37 optional skills from core, clean up the retained ClawHub skill to
    use native openclaw skills discovery/install commands, and update affected
    docs, generated plugin inventory, packaging, and obsolete tests

The root skills/ directory and bundled-skill loading/configuration remain in
place. There are no system-prompt changes.

Removed from core:

1password, apple-notes, apple-reminders, bear-notes, blogwatcher,
blucli, camsnap, coding-agent, eightctl, gemini, gh-issues,
github, goplaces, himalaya, imsg, meme-maker, nano-pdf,
node-inspect-debugger, notion, obsidian, openai-whisper,
openai-whisper-api, openhue, oracle, ordercli, python-debugpy, sag,
session-logs, sonoscli, spike, taskflow, taskflow-inbox-triage,
things-mac, tmux, trello, video-frames, and xurl.

Verification

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation channel: discord Channel integration: discord channel: slack Channel integration: slack channel: voice-call Channel integration: voice-call channel: whatsapp-web Channel integration: whatsapp-web size: XL maintainer Maintainer-authored PR labels Jun 19, 2026
@clawsweeper

clawsweeper Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Codex review: found issues before merge. Reviewed July 15, 2026, 12:52 AM ET / 04:52 UTC.

Summary
The PR reduces the bundled starter skills, externalizes Sherpa ONNX TTS as an official ClawHub-only plugin, and updates installation routing, packaging, documentation, dependencies, and tests.

Reproducibility: not applicable. this is a packaging, installation, and product-boundary change rather than a report of broken current behavior.

Review metrics: 3 noteworthy metrics.

  • Bundled skill surface: 37 removed, 14 retained, 1 externalized. This quantifies the upgrade-sensitive capability change that requires migration and availability proof.
  • Official install source: 1 ClawHub-only official route added. Bare-ID installation now crosses a new official package trust and fallback boundary.
  • Dependency surfaces: 1 package manifest and 1 lockfile importer added. Both require current-head supply-chain authorization before release.

Stored data model
Persistent data-model change detected: persistent cache schema: skills/openai-whisper/SKILL.md, serialized state: skills/session-logs/SKILL.md, serialized state: skills/taskflow/SKILL.md, serialized state: src/skills/loading/bundled-frontmatter.test.ts, unknown-data-model-change: skills/session-logs/SKILL.md, unknown-truncated-pull-files, and 18 more. Confirm migration or upgrade compatibility proof before merge.

Root-cause cluster
Relationship: canonical
Canonical: #95132
Summary: This PR is the canonical remaining bundled-skill deprecation and Sherpa packaging decision after narrower safe slices landed separately.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge readiness
Overall: 🦐 gold shrimp
Proof: 🌊 off-meta tidepool
Patch quality: 🦐 gold shrimp
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • [P2] Add and prove a doctor migration for existing bundled-skill references and destinations.
  • Provide current-head dependency authorization and real install/upgrade proof for the Sherpa ClawHub package and native artifacts.

Risk before merge

  • [P1] Existing users can lose previously bundled capabilities after upgrade while their skills.allowBundled, skills.entries, workspace instructions, or automation still references removed skill names; the PR currently offers manual recovery rather than a doctor migration.
  • [P1] The current head changes the dependency graph through a new package manifest and lockfile importer, and the earlier dependency authorization was tied to a different head SHA.
  • [P1] Sherpa becomes an officially trusted ClawHub-only package whose skill downloads native executables and model archives, so release owners must accept package availability, provenance, integrity, and support behavior before merge.

Maintainer options:

  1. Add migration and release proof (recommended)
    Implement and test doctor migration for shipped references, verify removed packages and Sherpa through real install and upgrade scenarios, and authorize the current dependency graph before merge.
  2. Accept a documented breaking release
    Maintainers may intentionally accept the removals and new trust route, but must own release notes, support handling, package availability, and artifact provenance.
  3. Split or pause the draft
    Extract any independently desired Sherpa work and pause or close the broad skill trim if the migration and deprecation commitment is not ready.

Next step before merge

  • [P2] A maintainer must first choose the deprecation and official-package trust direction; after that choice, the branch needs migration and release proof rather than an unsupervised mechanical repair.

Maintainer decision needed

  • Question: Should this release remove the listed shipped root skills and designate Sherpa ONNX TTS as an official ClawHub-only plugin?
  • Rationale: Code review cannot choose whether existing users should absorb this compatibility break or whether the new official package and native-download trust boundary is an accepted product commitment.
  • Likely owner: vincentkoc — He authored the merged precursor slices and explicitly defined the remaining decision surface in this PR discussion.
  • Options:
    • Migrate, prove, then land (recommended): Keep the combined direction, but require doctor migration, fresh-install and upgrade proof, current-head dependency authorization, and Sherpa package/artifact verification before merge.
    • Split Sherpa packaging: Move the Sherpa official-plugin work into a focused PR and defer the broader bundled-skill deprecation until its migration plan is ready.
    • Park the broad trim: Retain the current bundled set and close or pause this draft until a release-owned deprecation policy is sponsored.

Security
Needs attention: No malicious behavior is evident, but the new official package trust route, native artifact downloads, and current-head dependency graph require explicit release/security acceptance.

Review findings

  • [P1] Add an upgrade migration before removing shipped skills — docs/help/faq.md:298-302
Review details

Best possible solution:

Split or land the work only after adding a tested openclaw doctor --fix migration for shipped skill references, confirming every removed capability has an available documented ClawHub destination, and obtaining release/security approval for Sherpa’s official package and native artifacts.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this is a packaging, installation, and product-boundary change rather than a report of broken current behavior.

Is this the best way to solve the issue?

No, not in its current form: the lean-core direction is plausible, but removing shipped skills without doctor migration and accepted release trust proof is not the safest upgrade path.

Full review comments:

  • [P1] Add an upgrade migration before removing shipped skills — docs/help/faq.md:298-302
    The new guidance only tells users to manually install replacements after their config names a removed bundled skill. Because these names shipped and may remain in skills.allowBundled, skills.entries, workspace instructions, or automations, the removal needs a tested openclaw doctor --fix migration and verified destinations rather than first failing at runtime after upgrade. This is the same unresolved blocker from the prior review; the current head SHA has not changed.
    Confidence: 0.97

Overall correctness: patch is incorrect
Overall confidence: 0.96

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 4a9a556a3a14.

Label changes

Label justifications:

  • P2: This is a broad, non-emergency product refactor with substantial but deliberate compatibility and trust implications.
  • merge-risk: 🚨 compatibility: Removing shipped bundled skills can break existing config, workspace instructions, and automations unless an upgrade migration and package destinations are proven.
  • merge-risk: 🚨 security-boundary: The PR changes official package trust routing and introduces native runtime and model downloads plus dependency-graph changes.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🌊 off-meta tidepool and patch quality is 🦐 gold shrimp.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action. Not applicable: The external-contributor proof gate does not apply because this is member-authored and maintainer-labeled; the supplied tests and Crabbox evidence remain supplemental to the unresolved migration and release decisions.
Evidence reviewed

Security concerns:

  • [medium] Authorize the current dependency graph — pnpm-lock.yaml:1509
    The new Sherpa package manifest and lockfile importer change the resolved dependency graph; authorization recorded for an earlier SHA does not automatically approve the current head.
    Confidence: 0.96
  • [medium] Verify official native artifact provenance — extensions/sherpa-onnx-tts/skills/sherpa-onnx-tts/SKILL.md:16
    The official Sherpa skill downloads executable runtime archives and a voice model from external release locations, so release owners should verify provenance, integrity expectations, and update handling before treating the package as official.
    Confidence: 0.88

What I checked:

  • Current main behavior: Current main still loads skills from the root bundled-skills directory, so the central starter-set removal is not already implemented or superseded. (src/skills/loading/workspace.ts:1173, 4a9a556a3a14)
  • Unresolved upgrade path: The changed FAQ tells users with removed bundled-skill references to manually install an owner-qualified ClawHub package; it does not provide the repository-required doctor migration for previously shipped config references. Public docs: docs/help/faq.md. (docs/help/faq.md:298, b836394b3781)
  • Re-review continuity: The current head is the same b836394 commit reviewed in the previous completed cycle, so the existing P1 migration finding remains unresolved; the later draft conversion did not change code. (b836394b3781)
  • Product decision acknowledged in discussion: A member explicitly described the remaining branch as not merge-ready unless maintainers decide to deprecate bundled skills and ship Sherpa through this external-plugin route. (13b059c7cf2d)
  • Official install routing change: The branch adds a ClawHub source variant for official external install plans and routes bare official plugin IDs through that source before bundled or npm fallback. (src/plugins/official-external-install-trust.ts:53, b836394b3781)
  • Dependency and artifact trust surface: The branch adds an official package manifest and lockfile importer while the Sherpa skill downloads native runtime and model archives; current-head authorization and artifact trust acceptance remain required. (extensions/sherpa-onnx-tts/package.json:1, b836394b3781)

Likely related people:

  • vincentkoc: Authored both merged split PRs, is assigned to this PR, and documented the boundary between landed mechanical work and the remaining product decision. (role: recent area contributor and likely decision owner; confidence: high; commits: 674b4f337241, 4e9dc6b5d5c4; files: extensions/*/openclaw.plugin.json, skills/clawhub/SKILL.md, src/cli/skills-cli.ts)
  • steipete: History connects this contributor to the bundled Sherpa skill and the plugin-install and ClawHub fallback policy changed by the branch. (role: feature introducer and adjacent install-path contributor; confidence: high; commits: 458850483a45, 2363e1b0853a, 5696e24c3fba; files: skills/sherpa-onnx-tts/SKILL.md, skills/sherpa-onnx-tts/bin/sherpa-onnx-tts, src/cli/plugins-install-command.ts)
  • shakkernerd: Recent merged work updated Sherpa and related skill environment-path guidance that this PR relocates into the external plugin. (role: recent adjacent skill contributor; confidence: medium; commits: ab141df4b527, a3de1f5f55d1; files: skills/sherpa-onnx-tts/SKILL.md, src/skills/loading/env-path-guidance.test.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (39 earlier review cycles; latest 8 shown)
  • reviewed 2026-07-14T23:11:32.892Z sha c81beca :: found issues before merge. :: [P1] Migrate shipped skill references before removing bundles
  • reviewed 2026-07-14T23:43:09.014Z sha b836394 :: found issues before merge. :: [P1] Migrate shipped skill references before removing bundles
  • reviewed 2026-07-15T00:02:04.092Z sha b836394 :: found issues before merge. :: [P1] Migrate shipped skill references before removing bundles
  • reviewed 2026-07-15T00:15:13.387Z sha b836394 :: found issues before merge. :: [P1] Migrate shipped skill references before removing bundles
  • reviewed 2026-07-15T00:42:48.289Z sha b836394 :: found issues before merge. :: [P1] Migrate shipped skill references before removing bundles
  • reviewed 2026-07-15T01:20:08.356Z sha b836394 :: found issues before merge. :: [P1] Migrate shipped skill references before removing bundles
  • reviewed 2026-07-15T02:34:28.901Z sha b836394 :: found issues before merge. :: [P1] Migrate shipped skill references before removing bundles
  • reviewed 2026-07-15T03:42:57.330Z sha b836394 :: found issues before merge. :: [P1] Migrate shipped skill references before removing bundles

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P2 Normal backlog priority with limited blast radius. merge-risk: 🚨 compatibility 🚨 May break existing users, config, migrations, defaults, or upgrade paths. labels Jun 20, 2026
@fuller-stack-dev
fuller-stack-dev force-pushed the codex/clawhub-skill-cleanup branch from bed4e9b to bddf59d Compare June 20, 2026 01:50
@fuller-stack-dev
fuller-stack-dev requested a review from a team as a code owner June 20, 2026 01:50
@openclaw-barnacle openclaw-barnacle Bot added gateway Gateway runtime cli CLI command changes scripts Repository scripts labels Jun 20, 2026
@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Dependency Guard

This PR changes dependency-related files. Maintainers should confirm these changes are intentional.

Changed files:

  • extensions/sherpa-onnx-tts/package.json
  • pnpm-lock.yaml

Maintainer follow-up:

  • Review whether the dependency changes are intentional.
  • Inspect resolved package deltas when lockfile, shrinkwrap, or workspace dependency policy changes are present.
  • Treat package-lock.json and npm-shrinkwrap.json diffs as security-review surfaces.
  • Run pnpm deps:changes:report -- --base-ref origin/main --markdown /tmp/dependency-changes.md --json /tmp/dependency-changes.json locally for detailed release-style evidence.

@github-actions github-actions Bot added the dependencies-changed PR changes dependency-related files label Jun 20, 2026
@github-actions

github-actions Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Dependency graph changes are blocked

OpenClaw does not accept dependency graph changes through PRs unless a repository admin or security explicitly authorizes the current head SHA. Dependency updates are generated internally by maintainers so external PRs cannot change the resolved graph.

Detected dependency graph changes:

  • pnpm-lock.yaml changed.
  • extensions/sherpa-onnx-tts/package.json changed devDependencies, name, version.

Auto-scrub was not attempted because this PR changes package manifest dependency graph fields:

  • extensions/sherpa-onnx-tts/package.json changed devDependencies, name, version.

Dependency graph changes must be reviewed by security or handled by maintainers internally. Please remove lockfile changes manually if they are not needed.

To remove lockfile changes, restore them from the target branch:

git fetch origin
git checkout 'origin/main' -- 'pnpm-lock.yaml'
git commit -m 'chore: remove dependency lockfile change'
git push

If this PR intentionally needs a dependency graph change, ask a repository admin or member of @openclaw/openclaw-secops to comment:

/allow-dependencies-change

The action will approve the current head SHA (b836394b3781a2634169832cfa24ae67e26f2e8d) when it reruns. A later push requires a fresh approval.

@fuller-stack-dev fuller-stack-dev added the extensions: sherpa-onnx-tts Sherpa ONNX TTS plugin label Jun 20, 2026
@clawsweeper clawsweeper Bot added proof: sufficient ClawSweeper judged the real behavior proof convincing. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. merge-risk: 🚨 security-boundary 🚨 May affect sandboxing, authorization, credentials, or sensitive data. and removed rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Jun 20, 2026
@fuller-stack-dev fuller-stack-dev self-assigned this Jun 20, 2026
@fuller-stack-dev
fuller-stack-dev force-pushed the codex/clawhub-skill-cleanup branch from bddf59d to ee37653 Compare June 20, 2026 02:23
@clawsweeper clawsweeper Bot removed the status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. label Jun 20, 2026
@fuller-stack-dev

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

@fuller-stack-dev

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

@fuller-stack-dev

Copy link
Copy Markdown
Member Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

@clawsweeper

clawsweeper Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: refactor(skills): trim bundled starter set This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app: macos App: macos cli CLI command changes dependencies-changed PR changes dependency-related files docs Improvements or additions to documentation extensions: sherpa-onnx-tts Sherpa ONNX TTS plugin gateway Gateway runtime maintainer Maintainer-authored PR merge-risk: 🚨 compatibility 🚨 May break existing users, config, migrations, defaults, or upgrade paths. merge-risk: 🚨 security-boundary 🚨 May affect sandboxing, authorization, credentials, or sensitive data. P2 Normal backlog priority with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. scripts Repository scripts size: XL status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants