fix(test): stream QA Lab stdout artifacts#95119
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 7:11 PM ET / 23:11 UTC. Summary PR surface: Tests +87. Total +87 across 2 files. Reproducibility: yes. from source, not from a live failing run: current main reads the full fallback Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the chunked fallback reader after the maintainer draft is ready and the focused QA OTEL smoke test or equivalent CI/Testbox proof passes. Do we have a high-confidence way to reproduce the issue? Yes from source, not from a live failing run: current main reads the full fallback Is this the best way to solve the issue? Yes, this looks like the narrow best fix for the test harness: it preserves the existing stdout diagnostic capture/parser contract and changes only fallback artifact ingestion. Changing the scenario YAML or child stdout listener would not address the whole-file fallback read. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 21c966616f61. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +87. Total +87 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Land-ready proof for
Local targeted Vitest was not run in this Codex worktree because |
* fix(test): bound QA Lab stdout artifact reads * fix(test): scan QA Lab stdout artifacts incrementally
* fix(test): bound QA Lab stdout artifact reads * fix(test): scan QA Lab stdout artifacts incrementally
Summary
gateway.stdout.logparsing through the bounded stdout diagnostic capture instead of reading the whole artifact into memoryVerification
node --check --experimental-strip-types test/e2e/qa-lab/runtime/qa-otel-smoke-runtime.tsnode --check --experimental-strip-types test/e2e/qa-lab/runtime/qa-otel-smoke.e2e.test.tsgit diff --checknode scripts/run-vitest.mjs test/e2e/qa-lab/runtime/qa-otel-smoke.e2e.test.tswas not run locally because this Codex worktree has nonode_modulesand exits withOPENCLAW_MISSING_VITEST; dependencies were intentionally not installed in the Codex worktree.