fix(memory): abort batch upload response reads#95111
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 6:15 PM ET / 22:15 UTC. Summary PR surface: Source +3, Tests +79. Total +82 across 2 files. Reproducibility: yes. at the helper level from source inspection: current main has abort-aware response readers, but Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Keep the helper-level abort propagation if that is the intended scope, and wire a real provider batch cancellation signal in this PR or a follow-up if maintainers want end-to-end batch timeout/cancel behavior. Do we have a high-confidence way to reproduce the issue? Yes at the helper level from source inspection: current main has abort-aware response readers, but Is this the best way to solve the issue? Yes for the helper-level bug: forwarding the caller signal through guarded fetch and both response readers matches the existing AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against aa479ac7d8f7. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +3, Tests +79. Total +82 across 2 files. View PR surface stats
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Land-ready proof for
The first exact-head gate Local targeted Vitest was not run in this Codex worktree because |
* fix(memory): abort batch upload response reads * test(memory): stabilize batch upload abort proof
* fix(memory): abort batch upload response reads * test(memory): stabilize batch upload abort proof
Summary
uploadBatchJsonlFile.Verification
node --check --experimental-strip-types packages/memory-host-sdk/src/host/batch-upload.tsnode --check --experimental-strip-types packages/memory-host-sdk/src/host/batch-upload.test.tsgit diff --checkProof gaps
node scripts/run-vitest.mjs packages/memory-host-sdk/src/host/batch-upload.test.tsis blocked in this Codex worktree becausenode_modulesis absent (OPENCLAW_MISSING_VITEST); dependencies were not installed in the Codex worktree.