feat(android): show cron job details#95107
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 6, 2026, 1:10 AM ET / 05:10 UTC. Summary PR surface: Docs +2, Other +743. Total +745 across 7 files. Reproducibility: not applicable. as a bug reproduction; this is a feature PR. Current main is list-only, and the inspected emulator screenshots show the after-change list, detail, copy, and system-back flows. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land the app-layer read-only detail view after Android/product acceptance and green CI, keeping it on existing cron.get without new protocol, auth, or config surface. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a feature PR. Current main is list-only, and the inspected emulator screenshots show the after-change list, detail, copy, and system-back flows. Is this the best way to solve the issue? Yes, if Android product direction is accepted: using the existing cron.get RPC from Android runtime code is the narrow maintainable path. The safer alternative is to narrow which detail fields are shown if mobile cron payload/error visibility is not desired. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against d5371395218c. Label changesLabel justifications:
Evidence reviewedPR surface: Docs +2, Other +743. Total +745 across 7 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
clawsweeper
Bot
added
proof: sufficient
61a93c8 to
e133964
Compare
|
Ready for Android review, @obviyus. This is intentionally Android-only and read-only: Cron Jobs list rows now open a detail view through the existing cron.get RPC, the cron ID can be copied, Android system back returns to the Cron Jobs list, and stale cron.get responses are guarded. No gateway/protocol/edit/scope changes in this PR. |
e133964 to
330adba
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
clawsweeper
Bot
added
the
merge-risk: 🚨 other
330adba to
d3b24c2
Compare
d3b24c2 to
4b387e2
Compare
4b387e2 to
e5906d0
Compare
|
Land-ready maintainer rewrite completed.
Contributor emulator evidence covers list, detail, copy-id, and system-back behavior. Source-blind interactive refresh/disconnect/race probes were unavailable; the focused unit tests cover those state transitions. |
* feat(android): add cron job detail view * fix(android): harden cron job detail loading * chore(android): refresh native i18n inventory * test(plugins): register workboard typed hook --------- Co-authored-by: Peter Steinberger <[email protected]>
* feat(android): add cron job detail view * fix(android): harden cron job detail loading * chore(android): refresh native i18n inventory * test(plugins): register workboard typed hook --------- Co-authored-by: Peter Steinberger <[email protected]>
2 participants
No linked issue. This is a narrow Android settings usability improvement.
What Problem This Solves
Android users could see the Cron Jobs settings summary and list, but tapping a cron job did not open the job itself. That made it hard to inspect the schedule, payload, delivery state, or copy the job id when discussing a cron job in chat or support.
Why This Change Was Made
This adds an Android-only cron job detail view that uses the existing
cron.getgateway method. The view stays read-only: it does not add cron editing, new gateway methods, protocol changes, auth scopes, or command actions.The cron job id row is now copyable, with a copy affordance and a toast, so users can quickly reference the exact job id elsewhere.
User Impact
Users can now open
Settings > Cron Jobs, tap a scheduled job, inspect the gateway-provided details, copy the cron job id, refresh the detail view, and use either the toolbar back button or Android system back to return to the Cron Jobs list.Evidence
Redacted local Android emulator proof against a running OpenClaw gateway:
cron.getdetail view. Private title/id are redacted.Tap to copy; Android clipboard preview is redacted.Validation run after rebasing onto current
upstream/main:All four checks passed.
Additional note:
:app:ktlintMainSourceSetCheckwas attempted, but it is currently blocked by pre-existing unrelated ktlint violations inChatController.ktandChatScreen.ktthat are outside this Android cron detail patch.AI-assisted: implemented and validated with Codex, then manually inspected and tested in a local Android/OpenClaw setup.