fix(telegram): deliver reasoning lane under /reasoning on#95040
fix(telegram): deliver reasoning lane under /reasoning on#95040wendy-chsy wants to merge 1 commit into
Conversation
Reasoning blocks from the reply pipeline carry isReasoning=true and are suppressed by normalizeDeliveryPayload via shouldSuppressReasoningPayload. Deliver them through the reasoning lane before the normalizer runs, so thinking persists as messages when /reasoning on is active (/reasoning stream worked because ephemeral streaming bypassed this path). Fixes openclaw#94937 Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
Thanks for the context here. I did a careful shell check against current Current main already contains the fuller Telegram durable-reasoning fix from the merged canonical PR, including shared-dispatch opt-in, Telegram marker stripping before outbound normalization, and regression coverage, so this narrower branch is no longer necessary. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. So I’m closing this as already implemented rather than keeping a duplicate issue open. Review detailsBest possible solution: Keep the merged current-main fix from #97875 as the canonical implementation and close this narrower partial branch. Do we have a high-confidence way to reproduce the issue? Yes. The linked issue provided concrete Is this the best way to solve the issue? No for this branch. The current-main fix is the better solution because it passes reasoning through shared dispatch with an explicit opt-in, strips the marker only before Telegram normalization, preserves generic-channel suppression, and adds focused tests. Security review: Security review cleared: The PR diff only changes Telegram TypeScript dispatch logic and does not touch secrets, dependencies, workflows, package metadata, generated artifacts, or install/build execution paths. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against eb417fa206e6; fix evidence: commit 455f813d6ee6, main fix timestamp 2026-06-30T00:31:06Z. |
|
@openclaw-mantis telegram desktop proof: verify /reasoning on shows a durable Thinking message and final answer without duplication. This is a follow-up to the ClawSweeper/Codex review request for real behavior proof (#95040 (comment)). The contributor does not have a live Telegram bot environment. Requesting Mantis to capture real Telegram proof:
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Proof ReportChange SummaryThis PR adds an early-return path in Unit Test ResultsAll 4 related Telegram test suites pass on commit
Test EvidenceRegression Check
Code AnalysisThe fix correctly:
Surface Changes
Live Proof GapLive Telegram end-to-end verification with a real reasoning model response still requires a Telegram bot token + running OpenClaw instance with a reasoning model provider. The Proof generated on commit |
Build ConfirmationFull |
|
ClawSweeper applied the proposed close for this PR.
|
Summary
Linked issue
Closes #94937
Real behavior proof
Tests and validation
' pnpm test extensions/telegram/src/bot-message-dispatch.test.ts -> 129 passed pnpm test extensions/telegram/src/reasoning-lane-coordinator.test.ts -> 5 passed pnpm test extensions/telegram/src/lane-delivery.test.ts -> 41 passed pnpm test extensions/telegram/src/send.test.ts -> 132 passed pnpm build -> clean'Risk checklist
AI-assisted code generation used for this fix.