fix(discord): deliver reasoning replies#95029
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 1:15 PM ET / 17:15 UTC. Summary PR surface: Source -12, Tests +20. Total +8 across 5 files. Reproducibility: yes. source-level: current main emits opted-in reasoning payloads but Discord suppresses Review metrics: 1 noteworthy metric.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this Discord-boundary fix after current-head validation, keeping the shared reasoning formatter and marker-clearing behavior as the canonical path. Do we have a high-confidence way to reproduce the issue? Yes, source-level: current main emits opted-in reasoning payloads but Discord suppresses Is this the best way to solve the issue? Yes, the latest PR head is at the right Discord delivery boundary: it removes the Discord-only drop guards, reuses the shared formatter, and clears the internal marker before durable outbound send. Current-head validation remains the main merge-readiness gap. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 38807ffba4b2. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source -12, Tests +20. Total +8 across 5 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
64efcfb to
3441631
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
3441631 to
29f657d
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Land-ready proof for the current head
Known gap: PR CI early gates are currently queued, not failing. Auto-merge should wait for required checks rather than bypassing them. |
Summary:
isReasoningblock/final payloads instead of dropping them in the message delivery hooks.formatReasoningMessagehelper and clear the internalisReasoningmarker before shared durable outbound delivery.Verification:
git diff --checkpnpm dlx [email protected] --check --threads=1 extensions/discord/src/monitor/message-handler.process.ts extensions/discord/src/monitor/message-handler.process.test.ts extensions/discord/src/monitor/message-handler.process.abort-skip.test.ts extensions/discord/src/monitor/reply-delivery.ts extensions/discord/src/monitor/reply-delivery.test.tstbx_01kvgdjkney55xkbmqbr8v9m1x, runhttps://github.com/openclaw/openclaw/actions/runs/27838962847:corepack pnpm test:serial extensions/discord/src/monitor/message-handler.process.test.ts extensions/discord/src/monitor/reply-delivery.test.ts src/infra/outbound/payloads.test.ts src/agents/embedded-agent-subscribe.subscribe-embedded-agent-session.emits-reasoning-as-separate-message-enabled.test.tspassed. Shards: outbound payloads 36 tests; agent reasoning 8 tests; Discord handler/delivery 124 tests.Fixes #94936