fix: preserve copy-safe doctor paths in note boxes#94744
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close: this PR is superseded by an open, clean, proof-sufficient sibling PR with the same terminal-core diff and maintainer automerge signal; this branch adds no unique implementation and still lacks its own real behavior proof. Canonical path: Land #94746 if maintainers accept the fix, and keep only one implementation path for #94730. So I’m closing this here and keeping the remaining discussion on #94746 and #94730. Review detailsBest possible solution: Land #94746 if maintainers accept the fix, and keep only one implementation path for #94730. Do we have a high-confidence way to reproduce the issue? Yes for source-level reproduction: current main routes session-lock paths through note(), and pinned Clack 1.4.0 hard-wraps final note content from getColumns(output) - 6. I did not run a live openclaw doctor scenario in this read-only review. Is this the best way to solve the issue? The code shape is acceptable, but this PR is not the best landing path because #94746 has the same diff plus sufficient proof and maintainer automerge signal. A session-lock-only workaround would be worse than the shared terminal-core fix both branches propose. Security review: Security review cleared: Cleared: the diff only changes terminal note width calculation and a Vitest regression test, with no dependency, workflow, secret, network, package, or install-script change. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against ca6d52e0e8c1. |
|
ClawSweeper applied the proposed close for this PR.
|
Summary
.jsonl.lockmid-tokenTesting
Fixes #94730