Skip to content

test(scripts): fix test-projects baseline for temp-dir helper importers#94681

Merged
RomneyDa merged 1 commit into
mainfrom
fix/test-projects-baseline
Jun 18, 2026
Merged

test(scripts): fix test-projects baseline for temp-dir helper importers#94681
RomneyDa merged 1 commit into
mainfrom
fix/test-projects-baseline

Conversation

@RomneyDa

Copy link
Copy Markdown
Member

Summary

src/scripts/test-projects.test.ts ("routes top-level test helpers to importing repo tests") is failing on main: changing test/helpers/temp-dir.ts now routes two tests that the hardcoded expected baseline did not list.

Both files directly import the helper:

  • src/proxy-capture/store.sqlite.test.tsimport { cleanupTempDirs, makeTempDir } from "../../test/helpers/temp-dir.js" → routes to vitest.unit-fast.config.ts
  • src/commands/status.scan.shared.test.ts → same import → routes to vitest.commands.config.ts

So buildVitestRunPlans(["test/helpers/temp-dir.ts"]) correctly includes them; the test's expected snapshot was just stale. This updates the baseline to match the (correct) discovery output — no routing-logic change.

The expected values were captured directly from buildVitestRunPlans output, not hand-written.

Why this is not a silencing change

The actual routing is correct: both test files genuinely import test/helpers/temp-dir.ts and match their respective config globs (unit-fast default for src/**.test.ts, commands for src/commands/**). The expected list simply hadn't been updated when those importers were added.

Verification

  • node scripts/run-vitest.mjs src/scripts/test-projects.test.ts → 82 passed (was 1 failed before this change)
  • Reproduced the failure first on a clean origin/main checkout to confirm it is a main breakage, not PR-specific
  • oxlint --tsconfig config/tsconfig/oxlint.core.json src/scripts/test-projects.test.ts → clean
  • oxfmt --check → clean
  • git diff --check → clean

@openclaw-barnacle openclaw-barnacle Bot added size: XS maintainer Maintainer-authored PR labels Jun 18, 2026
@clawsweeper

clawsweeper Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: test(scripts): fix test-projects baseline for temp-dir helper importers This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@RomneyDa
RomneyDa merged commit dfd8a22 into main Jun 18, 2026
182 of 184 checks passed
@RomneyDa
RomneyDa deleted the fix/test-projects-baseline branch June 18, 2026 20:15
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jun 19, 2026
cxbAsDev pushed a commit to cxbAsDev/openclaw that referenced this pull request Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer Maintainer-authored PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant