test(scripts): fix test-projects baseline for temp-dir helper importers#94681
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: test(scripts): fix test-projects baseline for temp-dir helper importers This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jun 19, 2026
cxbAsDev
pushed a commit
to cxbAsDev/openclaw
that referenced
this pull request
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/scripts/test-projects.test.ts("routes top-level test helpers to importing repo tests") is failing onmain: changingtest/helpers/temp-dir.tsnow routes two tests that the hardcoded expected baseline did not list.Both files directly import the helper:
src/proxy-capture/store.sqlite.test.ts→import { cleanupTempDirs, makeTempDir } from "../../test/helpers/temp-dir.js"→ routes tovitest.unit-fast.config.tssrc/commands/status.scan.shared.test.ts→ same import → routes tovitest.commands.config.tsSo
buildVitestRunPlans(["test/helpers/temp-dir.ts"])correctly includes them; the test's expected snapshot was just stale. This updates the baseline to match the (correct) discovery output — no routing-logic change.The expected values were captured directly from
buildVitestRunPlansoutput, not hand-written.Why this is not a silencing change
The actual routing is correct: both test files genuinely import
test/helpers/temp-dir.tsand match their respective config globs (unit-fastdefault forsrc/**.test.ts,commandsforsrc/commands/**). The expected list simply hadn't been updated when those importers were added.Verification
node scripts/run-vitest.mjs src/scripts/test-projects.test.ts→ 82 passed (was 1 failed before this change)origin/maincheckout to confirm it is amainbreakage, not PR-specificoxlint --tsconfig config/tsconfig/oxlint.core.json src/scripts/test-projects.test.ts→ cleanoxfmt --check→ cleangit diff --check→ clean