Skip to content

test(sqlite): use shared temp directory helper#94658

Merged
vincentkoc merged 1 commit into
mainfrom
fix/sqlite-temp-dir-helper-20260618
Jun 18, 2026
Merged

test(sqlite): use shared temp directory helper#94658
vincentkoc merged 1 commit into
mainfrom
fix/sqlite-temp-dir-helper-20260618

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

Summary

  • replace raw test temp-directory creation with test/helpers/temp-dir.ts
  • centralize cleanup for the affected status and proxy SQLite tests
  • clear the check-guards temp-directory warnings

Validation

  • node scripts/report-test-temp-creations.mjs --base origin/main --head HEAD --fail-on-findings
  • pnpm test:serial src/commands/status.scan.shared.test.ts src/proxy-capture/store.sqlite.test.ts (Testbox, 25 tests)
  • .agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main

Real behavior proof

  • test-only cleanup; no runtime behavior changed
  • Testbox warning reporter returned no findings and both affected SQLite test suites passed

@vincentkoc vincentkoc self-assigned this Jun 18, 2026
@openclaw-barnacle openclaw-barnacle Bot added commands Command implementations size: S maintainer Maintainer-authored PR labels Jun 18, 2026
@clawsweeper

clawsweeper Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: test(sqlite): use shared temp directory helper This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc
vincentkoc marked this pull request as ready for review June 18, 2026 17:27
@vincentkoc
vincentkoc merged commit 2c7fe6a into main Jun 18, 2026
90 of 94 checks passed
@vincentkoc
vincentkoc deleted the fix/sqlite-temp-dir-helper-20260618 branch June 18, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands Command implementations maintainer Maintainer-authored PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant