fix(ci): stabilize update run gates#94580
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 18, 2026, 9:04 AM ET / 13:04 UTC. Summary PR surface: Source 0, Tests +2. Total +2 across 2 files. Reproducibility: yes. at source level: current main has an unannotated Promise catch callback under an enabled lint rule and a launchd handoff test that does not declare the launchd identity it needs. I did not run tests because this review is read-only. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this narrow CI-stabilization patch after exact-head checks finish green, keeping the runtime update behavior unchanged. Do we have a high-confidence way to reproduce the issue? Yes, at source level: current main has an unannotated Promise catch callback under an enabled lint rule and a launchd handoff test that does not declare the launchd identity it needs. I did not run tests because this review is read-only. Is this the best way to solve the issue? Yes: this is the narrowest maintainable fix, using an existing test env helper and adding only the TypeScript catch type annotation required by the configured rule. Broader runtime changes or loosening the test/lint contract would be less appropriate for the reported gate failures. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 8f295f183da6. Label changesLabel justifications:
Evidence reviewedPR surface: Source 0, Tests +2. Total +2 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Merged via squash.
|
Merged via squash. Prepared head SHA: 93e7843 Co-authored-by: steipete <[email protected]> Reviewed-by: @steipete
Merged via squash. Prepared head SHA: 93e7843 Co-authored-by: steipete <[email protected]> Reviewed-by: @steipete
Summary
This repairs the two mainline failures reproduced by the exact-head CI runs for #94421, #94428, and #94394.
Verification
pnpm exec oxfmt --check src/gateway/server-methods/update.ts src/gateway/server-methods/update.test.tspnpm exec oxlint src/gateway/server-methods/update.ts src/gateway/server-methods/update.test.tspnpm test src/gateway/server-methods/update.test.ts— 58 passedOPENCLAW_LAUNCHD_LABELandOPENCLAW_SYSTEMD_UNITremoved — 58 passed