fix(cron): avoid recomputeNextRuns on forceReload#9393
Open
matthewpapa07 wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(cron): avoid recomputeNextRuns on forceReload#9393matthewpapa07 wants to merge 1 commit intoopenclaw:mainfrom
matthewpapa07 wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Author
|
some cronjobs were broken for me. this patch fixes them. Took a while to find this because my bot kept hallucinating that cron was working |
matthewpapa07
force-pushed
the
fix/cron-force-reload
branch
from
f5729b8 to
70f0ed6
Compare
|
Tested locally — this fix works! Was hitting the exact bug described in #10269 where cron jobs would never execute. Applied this patch to both bundled JS files ( Both systemEvent and agentTurn jobs now fire correctly. Would love to see this merged! 🙏 |
|
Also fixes #10439 (cron scheduler not executing jobs after gateway restart). |
ducminhn
reviewed
Feb 6, 2026
ducminhn
left a comment
ducminhn
left a comment
There was a problem hiding this comment.
This PR fixes issue with cron jobs.
thewilloftheshadow
force-pushed
the
main
branch
from
bfc1ccb to
f92900f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cron timer never running jobs by skipping recomputeNextRuns on forceReload. When forceReload is used each tick, recomputeNextRuns advanced nextRunAtMs into the future, so dueCount stayed 0 forever.
Greptile Overview
Greptile Summary
This PR changes
src/cron/service/store.tsto skiprecomputeNextRuns(state)whenensureLoaded()is called with{ forceReload: true }. This aligns with the timer loop insrc/cron/service/timer.ts, which force-reloads the cron store on every tick before callingrunDueJobs(). The intent is to preventrecomputeNextRunsfrom continually advancingjob.state.nextRunAtMsduring repeated force reloads, which could otherwise keep jobs from ever becoming due.Confidence Score: 5/5
recomputeNextRunsthat only affects the{ forceReload: true }path used by the timer tick; it prevents a confirmed starvation mode without changing job execution or persistence logic.(2/5) Greptile learns from your feedback when you react with thumbs up/down!