Suppress internal source-reply final statuses#93815
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close this PR as superseded: it revives heuristic automatic-mode final suppression that a maintainer already rejected because it can drop substantive final replies without a typed terminal source-reply signal and thread identity. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Canonical path: Close this PR; keep automatic final replies visible by default, use So I’m closing this here because the remaining work is already tracked in the canonical issue. Review detailsBest possible solution: Close this PR; keep automatic final replies visible by default, use Do we have a high-confidence way to reproduce the issue? Yes for the patch risk: source inspection shows the added branch can drop final replies when Is this the best way to solve the issue? No. This is not the best fix because it infers terminal source-reply ownership from prose and reply-threading state; the safer path is Security review: Security review cleared: No concrete security or supply-chain concern was found; the diff only changes TypeScript delivery logic and tests. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against d1b917120a47. |
9d0eab2 to
0d84801
Compare
0d84801 to
f66800b
Compare
Summary
Sent.andDone - posted to #research-tasks., after a group/channel source reply has already been deliveredTest
node scripts/run-vitest.mjs run --config test/vitest/vitest.auto-reply-reply.config.ts src/auto-reply/reply/dispatch-from-config.test.ts214 passed