fix: isolate async model resolution mock from sync mock in flaky test#93714
Merged
vincentkoc merged 1 commit intoJun 16, 2026
Merged
Conversation
The 'can preserve asynchronous provider model discovery' test was flaky because resolveModelAsyncMock in beforeEach delegates to resolveModelMock. When useAsyncModelResolution=true, the test asserted resolveModelMock was not called, but the delegation caused it to be called, failing CI on two lanes. Fix: use a standalone vi.fn() for the async resolver in this test, and explicitly reset resolveModelMock before the assertion to guard against mock state leakage from prior tests. Fixes openclaw#92117
openclaw-barnacle
Bot
added
agents
Member
|
Maintainer verification complete.
Landing via squash merge. |
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jun 17, 2026
…claw#93714) The 'can preserve asynchronous provider model discovery' test was flaky because resolveModelAsyncMock in beforeEach delegates to resolveModelMock. When useAsyncModelResolution=true, the test asserted resolveModelMock was not called, but the delegation caused it to be called, failing CI on two lanes. Fix: use a standalone vi.fn() for the async resolver in this test, and explicitly reset resolveModelMock before the assertion to guard against mock state leakage from prior tests. Fixes openclaw#92117 Co-authored-by: lsr911 <[email protected]>
crh-code
pushed a commit
to crh-code/openclaw
that referenced
this pull request
Jun 18, 2026
…claw#93714) The 'can preserve asynchronous provider model discovery' test was flaky because resolveModelAsyncMock in beforeEach delegates to resolveModelMock. When useAsyncModelResolution=true, the test asserted resolveModelMock was not called, but the delegation caused it to be called, failing CI on two lanes. Fix: use a standalone vi.fn() for the async resolver in this test, and explicitly reset resolveModelMock before the assertion to guard against mock state leakage from prior tests. Fixes openclaw#92117 Co-authored-by: lsr911 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
can preserve asynchronous provider model discoverytest was flaky/failing on CI becauseresolveModelAsyncMockinbeforeEachdelegated toresolveModelMock. WhenuseAsyncModelResolution=true, the test assertedresolveModelMockwas not called, but the delegation in the mock implementation caused it to be called.Fix
Use a standalone
vi.fn()for the async resolver in this test instead of the hoisted mock that delegates to the sync mock. Also explicitly resetresolveModelMockbefore the assertion to guard against mock state leakage from prior tests.Fixes #92117