Keep command text in progress drafts#93711
Conversation
openclaw-barnacle
Bot
added
channel: discord
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3bd8f7fcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const existingDetail = existing.detail?.trim(); | ||
| if (!existingDetail) { | ||
| return incoming; | ||
| } | ||
| const replacement = { | ||
| ...incoming, | ||
| detail: existingDetail, | ||
| text: existing.text, |
There was a problem hiding this comment.
When streaming.progress.commandText is "status", the public config contract says command progress should show only the tool label, but this unconditional preservation can copy an earlier command item detail into the completed command-output line. In the embedded exec path, the command item end is emitted with summary: output immediately before the command_output end event, and buildChannelProgressDraftLine uses input.summary before suppressing command progress text, so a successful command with output can leave that output visible in the final progress draft instead of being replaced by the status-only 🛠️ Exec line.
Useful? React with 👍 / 👎.
e3bd8f7 to
0105a17
Compare
|
Maintainer repair and verification complete.
|
* Keep command text in progress drafts * test(channels): align successful progress drafts --------- Co-authored-by: Vincent Koc <[email protected]>
* Keep command text in progress drafts * test(channels): align successful progress drafts --------- Co-authored-by: Vincent Koc <[email protected]>
2 participants
Summary
completedTests
node scripts/test-projects.mjs src/channels/streaming.test.ts src/plugin-sdk/channel-streaming.test.ts extensions/discord/src/monitor/message-handler.process.test.ts extensions/telegram/src/bot-message-dispatch.test.ts