Skip to content

fix(plugins): allow Dreaming sidecar through restrictive memory allowlists#93678

Merged
vincentkoc merged 1 commit into
mainfrom
clownfish/gitcrawl-426-autonomous-terminal-gap
Jun 16, 2026
Merged

fix(plugins): allow Dreaming sidecar through restrictive memory allowlists#93678
vincentkoc merged 1 commit into
mainfrom
clownfish/gitcrawl-426-autonomous-terminal-gap

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

Fixes #92536.

This completes the Dreaming memory sidecar path when a trusted selected memory plugin, such as memory-lancedb or memory-lancedb-pro, has Dreaming enabled but a restrictive plugins.allow list omits memory-core. The fix should treat memory-core as a narrow runtime dependency of that selected memory slot plugin, not as a general allowlist bypass.

Implementation notes:

  • Keep plugins.deny, entries.memory-core.enabled = false, and plugins.slots.memory = "none" fail-closed.
  • Only authorize memory-core when Dreaming resolves enabled from the selected memory slot plugin config and the selected slot plugin itself is trusted/allowed and memory-kind.
  • Cover full loader, loadModules: false snapshot loading, CLI metadata registry loading, and gateway startup plugin planning.
  • Add regression coverage for memory-lancedb/memory-lancedb-pro-style config where plugins.allow includes the selected memory plugin but omits memory-core, plus disabled/missing-slot negative cases.

Credit: reported by @resYuto in #92536, with additional reproduction detail from @wangsheng520520 and @icophy. This builds on the earlier loader-sidecar work by @pradeep7127 in #65411.

Clownfish 🐠 replacement reef notes:

fish notes: model gpt-5.5, reasoning medium; reviewed against 9d0cd3a.

@vincentkoc vincentkoc added the clownfish Tracked by Clownfish automation label Jun 16, 2026
@vincentkoc
vincentkoc merged commit de1d329 into main Jun 16, 2026
@vincentkoc
vincentkoc deleted the clownfish/gitcrawl-426-autonomous-terminal-gap branch June 16, 2026 15:02
@openclaw-barnacle openclaw-barnacle Bot added size: L maintainer Maintainer-authored PR labels Jun 16, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jun 17, 2026
…lists (openclaw#93678)

Co-authored-by: openclaw-clownfish[bot] <280122609+openclaw-clownfish[bot]@users.noreply.github.com>
Co-authored-by: pradeep7127 <[email protected]>
crh-code pushed a commit to crh-code/openclaw that referenced this pull request Jun 18, 2026
…lists (openclaw#93678)

Co-authored-by: openclaw-clownfish[bot] <280122609+openclaw-clownfish[bot]@users.noreply.github.com>
Co-authored-by: pradeep7127 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clownfish Tracked by Clownfish automation maintainer Maintainer-authored PR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Dreaming sweeps not working if use Dreaming-compatible memory plugin

1 participant